Compare commits
3 Commits
rcc/ant-to
...
rcc/jsonl-
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
5cee042e59 | ||
|
|
c80603556d | ||
|
|
ac6c5d00a8 |
@@ -125,8 +125,8 @@ const SLASH_COMMAND_SPECS: &[SlashCommandSpec] = &[
|
|||||||
},
|
},
|
||||||
SlashCommandSpec {
|
SlashCommandSpec {
|
||||||
name: "session",
|
name: "session",
|
||||||
summary: "List or switch managed local sessions",
|
summary: "List, switch, or fork managed local sessions",
|
||||||
argument_hint: Some("[list|switch <session-id>]"),
|
argument_hint: Some("[list|switch <session-id>|fork [branch-name]]"),
|
||||||
resume_supported: false,
|
resume_supported: false,
|
||||||
},
|
},
|
||||||
];
|
];
|
||||||
@@ -229,7 +229,7 @@ pub fn resume_supported_slash_commands() -> Vec<&'static SlashCommandSpec> {
|
|||||||
pub fn render_slash_command_help() -> String {
|
pub fn render_slash_command_help() -> String {
|
||||||
let mut lines = vec![
|
let mut lines = vec![
|
||||||
"Slash commands".to_string(),
|
"Slash commands".to_string(),
|
||||||
" [resume] means the command also works with --resume SESSION.json".to_string(),
|
" [resume] means the command also works with --resume SESSION.jsonl".to_string(),
|
||||||
];
|
];
|
||||||
for spec in slash_command_specs() {
|
for spec in slash_command_specs() {
|
||||||
let name = match spec.argument_hint {
|
let name = match spec.argument_hint {
|
||||||
@@ -365,12 +365,19 @@ mod tests {
|
|||||||
target: Some("abc123".to_string())
|
target: Some("abc123".to_string())
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
|
assert_eq!(
|
||||||
|
SlashCommand::parse("/session fork incident-review"),
|
||||||
|
Some(SlashCommand::Session {
|
||||||
|
action: Some("fork".to_string()),
|
||||||
|
target: Some("incident-review".to_string())
|
||||||
|
})
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn renders_help_from_shared_specs() {
|
fn renders_help_from_shared_specs() {
|
||||||
let help = render_slash_command_help();
|
let help = render_slash_command_help();
|
||||||
assert!(help.contains("works with --resume SESSION.json"));
|
assert!(help.contains("works with --resume SESSION.jsonl"));
|
||||||
assert!(help.contains("/help"));
|
assert!(help.contains("/help"));
|
||||||
assert!(help.contains("/status"));
|
assert!(help.contains("/status"));
|
||||||
assert!(help.contains("/compact"));
|
assert!(help.contains("/compact"));
|
||||||
@@ -385,16 +392,15 @@ mod tests {
|
|||||||
assert!(help.contains("/diff"));
|
assert!(help.contains("/diff"));
|
||||||
assert!(help.contains("/version"));
|
assert!(help.contains("/version"));
|
||||||
assert!(help.contains("/export [file]"));
|
assert!(help.contains("/export [file]"));
|
||||||
assert!(help.contains("/session [list|switch <session-id>]"));
|
assert!(help.contains("/session [list|switch <session-id>|fork [branch-name]]"));
|
||||||
assert_eq!(slash_command_specs().len(), 15);
|
assert_eq!(slash_command_specs().len(), 15);
|
||||||
assert_eq!(resume_supported_slash_commands().len(), 11);
|
assert_eq!(resume_supported_slash_commands().len(), 11);
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn compacts_sessions_via_slash_command() {
|
fn compacts_sessions_via_slash_command() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![
|
||||||
messages: vec![
|
|
||||||
ConversationMessage::user_text("a ".repeat(200)),
|
ConversationMessage::user_text("a ".repeat(200)),
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
text: "b ".repeat(200),
|
text: "b ".repeat(200),
|
||||||
@@ -403,8 +409,7 @@ mod tests {
|
|||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
text: "recent".to_string(),
|
text: "recent".to_string(),
|
||||||
}]),
|
}]),
|
||||||
],
|
];
|
||||||
};
|
|
||||||
|
|
||||||
let result = handle_slash_command(
|
let result = handle_slash_command(
|
||||||
"/compact",
|
"/compact",
|
||||||
@@ -455,6 +460,12 @@ mod tests {
|
|||||||
CompactionConfig::default()
|
CompactionConfig::default()
|
||||||
)
|
)
|
||||||
.is_none());
|
.is_none());
|
||||||
|
assert!(handle_slash_command(
|
||||||
|
"/resume session.jsonl",
|
||||||
|
&session,
|
||||||
|
CompactionConfig::default()
|
||||||
|
)
|
||||||
|
.is_none());
|
||||||
assert!(handle_slash_command("/config", &session, CompactionConfig::default()).is_none());
|
assert!(handle_slash_command("/config", &session, CompactionConfig::default()).is_none());
|
||||||
assert!(
|
assert!(
|
||||||
handle_slash_command("/config env", &session, CompactionConfig::default()).is_none()
|
handle_slash_command("/config env", &session, CompactionConfig::default()).is_none()
|
||||||
|
|||||||
@@ -99,13 +99,14 @@ pub fn compact_session(session: &Session, config: CompactionConfig) -> Compactio
|
|||||||
}];
|
}];
|
||||||
compacted_messages.extend(preserved);
|
compacted_messages.extend(preserved);
|
||||||
|
|
||||||
|
let mut compacted_session = session.clone();
|
||||||
|
compacted_session.messages = compacted_messages;
|
||||||
|
compacted_session.record_compaction(summary.clone(), removed.len());
|
||||||
|
|
||||||
CompactionResult {
|
CompactionResult {
|
||||||
summary,
|
summary,
|
||||||
formatted_summary,
|
formatted_summary,
|
||||||
compacted_session: Session {
|
compacted_session,
|
||||||
version: session.version,
|
|
||||||
messages: compacted_messages,
|
|
||||||
},
|
|
||||||
removed_message_count: removed.len(),
|
removed_message_count: removed.len(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -390,10 +391,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn leaves_small_sessions_unchanged() {
|
fn leaves_small_sessions_unchanged() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![ConversationMessage::user_text("hello")];
|
||||||
messages: vec![ConversationMessage::user_text("hello")],
|
|
||||||
};
|
|
||||||
|
|
||||||
let result = compact_session(&session, CompactionConfig::default());
|
let result = compact_session(&session, CompactionConfig::default());
|
||||||
assert_eq!(result.removed_message_count, 0);
|
assert_eq!(result.removed_message_count, 0);
|
||||||
@@ -404,9 +403,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn compacts_older_messages_into_a_system_summary() {
|
fn compacts_older_messages_into_a_system_summary() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![
|
||||||
messages: vec![
|
|
||||||
ConversationMessage::user_text("one ".repeat(200)),
|
ConversationMessage::user_text("one ".repeat(200)),
|
||||||
ConversationMessage::assistant(vec![ContentBlock::Text {
|
ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
text: "two ".repeat(200),
|
text: "two ".repeat(200),
|
||||||
@@ -419,8 +417,7 @@ mod tests {
|
|||||||
}],
|
}],
|
||||||
usage: None,
|
usage: None,
|
||||||
},
|
},
|
||||||
],
|
];
|
||||||
};
|
|
||||||
|
|
||||||
let result = compact_session(
|
let result = compact_session(
|
||||||
&session,
|
&session,
|
||||||
|
|||||||
@@ -37,6 +37,7 @@ pub struct RuntimeConfig {
|
|||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
pub struct RuntimeFeatureConfig {
|
pub struct RuntimeFeatureConfig {
|
||||||
|
hooks: RuntimeHookConfig,
|
||||||
mcp: McpConfigCollection,
|
mcp: McpConfigCollection,
|
||||||
oauth: Option<OAuthConfig>,
|
oauth: Option<OAuthConfig>,
|
||||||
model: Option<String>,
|
model: Option<String>,
|
||||||
@@ -44,6 +45,12 @@ pub struct RuntimeFeatureConfig {
|
|||||||
sandbox: SandboxConfig,
|
sandbox: SandboxConfig,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct RuntimeHookConfig {
|
||||||
|
pre_tool_use: Vec<String>,
|
||||||
|
post_tool_use: Vec<String>,
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
pub struct McpConfigCollection {
|
pub struct McpConfigCollection {
|
||||||
servers: BTreeMap<String, ScopedMcpServerConfig>,
|
servers: BTreeMap<String, ScopedMcpServerConfig>,
|
||||||
@@ -221,6 +228,7 @@ impl ConfigLoader {
|
|||||||
let merged_value = JsonValue::Object(merged.clone());
|
let merged_value = JsonValue::Object(merged.clone());
|
||||||
|
|
||||||
let feature_config = RuntimeFeatureConfig {
|
let feature_config = RuntimeFeatureConfig {
|
||||||
|
hooks: parse_optional_hooks_config(&merged_value)?,
|
||||||
mcp: McpConfigCollection {
|
mcp: McpConfigCollection {
|
||||||
servers: mcp_servers,
|
servers: mcp_servers,
|
||||||
},
|
},
|
||||||
@@ -278,6 +286,11 @@ impl RuntimeConfig {
|
|||||||
&self.feature_config.mcp
|
&self.feature_config.mcp
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn hooks(&self) -> &RuntimeHookConfig {
|
||||||
|
&self.feature_config.hooks
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
||||||
self.feature_config.oauth.as_ref()
|
self.feature_config.oauth.as_ref()
|
||||||
@@ -300,6 +313,17 @@ impl RuntimeConfig {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl RuntimeFeatureConfig {
|
impl RuntimeFeatureConfig {
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_hooks(mut self, hooks: RuntimeHookConfig) -> Self {
|
||||||
|
self.hooks = hooks;
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn hooks(&self) -> &RuntimeHookConfig {
|
||||||
|
&self.hooks
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn mcp(&self) -> &McpConfigCollection {
|
pub fn mcp(&self) -> &McpConfigCollection {
|
||||||
&self.mcp
|
&self.mcp
|
||||||
@@ -326,6 +350,26 @@ impl RuntimeFeatureConfig {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl RuntimeHookConfig {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(pre_tool_use: Vec<String>, post_tool_use: Vec<String>) -> Self {
|
||||||
|
Self {
|
||||||
|
pre_tool_use,
|
||||||
|
post_tool_use,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn pre_tool_use(&self) -> &[String] {
|
||||||
|
&self.pre_tool_use
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn post_tool_use(&self) -> &[String] {
|
||||||
|
&self.post_tool_use
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
impl McpConfigCollection {
|
impl McpConfigCollection {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn servers(&self) -> &BTreeMap<String, ScopedMcpServerConfig> {
|
pub fn servers(&self) -> &BTreeMap<String, ScopedMcpServerConfig> {
|
||||||
@@ -424,6 +468,22 @@ fn parse_optional_model(root: &JsonValue) -> Option<String> {
|
|||||||
.map(ToOwned::to_owned)
|
.map(ToOwned::to_owned)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn parse_optional_hooks_config(root: &JsonValue) -> Result<RuntimeHookConfig, ConfigError> {
|
||||||
|
let Some(object) = root.as_object() else {
|
||||||
|
return Ok(RuntimeHookConfig::default());
|
||||||
|
};
|
||||||
|
let Some(hooks_value) = object.get("hooks") else {
|
||||||
|
return Ok(RuntimeHookConfig::default());
|
||||||
|
};
|
||||||
|
let hooks = expect_object(hooks_value, "merged settings.hooks")?;
|
||||||
|
Ok(RuntimeHookConfig {
|
||||||
|
pre_tool_use: optional_string_array(hooks, "PreToolUse", "merged settings.hooks")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
post_tool_use: optional_string_array(hooks, "PostToolUse", "merged settings.hooks")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
fn parse_optional_permission_mode(
|
fn parse_optional_permission_mode(
|
||||||
root: &JsonValue,
|
root: &JsonValue,
|
||||||
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
||||||
@@ -836,6 +896,8 @@ mod tests {
|
|||||||
.and_then(JsonValue::as_object)
|
.and_then(JsonValue::as_object)
|
||||||
.expect("hooks object")
|
.expect("hooks object")
|
||||||
.contains_key("PostToolUse"));
|
.contains_key("PostToolUse"));
|
||||||
|
assert_eq!(loaded.hooks().pre_tool_use(), &["base".to_string()]);
|
||||||
|
assert_eq!(loaded.hooks().post_tool_use(), &["project".to_string()]);
|
||||||
assert!(loaded.mcp().get("home").is_some());
|
assert!(loaded.mcp().get("home").is_some());
|
||||||
assert!(loaded.mcp().get("project").is_some());
|
assert!(loaded.mcp().get("project").is_some());
|
||||||
|
|
||||||
|
|||||||
@@ -4,6 +4,8 @@ use std::fmt::{Display, Formatter};
|
|||||||
use crate::compact::{
|
use crate::compact::{
|
||||||
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
||||||
};
|
};
|
||||||
|
use crate::config::RuntimeFeatureConfig;
|
||||||
|
use crate::hooks::{HookRunResult, HookRunner};
|
||||||
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
||||||
use crate::session::{ContentBlock, ConversationMessage, Session};
|
use crate::session::{ContentBlock, ConversationMessage, Session};
|
||||||
use crate::usage::{TokenUsage, UsageTracker};
|
use crate::usage::{TokenUsage, UsageTracker};
|
||||||
@@ -94,6 +96,7 @@ pub struct ConversationRuntime<C, T> {
|
|||||||
system_prompt: Vec<String>,
|
system_prompt: Vec<String>,
|
||||||
max_iterations: usize,
|
max_iterations: usize,
|
||||||
usage_tracker: UsageTracker,
|
usage_tracker: UsageTracker,
|
||||||
|
hook_runner: HookRunner,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T>
|
impl<C, T> ConversationRuntime<C, T>
|
||||||
@@ -108,6 +111,25 @@ where
|
|||||||
tool_executor: T,
|
tool_executor: T,
|
||||||
permission_policy: PermissionPolicy,
|
permission_policy: PermissionPolicy,
|
||||||
system_prompt: Vec<String>,
|
system_prompt: Vec<String>,
|
||||||
|
) -> Self {
|
||||||
|
Self::new_with_features(
|
||||||
|
session,
|
||||||
|
api_client,
|
||||||
|
tool_executor,
|
||||||
|
permission_policy,
|
||||||
|
system_prompt,
|
||||||
|
RuntimeFeatureConfig::default(),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn new_with_features(
|
||||||
|
session: Session,
|
||||||
|
api_client: C,
|
||||||
|
tool_executor: T,
|
||||||
|
permission_policy: PermissionPolicy,
|
||||||
|
system_prompt: Vec<String>,
|
||||||
|
feature_config: RuntimeFeatureConfig,
|
||||||
) -> Self {
|
) -> Self {
|
||||||
let usage_tracker = UsageTracker::from_session(&session);
|
let usage_tracker = UsageTracker::from_session(&session);
|
||||||
Self {
|
Self {
|
||||||
@@ -118,6 +140,7 @@ where
|
|||||||
system_prompt,
|
system_prompt,
|
||||||
max_iterations: usize::MAX,
|
max_iterations: usize::MAX,
|
||||||
usage_tracker,
|
usage_tracker,
|
||||||
|
hook_runner: HookRunner::from_feature_config(&feature_config),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -133,8 +156,8 @@ where
|
|||||||
mut prompter: Option<&mut dyn PermissionPrompter>,
|
mut prompter: Option<&mut dyn PermissionPrompter>,
|
||||||
) -> Result<TurnSummary, RuntimeError> {
|
) -> Result<TurnSummary, RuntimeError> {
|
||||||
self.session
|
self.session
|
||||||
.messages
|
.push_user_text(user_input.into())
|
||||||
.push(ConversationMessage::user_text(user_input.into()));
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
|
|
||||||
let mut assistant_messages = Vec::new();
|
let mut assistant_messages = Vec::new();
|
||||||
let mut tool_results = Vec::new();
|
let mut tool_results = Vec::new();
|
||||||
@@ -168,7 +191,9 @@ where
|
|||||||
})
|
})
|
||||||
.collect::<Vec<_>>();
|
.collect::<Vec<_>>();
|
||||||
|
|
||||||
self.session.messages.push(assistant_message.clone());
|
self.session
|
||||||
|
.push_message(assistant_message.clone())
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
assistant_messages.push(assistant_message);
|
assistant_messages.push(assistant_message);
|
||||||
|
|
||||||
if pending_tool_uses.is_empty() {
|
if pending_tool_uses.is_empty() {
|
||||||
@@ -185,26 +210,50 @@ where
|
|||||||
|
|
||||||
let result_message = match permission_outcome {
|
let result_message = match permission_outcome {
|
||||||
PermissionOutcome::Allow => {
|
PermissionOutcome::Allow => {
|
||||||
|
let pre_hook_result = self.hook_runner.run_pre_tool_use(&tool_name, &input);
|
||||||
|
if pre_hook_result.is_denied() {
|
||||||
|
let deny_message = format!("PreToolUse hook denied tool `{tool_name}`");
|
||||||
|
ConversationMessage::tool_result(
|
||||||
|
tool_use_id,
|
||||||
|
tool_name,
|
||||||
|
format_hook_message(&pre_hook_result, &deny_message),
|
||||||
|
true,
|
||||||
|
)
|
||||||
|
} else {
|
||||||
|
let (mut output, mut is_error) =
|
||||||
match self.tool_executor.execute(&tool_name, &input) {
|
match self.tool_executor.execute(&tool_name, &input) {
|
||||||
Ok(output) => ConversationMessage::tool_result(
|
Ok(output) => (output, false),
|
||||||
|
Err(error) => (error.to_string(), true),
|
||||||
|
};
|
||||||
|
output = merge_hook_feedback(pre_hook_result.messages(), output, false);
|
||||||
|
|
||||||
|
let post_hook_result = self
|
||||||
|
.hook_runner
|
||||||
|
.run_post_tool_use(&tool_name, &input, &output, is_error);
|
||||||
|
if post_hook_result.is_denied() {
|
||||||
|
is_error = true;
|
||||||
|
}
|
||||||
|
output = merge_hook_feedback(
|
||||||
|
post_hook_result.messages(),
|
||||||
|
output,
|
||||||
|
post_hook_result.is_denied(),
|
||||||
|
);
|
||||||
|
|
||||||
|
ConversationMessage::tool_result(
|
||||||
tool_use_id,
|
tool_use_id,
|
||||||
tool_name,
|
tool_name,
|
||||||
output,
|
output,
|
||||||
false,
|
is_error,
|
||||||
),
|
)
|
||||||
Err(error) => ConversationMessage::tool_result(
|
|
||||||
tool_use_id,
|
|
||||||
tool_name,
|
|
||||||
error.to_string(),
|
|
||||||
true,
|
|
||||||
),
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
PermissionOutcome::Deny { reason } => {
|
PermissionOutcome::Deny { reason } => {
|
||||||
ConversationMessage::tool_result(tool_use_id, tool_name, reason, true)
|
ConversationMessage::tool_result(tool_use_id, tool_name, reason, true)
|
||||||
}
|
}
|
||||||
};
|
};
|
||||||
self.session.messages.push(result_message.clone());
|
self.session
|
||||||
|
.push_message(result_message.clone())
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
tool_results.push(result_message);
|
tool_results.push(result_message);
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -237,6 +286,11 @@ where
|
|||||||
&self.session
|
&self.session
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn fork_session(&self, branch_name: Option<String>) -> Session {
|
||||||
|
self.session.fork(branch_name)
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn into_session(self) -> Session {
|
pub fn into_session(self) -> Session {
|
||||||
self.session
|
self.session
|
||||||
@@ -290,6 +344,32 @@ fn flush_text_block(text: &mut String, blocks: &mut Vec<ContentBlock>) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn format_hook_message(result: &HookRunResult, fallback: &str) -> String {
|
||||||
|
if result.messages().is_empty() {
|
||||||
|
fallback.to_string()
|
||||||
|
} else {
|
||||||
|
result.messages().join("\n")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn merge_hook_feedback(messages: &[String], output: String, denied: bool) -> String {
|
||||||
|
if messages.is_empty() {
|
||||||
|
return output;
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut sections = Vec::new();
|
||||||
|
if !output.trim().is_empty() {
|
||||||
|
sections.push(output);
|
||||||
|
}
|
||||||
|
let label = if denied {
|
||||||
|
"Hook feedback (denied)"
|
||||||
|
} else {
|
||||||
|
"Hook feedback"
|
||||||
|
};
|
||||||
|
sections.push(format!("{label}:\n{}", messages.join("\n")));
|
||||||
|
sections.join("\n\n")
|
||||||
|
}
|
||||||
|
|
||||||
type ToolHandler = Box<dyn FnMut(&str) -> Result<String, ToolError>>;
|
type ToolHandler = Box<dyn FnMut(&str) -> Result<String, ToolError>>;
|
||||||
|
|
||||||
#[derive(Default)]
|
#[derive(Default)]
|
||||||
@@ -329,6 +409,7 @@ mod tests {
|
|||||||
StaticToolExecutor,
|
StaticToolExecutor,
|
||||||
};
|
};
|
||||||
use crate::compact::CompactionConfig;
|
use crate::compact::CompactionConfig;
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
use crate::permissions::{
|
use crate::permissions::{
|
||||||
PermissionMode, PermissionPolicy, PermissionPromptDecision, PermissionPrompter,
|
PermissionMode, PermissionPolicy, PermissionPromptDecision, PermissionPrompter,
|
||||||
PermissionRequest,
|
PermissionRequest,
|
||||||
@@ -336,7 +417,9 @@ mod tests {
|
|||||||
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
||||||
use crate::session::{ContentBlock, MessageRole, Session};
|
use crate::session::{ContentBlock, MessageRole, Session};
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
|
use std::fs;
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
struct ScriptedApiClient {
|
struct ScriptedApiClient {
|
||||||
call_count: usize,
|
call_count: usize,
|
||||||
@@ -503,6 +586,141 @@ mod tests {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn denies_tool_use_when_pre_tool_hook_blocks() {
|
||||||
|
struct SingleCallApiClient;
|
||||||
|
impl ApiClient for SingleCallApiClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
if request
|
||||||
|
.messages
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.role == MessageRole::Tool)
|
||||||
|
{
|
||||||
|
return Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("blocked".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
]);
|
||||||
|
}
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "blocked".to_string(),
|
||||||
|
input: r#"{"path":"secret.txt"}"#.to_string(),
|
||||||
|
},
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut runtime = ConversationRuntime::new_with_features(
|
||||||
|
Session::new(),
|
||||||
|
SingleCallApiClient,
|
||||||
|
StaticToolExecutor::new().register("blocked", |_input| {
|
||||||
|
panic!("tool should not execute when hook denies")
|
||||||
|
}),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
||||||
|
Vec::new(),
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn("use the tool", None)
|
||||||
|
.expect("conversation should continue after hook denial");
|
||||||
|
|
||||||
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
|
let ContentBlock::ToolResult {
|
||||||
|
is_error, output, ..
|
||||||
|
} = &summary.tool_results[0].blocks[0]
|
||||||
|
else {
|
||||||
|
panic!("expected tool result block");
|
||||||
|
};
|
||||||
|
assert!(
|
||||||
|
*is_error,
|
||||||
|
"hook denial should produce an error result: {output}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("denied tool") || output.contains("blocked by hook"),
|
||||||
|
"unexpected hook denial output: {output:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn appends_post_tool_hook_feedback_to_tool_result() {
|
||||||
|
struct TwoCallApiClient {
|
||||||
|
calls: usize,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ApiClient for TwoCallApiClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
self.calls += 1;
|
||||||
|
match self.calls {
|
||||||
|
1 => Ok(vec![
|
||||||
|
AssistantEvent::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "add".to_string(),
|
||||||
|
input: r#"{"lhs":2,"rhs":2}"#.to_string(),
|
||||||
|
},
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
]),
|
||||||
|
2 => {
|
||||||
|
assert!(request
|
||||||
|
.messages
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.role == MessageRole::Tool));
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("done".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
_ => Err(RuntimeError::new("unexpected extra API call")),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut runtime = ConversationRuntime::new_with_features(
|
||||||
|
Session::new(),
|
||||||
|
TwoCallApiClient { calls: 0 },
|
||||||
|
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'pre hook ran'")],
|
||||||
|
vec![shell_snippet("printf 'post hook ran'")],
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn("use add", None)
|
||||||
|
.expect("tool loop succeeds");
|
||||||
|
|
||||||
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
|
let ContentBlock::ToolResult {
|
||||||
|
is_error, output, ..
|
||||||
|
} = &summary.tool_results[0].blocks[0]
|
||||||
|
else {
|
||||||
|
panic!("expected tool result block");
|
||||||
|
};
|
||||||
|
assert!(
|
||||||
|
!*is_error,
|
||||||
|
"post hook should preserve non-error result: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("4"),
|
||||||
|
"tool output missing value: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("pre hook ran"),
|
||||||
|
"tool output missing pre hook feedback: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("post hook ran"),
|
||||||
|
"tool output missing post hook feedback: {output:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_tracker_from_restored_session() {
|
fn reconstructs_usage_tracker_from_restored_session() {
|
||||||
struct SimpleApi;
|
struct SimpleApi;
|
||||||
@@ -580,5 +798,95 @@ mod tests {
|
|||||||
result.compacted_session.messages[0].role,
|
result.compacted_session.messages[0].role,
|
||||||
MessageRole::System
|
MessageRole::System
|
||||||
);
|
);
|
||||||
|
assert_eq!(
|
||||||
|
result.compacted_session.session_id,
|
||||||
|
runtime.session().session_id
|
||||||
|
);
|
||||||
|
assert!(result.compacted_session.compaction.is_some());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn persists_conversation_turn_messages_to_jsonl_session() {
|
||||||
|
struct SimpleApi;
|
||||||
|
impl ApiClient for SimpleApi {
|
||||||
|
fn stream(
|
||||||
|
&mut self,
|
||||||
|
_request: ApiRequest,
|
||||||
|
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("done".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let path = temp_session_path("persisted-turn");
|
||||||
|
let session = Session::new().with_persistence_path(path.clone());
|
||||||
|
let mut runtime = ConversationRuntime::new(
|
||||||
|
session,
|
||||||
|
SimpleApi,
|
||||||
|
StaticToolExecutor::new(),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
);
|
||||||
|
|
||||||
|
runtime
|
||||||
|
.run_turn("persist this turn", None)
|
||||||
|
.expect("turn should succeed");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("persisted session should reload");
|
||||||
|
fs::remove_file(&path).expect("temp session file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 2);
|
||||||
|
assert_eq!(restored.messages[0].role, MessageRole::User);
|
||||||
|
assert_eq!(restored.messages[1].role, MessageRole::Assistant);
|
||||||
|
assert_eq!(restored.session_id, runtime.session().session_id);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn forks_runtime_session_without_mutating_original() {
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("branch me")
|
||||||
|
.expect("message should append");
|
||||||
|
|
||||||
|
let runtime = ConversationRuntime::new(
|
||||||
|
session.clone(),
|
||||||
|
ScriptedApiClient { call_count: 0 },
|
||||||
|
StaticToolExecutor::new(),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
);
|
||||||
|
|
||||||
|
let forked = runtime.fork_session(Some("alt-path".to_string()));
|
||||||
|
|
||||||
|
assert_eq!(forked.messages, session.messages);
|
||||||
|
assert_ne!(forked.session_id, session.session_id);
|
||||||
|
assert_eq!(
|
||||||
|
forked
|
||||||
|
.fork
|
||||||
|
.as_ref()
|
||||||
|
.map(|fork| (fork.parent_session_id.as_str(), fork.branch_name.as_deref())),
|
||||||
|
Some((session.session_id.as_str(), Some("alt-path")))
|
||||||
|
);
|
||||||
|
assert!(runtime.session().fork.is_none());
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temp_session_path(label: &str) -> PathBuf {
|
||||||
|
let nanos = SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.expect("system time should be after epoch")
|
||||||
|
.as_nanos();
|
||||||
|
std::env::temp_dir().join(format!("runtime-conversation-{label}-{nanos}.json"))
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.replace('\'', "\"")
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.to_string()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
349
rust/crates/runtime/src/hooks.rs
Normal file
349
rust/crates/runtime/src/hooks.rs
Normal file
@@ -0,0 +1,349 @@
|
|||||||
|
use std::ffi::OsStr;
|
||||||
|
use std::process::Command;
|
||||||
|
|
||||||
|
use serde_json::json;
|
||||||
|
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum HookEvent {
|
||||||
|
PreToolUse,
|
||||||
|
PostToolUse,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookEvent {
|
||||||
|
fn as_str(self) -> &'static str {
|
||||||
|
match self {
|
||||||
|
Self::PreToolUse => "PreToolUse",
|
||||||
|
Self::PostToolUse => "PostToolUse",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct HookRunResult {
|
||||||
|
denied: bool,
|
||||||
|
messages: Vec<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookRunResult {
|
||||||
|
#[must_use]
|
||||||
|
pub fn allow(messages: Vec<String>) -> Self {
|
||||||
|
Self {
|
||||||
|
denied: false,
|
||||||
|
messages,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn is_denied(&self) -> bool {
|
||||||
|
self.denied
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn messages(&self) -> &[String] {
|
||||||
|
&self.messages
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct HookRunner {
|
||||||
|
config: RuntimeHookConfig,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookRunner {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(config: RuntimeHookConfig) -> Self {
|
||||||
|
Self { config }
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn from_feature_config(feature_config: &RuntimeFeatureConfig) -> Self {
|
||||||
|
Self::new(feature_config.hooks().clone())
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_pre_tool_use(&self, tool_name: &str, tool_input: &str) -> HookRunResult {
|
||||||
|
self.run_commands(
|
||||||
|
HookEvent::PreToolUse,
|
||||||
|
self.config.pre_tool_use(),
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
None,
|
||||||
|
false,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: &str,
|
||||||
|
is_error: bool,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_commands(
|
||||||
|
HookEvent::PostToolUse,
|
||||||
|
self.config.post_tool_use(),
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
Some(tool_output),
|
||||||
|
is_error,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_commands(
|
||||||
|
&self,
|
||||||
|
event: HookEvent,
|
||||||
|
commands: &[String],
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: Option<&str>,
|
||||||
|
is_error: bool,
|
||||||
|
) -> HookRunResult {
|
||||||
|
if commands.is_empty() {
|
||||||
|
return HookRunResult::allow(Vec::new());
|
||||||
|
}
|
||||||
|
|
||||||
|
let payload = json!({
|
||||||
|
"hook_event_name": event.as_str(),
|
||||||
|
"tool_name": tool_name,
|
||||||
|
"tool_input": parse_tool_input(tool_input),
|
||||||
|
"tool_input_json": tool_input,
|
||||||
|
"tool_output": tool_output,
|
||||||
|
"tool_result_is_error": is_error,
|
||||||
|
})
|
||||||
|
.to_string();
|
||||||
|
|
||||||
|
let mut messages = Vec::new();
|
||||||
|
|
||||||
|
for command in commands {
|
||||||
|
match self.run_command(
|
||||||
|
command,
|
||||||
|
event,
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
tool_output,
|
||||||
|
is_error,
|
||||||
|
&payload,
|
||||||
|
) {
|
||||||
|
HookCommandOutcome::Allow { message } => {
|
||||||
|
if let Some(message) = message {
|
||||||
|
messages.push(message);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
HookCommandOutcome::Deny { message } => {
|
||||||
|
let message = message.unwrap_or_else(|| {
|
||||||
|
format!("{} hook denied tool `{tool_name}`", event.as_str())
|
||||||
|
});
|
||||||
|
messages.push(message);
|
||||||
|
return HookRunResult {
|
||||||
|
denied: true,
|
||||||
|
messages,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
HookCommandOutcome::Warn { message } => messages.push(message),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
HookRunResult::allow(messages)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_command(
|
||||||
|
&self,
|
||||||
|
command: &str,
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: Option<&str>,
|
||||||
|
is_error: bool,
|
||||||
|
payload: &str,
|
||||||
|
) -> HookCommandOutcome {
|
||||||
|
let mut child = shell_command(command);
|
||||||
|
child.stdin(std::process::Stdio::piped());
|
||||||
|
child.stdout(std::process::Stdio::piped());
|
||||||
|
child.stderr(std::process::Stdio::piped());
|
||||||
|
child.env("HOOK_EVENT", event.as_str());
|
||||||
|
child.env("HOOK_TOOL_NAME", tool_name);
|
||||||
|
child.env("HOOK_TOOL_INPUT", tool_input);
|
||||||
|
child.env("HOOK_TOOL_IS_ERROR", if is_error { "1" } else { "0" });
|
||||||
|
if let Some(tool_output) = tool_output {
|
||||||
|
child.env("HOOK_TOOL_OUTPUT", tool_output);
|
||||||
|
}
|
||||||
|
|
||||||
|
match child.output_with_stdin(payload.as_bytes()) {
|
||||||
|
Ok(output) => {
|
||||||
|
let stdout = String::from_utf8_lossy(&output.stdout).trim().to_string();
|
||||||
|
let stderr = String::from_utf8_lossy(&output.stderr).trim().to_string();
|
||||||
|
let message = (!stdout.is_empty()).then_some(stdout);
|
||||||
|
match output.status.code() {
|
||||||
|
Some(0) => HookCommandOutcome::Allow { message },
|
||||||
|
Some(2) => HookCommandOutcome::Deny { message },
|
||||||
|
Some(code) => HookCommandOutcome::Warn {
|
||||||
|
message: format_hook_warning(
|
||||||
|
command,
|
||||||
|
code,
|
||||||
|
message.as_deref(),
|
||||||
|
stderr.as_str(),
|
||||||
|
),
|
||||||
|
},
|
||||||
|
None => HookCommandOutcome::Warn {
|
||||||
|
message: format!(
|
||||||
|
"{} hook `{command}` terminated by signal while handling `{tool_name}`",
|
||||||
|
event.as_str()
|
||||||
|
),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Err(error) => HookCommandOutcome::Warn {
|
||||||
|
message: format!(
|
||||||
|
"{} hook `{command}` failed to start for `{tool_name}`: {error}",
|
||||||
|
event.as_str()
|
||||||
|
),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
enum HookCommandOutcome {
|
||||||
|
Allow { message: Option<String> },
|
||||||
|
Deny { message: Option<String> },
|
||||||
|
Warn { message: String },
|
||||||
|
}
|
||||||
|
|
||||||
|
fn parse_tool_input(tool_input: &str) -> serde_json::Value {
|
||||||
|
serde_json::from_str(tool_input).unwrap_or_else(|_| json!({ "raw": tool_input }))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn format_hook_warning(command: &str, code: i32, stdout: Option<&str>, stderr: &str) -> String {
|
||||||
|
let mut message =
|
||||||
|
format!("Hook `{command}` exited with status {code}; allowing tool execution to continue");
|
||||||
|
if let Some(stdout) = stdout.filter(|stdout| !stdout.is_empty()) {
|
||||||
|
message.push_str(": ");
|
||||||
|
message.push_str(stdout);
|
||||||
|
} else if !stderr.is_empty() {
|
||||||
|
message.push_str(": ");
|
||||||
|
message.push_str(stderr);
|
||||||
|
}
|
||||||
|
message
|
||||||
|
}
|
||||||
|
|
||||||
|
fn shell_command(command: &str) -> CommandWithStdin {
|
||||||
|
#[cfg(windows)]
|
||||||
|
let mut command_builder = {
|
||||||
|
let mut command_builder = Command::new("cmd");
|
||||||
|
command_builder.arg("/C").arg(command);
|
||||||
|
CommandWithStdin::new(command_builder)
|
||||||
|
};
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
let command_builder = {
|
||||||
|
let mut command_builder = Command::new("sh");
|
||||||
|
command_builder.arg("-lc").arg(command);
|
||||||
|
CommandWithStdin::new(command_builder)
|
||||||
|
};
|
||||||
|
|
||||||
|
command_builder
|
||||||
|
}
|
||||||
|
|
||||||
|
struct CommandWithStdin {
|
||||||
|
command: Command,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl CommandWithStdin {
|
||||||
|
fn new(command: Command) -> Self {
|
||||||
|
Self { command }
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stdin(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
||||||
|
self.command.stdin(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stdout(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
||||||
|
self.command.stdout(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stderr(&mut self, cfg: std::process::Stdio) -> &mut Self {
|
||||||
|
self.command.stderr(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn env<K, V>(&mut self, key: K, value: V) -> &mut Self
|
||||||
|
where
|
||||||
|
K: AsRef<OsStr>,
|
||||||
|
V: AsRef<OsStr>,
|
||||||
|
{
|
||||||
|
self.command.env(key, value);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn output_with_stdin(&mut self, stdin: &[u8]) -> std::io::Result<std::process::Output> {
|
||||||
|
let mut child = self.command.spawn()?;
|
||||||
|
if let Some(mut child_stdin) = child.stdin.take() {
|
||||||
|
use std::io::Write;
|
||||||
|
child_stdin.write_all(stdin)?;
|
||||||
|
}
|
||||||
|
child.wait_with_output()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use super::{HookRunResult, HookRunner};
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn allows_exit_code_zero_and_captures_stdout() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'pre ok'")],
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Read", r#"{"path":"README.md"}"#);
|
||||||
|
|
||||||
|
assert_eq!(result, HookRunResult::allow(vec!["pre ok".to_string()]));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn denies_exit_code_two() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Bash", r#"{"command":"pwd"}"#);
|
||||||
|
|
||||||
|
assert!(result.is_denied());
|
||||||
|
assert_eq!(result.messages(), &["blocked by hook".to_string()]);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn warns_for_other_non_zero_statuses() {
|
||||||
|
let runner = HookRunner::from_feature_config(&RuntimeFeatureConfig::default().with_hooks(
|
||||||
|
RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'warning hook'; exit 1")],
|
||||||
|
Vec::new(),
|
||||||
|
),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Edit", r#"{"file":"src/lib.rs"}"#);
|
||||||
|
|
||||||
|
assert!(!result.is_denied());
|
||||||
|
assert!(result
|
||||||
|
.messages()
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.contains("allowing tool execution to continue")));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.replace('\'', "\"")
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.to_string()
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -4,6 +4,7 @@ mod compact;
|
|||||||
mod config;
|
mod config;
|
||||||
mod conversation;
|
mod conversation;
|
||||||
mod file_ops;
|
mod file_ops;
|
||||||
|
mod hooks;
|
||||||
mod json;
|
mod json;
|
||||||
mod mcp;
|
mod mcp;
|
||||||
mod mcp_client;
|
mod mcp_client;
|
||||||
@@ -26,8 +27,8 @@ pub use config::{
|
|||||||
ConfigEntry, ConfigError, ConfigLoader, ConfigSource, McpClaudeAiProxyServerConfig,
|
ConfigEntry, ConfigError, ConfigLoader, ConfigSource, McpClaudeAiProxyServerConfig,
|
||||||
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
||||||
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
||||||
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, ScopedMcpServerConfig,
|
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, RuntimeHookConfig,
|
||||||
CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
ScopedMcpServerConfig, CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
||||||
};
|
};
|
||||||
pub use conversation::{
|
pub use conversation::{
|
||||||
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
||||||
@@ -38,6 +39,7 @@ pub use file_ops::{
|
|||||||
GrepSearchInput, GrepSearchOutput, ReadFileOutput, StructuredPatchHunk, TextFilePayload,
|
GrepSearchInput, GrepSearchOutput, ReadFileOutput, StructuredPatchHunk, TextFilePayload,
|
||||||
WriteFileOutput,
|
WriteFileOutput,
|
||||||
};
|
};
|
||||||
|
pub use hooks::{HookEvent, HookRunResult, HookRunner};
|
||||||
pub use mcp::{
|
pub use mcp::{
|
||||||
mcp_server_signature, mcp_tool_name, mcp_tool_prefix, normalize_name_for_mcp,
|
mcp_server_signature, mcp_tool_name, mcp_tool_prefix, normalize_name_for_mcp,
|
||||||
scoped_mcp_config_hash, unwrap_ccr_proxy_url,
|
scoped_mcp_config_hash, unwrap_ccr_proxy_url,
|
||||||
@@ -74,7 +76,10 @@ pub use remote::{
|
|||||||
RemoteSessionContext, UpstreamProxyBootstrap, UpstreamProxyState, DEFAULT_REMOTE_BASE_URL,
|
RemoteSessionContext, UpstreamProxyBootstrap, UpstreamProxyState, DEFAULT_REMOTE_BASE_URL,
|
||||||
DEFAULT_SESSION_TOKEN_PATH, DEFAULT_SYSTEM_CA_BUNDLE, NO_PROXY_HOSTS, UPSTREAM_PROXY_ENV_KEYS,
|
DEFAULT_SESSION_TOKEN_PATH, DEFAULT_SYSTEM_CA_BUNDLE, NO_PROXY_HOSTS, UPSTREAM_PROXY_ENV_KEYS,
|
||||||
};
|
};
|
||||||
pub use session::{ContentBlock, ConversationMessage, MessageRole, Session, SessionError};
|
pub use session::{
|
||||||
|
ContentBlock, ConversationMessage, MessageRole, Session, SessionCompaction, SessionError,
|
||||||
|
SessionFork,
|
||||||
|
};
|
||||||
pub use usage::{
|
pub use usage::{
|
||||||
format_usd, pricing_for_model, ModelPricing, TokenUsage, UsageCostEstimate, UsageTracker,
|
format_usd, pricing_for_model, ModelPricing, TokenUsage, UsageCostEstimate, UsageTracker,
|
||||||
};
|
};
|
||||||
|
|||||||
@@ -1,11 +1,19 @@
|
|||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
use std::fmt::{Display, Formatter};
|
use std::fmt::{Display, Formatter};
|
||||||
use std::fs;
|
use std::fs::{self, OpenOptions};
|
||||||
use std::path::Path;
|
use std::io::Write;
|
||||||
|
use std::path::{Path, PathBuf};
|
||||||
|
use std::sync::atomic::{AtomicU64, Ordering};
|
||||||
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
use crate::json::{JsonError, JsonValue};
|
use crate::json::{JsonError, JsonValue};
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
|
|
||||||
|
const SESSION_VERSION: u32 = 1;
|
||||||
|
const ROTATE_AFTER_BYTES: u64 = 256 * 1024;
|
||||||
|
const MAX_ROTATED_FILES: usize = 3;
|
||||||
|
static SESSION_ID_COUNTER: AtomicU64 = AtomicU64::new(0);
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
pub enum MessageRole {
|
pub enum MessageRole {
|
||||||
System,
|
System,
|
||||||
@@ -40,11 +48,49 @@ pub struct ConversationMessage {
|
|||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct SessionCompaction {
|
||||||
|
pub count: u32,
|
||||||
|
pub removed_message_count: usize,
|
||||||
|
pub summary: String,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct SessionFork {
|
||||||
|
pub parent_session_id: String,
|
||||||
|
pub branch_name: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct SessionPersistence {
|
||||||
|
path: PathBuf,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone)]
|
||||||
pub struct Session {
|
pub struct Session {
|
||||||
pub version: u32,
|
pub version: u32,
|
||||||
|
pub session_id: String,
|
||||||
|
pub created_at_ms: u64,
|
||||||
|
pub updated_at_ms: u64,
|
||||||
pub messages: Vec<ConversationMessage>,
|
pub messages: Vec<ConversationMessage>,
|
||||||
|
pub compaction: Option<SessionCompaction>,
|
||||||
|
pub fork: Option<SessionFork>,
|
||||||
|
persistence: Option<SessionPersistence>,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl PartialEq for Session {
|
||||||
|
fn eq(&self, other: &Self) -> bool {
|
||||||
|
self.version == other.version
|
||||||
|
&& self.session_id == other.session_id
|
||||||
|
&& self.created_at_ms == other.created_at_ms
|
||||||
|
&& self.updated_at_ms == other.updated_at_ms
|
||||||
|
&& self.messages == other.messages
|
||||||
|
&& self.compaction == other.compaction
|
||||||
|
&& self.fork == other.fork
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl Eq for Session {}
|
||||||
|
|
||||||
#[derive(Debug)]
|
#[derive(Debug)]
|
||||||
pub enum SessionError {
|
pub enum SessionError {
|
||||||
Io(std::io::Error),
|
Io(std::io::Error),
|
||||||
@@ -79,20 +125,84 @@ impl From<JsonError> for SessionError {
|
|||||||
impl Session {
|
impl Session {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn new() -> Self {
|
pub fn new() -> Self {
|
||||||
|
let now = current_time_millis();
|
||||||
Self {
|
Self {
|
||||||
version: 1,
|
version: SESSION_VERSION,
|
||||||
|
session_id: generate_session_id(),
|
||||||
|
created_at_ms: now,
|
||||||
|
updated_at_ms: now,
|
||||||
messages: Vec::new(),
|
messages: Vec::new(),
|
||||||
|
compaction: None,
|
||||||
|
fork: None,
|
||||||
|
persistence: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_persistence_path(mut self, path: impl Into<PathBuf>) -> Self {
|
||||||
|
self.persistence = Some(SessionPersistence { path: path.into() });
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn persistence_path(&self) -> Option<&Path> {
|
||||||
|
self.persistence.as_ref().map(|value| value.path.as_path())
|
||||||
|
}
|
||||||
|
|
||||||
pub fn save_to_path(&self, path: impl AsRef<Path>) -> Result<(), SessionError> {
|
pub fn save_to_path(&self, path: impl AsRef<Path>) -> Result<(), SessionError> {
|
||||||
fs::write(path, self.to_json().render())?;
|
let path = path.as_ref();
|
||||||
|
rotate_session_file_if_needed(path)?;
|
||||||
|
write_atomic(path, &self.render_jsonl_snapshot())?;
|
||||||
|
cleanup_rotated_logs(path)?;
|
||||||
Ok(())
|
Ok(())
|
||||||
}
|
}
|
||||||
|
|
||||||
pub fn load_from_path(path: impl AsRef<Path>) -> Result<Self, SessionError> {
|
pub fn load_from_path(path: impl AsRef<Path>) -> Result<Self, SessionError> {
|
||||||
|
let path = path.as_ref();
|
||||||
let contents = fs::read_to_string(path)?;
|
let contents = fs::read_to_string(path)?;
|
||||||
Self::from_json(&JsonValue::parse(&contents)?)
|
let session = match JsonValue::parse(&contents) {
|
||||||
|
Ok(value) => Self::from_json(&value)?,
|
||||||
|
Err(_) => Self::from_jsonl(&contents)?,
|
||||||
|
};
|
||||||
|
Ok(session.with_persistence_path(path.to_path_buf()))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn push_message(&mut self, message: ConversationMessage) -> Result<(), SessionError> {
|
||||||
|
self.touch();
|
||||||
|
self.messages.push(message.clone());
|
||||||
|
self.append_persisted_message(&message)
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn push_user_text(&mut self, text: impl Into<String>) -> Result<(), SessionError> {
|
||||||
|
self.push_message(ConversationMessage::user_text(text))
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn record_compaction(&mut self, summary: impl Into<String>, removed_message_count: usize) {
|
||||||
|
self.touch();
|
||||||
|
let count = self.compaction.as_ref().map_or(1, |value| value.count + 1);
|
||||||
|
self.compaction = Some(SessionCompaction {
|
||||||
|
count,
|
||||||
|
removed_message_count,
|
||||||
|
summary: summary.into(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn fork(&self, branch_name: Option<String>) -> Self {
|
||||||
|
let now = current_time_millis();
|
||||||
|
Self {
|
||||||
|
version: self.version,
|
||||||
|
session_id: generate_session_id(),
|
||||||
|
created_at_ms: now,
|
||||||
|
updated_at_ms: now,
|
||||||
|
messages: self.messages.clone(),
|
||||||
|
compaction: self.compaction.clone(),
|
||||||
|
fork: Some(SessionFork {
|
||||||
|
parent_session_id: self.session_id.clone(),
|
||||||
|
branch_name: normalize_optional_string(branch_name),
|
||||||
|
}),
|
||||||
|
persistence: None,
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
@@ -102,6 +212,18 @@ impl Session {
|
|||||||
"version".to_string(),
|
"version".to_string(),
|
||||||
JsonValue::Number(i64::from(self.version)),
|
JsonValue::Number(i64::from(self.version)),
|
||||||
);
|
);
|
||||||
|
object.insert(
|
||||||
|
"session_id".to_string(),
|
||||||
|
JsonValue::String(self.session_id.clone()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"created_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.created_at_ms, "created_at_ms")),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"updated_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.updated_at_ms, "updated_at_ms")),
|
||||||
|
);
|
||||||
object.insert(
|
object.insert(
|
||||||
"messages".to_string(),
|
"messages".to_string(),
|
||||||
JsonValue::Array(
|
JsonValue::Array(
|
||||||
@@ -111,6 +233,12 @@ impl Session {
|
|||||||
.collect(),
|
.collect(),
|
||||||
),
|
),
|
||||||
);
|
);
|
||||||
|
if let Some(compaction) = &self.compaction {
|
||||||
|
object.insert("compaction".to_string(), compaction.to_json());
|
||||||
|
}
|
||||||
|
if let Some(fork) = &self.fork {
|
||||||
|
object.insert("fork".to_string(), fork.to_json());
|
||||||
|
}
|
||||||
JsonValue::Object(object)
|
JsonValue::Object(object)
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -131,7 +259,179 @@ impl Session {
|
|||||||
.iter()
|
.iter()
|
||||||
.map(ConversationMessage::from_json)
|
.map(ConversationMessage::from_json)
|
||||||
.collect::<Result<Vec<_>, _>>()?;
|
.collect::<Result<Vec<_>, _>>()?;
|
||||||
Ok(Self { version, messages })
|
let now = current_time_millis();
|
||||||
|
let session_id = object
|
||||||
|
.get("session_id")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.map(ToOwned::to_owned)
|
||||||
|
.unwrap_or_else(generate_session_id);
|
||||||
|
let created_at_ms = object
|
||||||
|
.get("created_at_ms")
|
||||||
|
.map(|value| required_u64_from_value(value, "created_at_ms"))
|
||||||
|
.transpose()?
|
||||||
|
.unwrap_or(now);
|
||||||
|
let updated_at_ms = object
|
||||||
|
.get("updated_at_ms")
|
||||||
|
.map(|value| required_u64_from_value(value, "updated_at_ms"))
|
||||||
|
.transpose()?
|
||||||
|
.unwrap_or(created_at_ms);
|
||||||
|
let compaction = object
|
||||||
|
.get("compaction")
|
||||||
|
.map(SessionCompaction::from_json)
|
||||||
|
.transpose()?;
|
||||||
|
let fork = object.get("fork").map(SessionFork::from_json).transpose()?;
|
||||||
|
Ok(Self {
|
||||||
|
version,
|
||||||
|
session_id,
|
||||||
|
created_at_ms,
|
||||||
|
updated_at_ms,
|
||||||
|
messages,
|
||||||
|
compaction,
|
||||||
|
fork,
|
||||||
|
persistence: None,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_jsonl(contents: &str) -> Result<Self, SessionError> {
|
||||||
|
let mut version = SESSION_VERSION;
|
||||||
|
let mut session_id = None;
|
||||||
|
let mut created_at_ms = None;
|
||||||
|
let mut updated_at_ms = None;
|
||||||
|
let mut messages = Vec::new();
|
||||||
|
let mut compaction = None;
|
||||||
|
let mut fork = None;
|
||||||
|
|
||||||
|
for (line_number, raw_line) in contents.lines().enumerate() {
|
||||||
|
let line = raw_line.trim();
|
||||||
|
if line.is_empty() {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
let value = JsonValue::parse(line).map_err(|error| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"invalid JSONL record at line {}: {}",
|
||||||
|
line_number + 1,
|
||||||
|
error
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
let object = value.as_object().ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} must be an object",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
match object
|
||||||
|
.get("type")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} missing type",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})? {
|
||||||
|
"session_meta" => {
|
||||||
|
version = required_u32(object, "version")?;
|
||||||
|
session_id = Some(required_string(object, "session_id")?);
|
||||||
|
created_at_ms = Some(required_u64(object, "created_at_ms")?);
|
||||||
|
updated_at_ms = Some(required_u64(object, "updated_at_ms")?);
|
||||||
|
fork = object.get("fork").map(SessionFork::from_json).transpose()?;
|
||||||
|
}
|
||||||
|
"message" => {
|
||||||
|
let message_value = object.get("message").ok_or_else(|| {
|
||||||
|
SessionError::Format(format!(
|
||||||
|
"JSONL record at line {} missing message",
|
||||||
|
line_number + 1
|
||||||
|
))
|
||||||
|
})?;
|
||||||
|
messages.push(ConversationMessage::from_json(message_value)?);
|
||||||
|
}
|
||||||
|
"compaction" => {
|
||||||
|
compaction = Some(SessionCompaction::from_json(&JsonValue::Object(
|
||||||
|
object.clone(),
|
||||||
|
))?);
|
||||||
|
}
|
||||||
|
other => {
|
||||||
|
return Err(SessionError::Format(format!(
|
||||||
|
"unsupported JSONL record type at line {}: {other}",
|
||||||
|
line_number + 1
|
||||||
|
)))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let now = current_time_millis();
|
||||||
|
Ok(Self {
|
||||||
|
version,
|
||||||
|
session_id: session_id.unwrap_or_else(generate_session_id),
|
||||||
|
created_at_ms: created_at_ms.unwrap_or(now),
|
||||||
|
updated_at_ms: updated_at_ms.unwrap_or(created_at_ms.unwrap_or(now)),
|
||||||
|
messages,
|
||||||
|
compaction,
|
||||||
|
fork,
|
||||||
|
persistence: None,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn render_jsonl_snapshot(&self) -> String {
|
||||||
|
let mut lines = vec![self.meta_record().render()];
|
||||||
|
if let Some(compaction) = &self.compaction {
|
||||||
|
lines.push(compaction.to_jsonl_record().render());
|
||||||
|
}
|
||||||
|
lines.extend(
|
||||||
|
self.messages
|
||||||
|
.iter()
|
||||||
|
.map(|message| message_record(message).render()),
|
||||||
|
);
|
||||||
|
let mut rendered = lines.join("\n");
|
||||||
|
rendered.push('\n');
|
||||||
|
rendered
|
||||||
|
}
|
||||||
|
|
||||||
|
fn append_persisted_message(&self, message: &ConversationMessage) -> Result<(), SessionError> {
|
||||||
|
let Some(path) = self.persistence_path() else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
|
||||||
|
let needs_bootstrap = !path.exists() || fs::metadata(path)?.len() == 0;
|
||||||
|
if needs_bootstrap {
|
||||||
|
self.save_to_path(path)?;
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut file = OpenOptions::new().append(true).open(path)?;
|
||||||
|
writeln!(file, "{}", message_record(message).render())?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn meta_record(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"type".to_string(),
|
||||||
|
JsonValue::String("session_meta".to_string()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"version".to_string(),
|
||||||
|
JsonValue::Number(i64::from(self.version)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"session_id".to_string(),
|
||||||
|
JsonValue::String(self.session_id.clone()),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"created_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.created_at_ms, "created_at_ms")),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"updated_at_ms".to_string(),
|
||||||
|
JsonValue::Number(i64_from_u64(self.updated_at_ms, "updated_at_ms")),
|
||||||
|
);
|
||||||
|
if let Some(fork) = &self.fork {
|
||||||
|
object.insert("fork".to_string(), fork.to_json());
|
||||||
|
}
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn touch(&mut self) {
|
||||||
|
self.updated_at_ms = current_time_millis();
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -324,6 +624,92 @@ impl ContentBlock {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl SessionCompaction {
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_json(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"count".to_string(),
|
||||||
|
JsonValue::Number(i64::from(self.count)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"removed_message_count".to_string(),
|
||||||
|
JsonValue::Number(i64_from_usize(
|
||||||
|
self.removed_message_count,
|
||||||
|
"removed_message_count",
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
object.insert(
|
||||||
|
"summary".to_string(),
|
||||||
|
JsonValue::String(self.summary.clone()),
|
||||||
|
);
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_jsonl_record(&self) -> JsonValue {
|
||||||
|
let mut object = self
|
||||||
|
.to_json()
|
||||||
|
.as_object()
|
||||||
|
.cloned()
|
||||||
|
.expect("compaction should render to object");
|
||||||
|
object.insert(
|
||||||
|
"type".to_string(),
|
||||||
|
JsonValue::String("compaction".to_string()),
|
||||||
|
);
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_json(value: &JsonValue) -> Result<Self, SessionError> {
|
||||||
|
let object = value
|
||||||
|
.as_object()
|
||||||
|
.ok_or_else(|| SessionError::Format("compaction must be an object".to_string()))?;
|
||||||
|
Ok(Self {
|
||||||
|
count: required_u32(object, "count")?,
|
||||||
|
removed_message_count: required_usize(object, "removed_message_count")?,
|
||||||
|
summary: required_string(object, "summary")?,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl SessionFork {
|
||||||
|
#[must_use]
|
||||||
|
pub fn to_json(&self) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert(
|
||||||
|
"parent_session_id".to_string(),
|
||||||
|
JsonValue::String(self.parent_session_id.clone()),
|
||||||
|
);
|
||||||
|
if let Some(branch_name) = &self.branch_name {
|
||||||
|
object.insert(
|
||||||
|
"branch_name".to_string(),
|
||||||
|
JsonValue::String(branch_name.clone()),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn from_json(value: &JsonValue) -> Result<Self, SessionError> {
|
||||||
|
let object = value
|
||||||
|
.as_object()
|
||||||
|
.ok_or_else(|| SessionError::Format("fork metadata must be an object".to_string()))?;
|
||||||
|
Ok(Self {
|
||||||
|
parent_session_id: required_string(object, "parent_session_id")?,
|
||||||
|
branch_name: object
|
||||||
|
.get("branch_name")
|
||||||
|
.and_then(JsonValue::as_str)
|
||||||
|
.map(ToOwned::to_owned),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn message_record(message: &ConversationMessage) -> JsonValue {
|
||||||
|
let mut object = BTreeMap::new();
|
||||||
|
object.insert("type".to_string(), JsonValue::String("message".to_string()));
|
||||||
|
object.insert("message".to_string(), message.to_json());
|
||||||
|
JsonValue::Object(object)
|
||||||
|
}
|
||||||
|
|
||||||
fn usage_to_json(usage: TokenUsage) -> JsonValue {
|
fn usage_to_json(usage: TokenUsage) -> JsonValue {
|
||||||
let mut object = BTreeMap::new();
|
let mut object = BTreeMap::new();
|
||||||
object.insert(
|
object.insert(
|
||||||
@@ -376,22 +762,155 @@ fn required_u32(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<u32,
|
|||||||
u32::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
u32::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn required_u64(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<u64, SessionError> {
|
||||||
|
let value = object
|
||||||
|
.get(key)
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
required_u64_from_value(value, key)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn required_u64_from_value(value: &JsonValue, key: &str) -> Result<u64, SessionError> {
|
||||||
|
let value = value
|
||||||
|
.as_i64()
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
u64::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn required_usize(object: &BTreeMap<String, JsonValue>, key: &str) -> Result<usize, SessionError> {
|
||||||
|
let value = object
|
||||||
|
.get(key)
|
||||||
|
.and_then(JsonValue::as_i64)
|
||||||
|
.ok_or_else(|| SessionError::Format(format!("missing {key}")))?;
|
||||||
|
usize::try_from(value).map_err(|_| SessionError::Format(format!("{key} out of range")))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn i64_from_u64(value: u64, key: &str) -> i64 {
|
||||||
|
i64::try_from(value).unwrap_or_else(|_| panic!("{key} out of range for JSON number"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn i64_from_usize(value: usize, key: &str) -> i64 {
|
||||||
|
i64::try_from(value).unwrap_or_else(|_| panic!("{key} out of range for JSON number"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn normalize_optional_string(value: Option<String>) -> Option<String> {
|
||||||
|
value.and_then(|value| {
|
||||||
|
let trimmed = value.trim();
|
||||||
|
if trimmed.is_empty() {
|
||||||
|
None
|
||||||
|
} else {
|
||||||
|
Some(trimmed.to_string())
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn current_time_millis() -> u64 {
|
||||||
|
SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.map(|duration| duration.as_millis() as u64)
|
||||||
|
.unwrap_or_default()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn generate_session_id() -> String {
|
||||||
|
let millis = current_time_millis();
|
||||||
|
let counter = SESSION_ID_COUNTER.fetch_add(1, Ordering::Relaxed);
|
||||||
|
format!("session-{millis}-{counter}")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn write_atomic(path: &Path, contents: &str) -> Result<(), SessionError> {
|
||||||
|
if let Some(parent) = path.parent() {
|
||||||
|
fs::create_dir_all(parent)?;
|
||||||
|
}
|
||||||
|
let temp_path = temporary_path_for(path);
|
||||||
|
fs::write(&temp_path, contents)?;
|
||||||
|
fs::rename(temp_path, path)?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temporary_path_for(path: &Path) -> PathBuf {
|
||||||
|
let file_name = path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
path.with_file_name(format!(
|
||||||
|
"{file_name}.tmp-{}-{}",
|
||||||
|
current_time_millis(),
|
||||||
|
SESSION_ID_COUNTER.fetch_add(1, Ordering::Relaxed)
|
||||||
|
))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotate_session_file_if_needed(path: &Path) -> Result<(), SessionError> {
|
||||||
|
let Ok(metadata) = fs::metadata(path) else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
if metadata.len() < ROTATE_AFTER_BYTES {
|
||||||
|
return Ok(());
|
||||||
|
}
|
||||||
|
let rotated_path = rotated_log_path(path);
|
||||||
|
fs::rename(path, rotated_path)?;
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotated_log_path(path: &Path) -> PathBuf {
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
path.with_file_name(format!("{stem}.rot-{}.jsonl", current_time_millis()))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn cleanup_rotated_logs(path: &Path) -> Result<(), SessionError> {
|
||||||
|
let Some(parent) = path.parent() else {
|
||||||
|
return Ok(());
|
||||||
|
};
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.unwrap_or("session");
|
||||||
|
let prefix = format!("{stem}.rot-");
|
||||||
|
let mut rotated_paths = fs::read_dir(parent)?
|
||||||
|
.filter_map(Result::ok)
|
||||||
|
.map(|entry| entry.path())
|
||||||
|
.filter(|entry_path| {
|
||||||
|
entry_path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.is_some_and(|name| name.starts_with(&prefix) && name.ends_with(".jsonl"))
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
|
|
||||||
|
rotated_paths.sort_by_key(|entry_path| {
|
||||||
|
fs::metadata(entry_path)
|
||||||
|
.and_then(|metadata| metadata.modified())
|
||||||
|
.unwrap_or(UNIX_EPOCH)
|
||||||
|
});
|
||||||
|
|
||||||
|
let remove_count = rotated_paths.len().saturating_sub(MAX_ROTATED_FILES);
|
||||||
|
for stale_path in rotated_paths.into_iter().take(remove_count) {
|
||||||
|
fs::remove_file(stale_path)?;
|
||||||
|
}
|
||||||
|
Ok(())
|
||||||
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{ContentBlock, ConversationMessage, MessageRole, Session};
|
use super::{
|
||||||
|
cleanup_rotated_logs, rotate_session_file_if_needed, ContentBlock, ConversationMessage,
|
||||||
|
MessageRole, Session, SessionFork,
|
||||||
|
};
|
||||||
|
use crate::json::JsonValue;
|
||||||
use crate::usage::TokenUsage;
|
use crate::usage::TokenUsage;
|
||||||
use std::fs;
|
use std::fs;
|
||||||
|
use std::path::PathBuf;
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn persists_and_restores_session_json() {
|
fn persists_and_restores_session_jsonl() {
|
||||||
let mut session = Session::new();
|
let mut session = Session::new();
|
||||||
session
|
session
|
||||||
.messages
|
.push_user_text("hello")
|
||||||
.push(ConversationMessage::user_text("hello"));
|
.expect("user message should append");
|
||||||
session
|
session
|
||||||
.messages
|
.push_message(ConversationMessage::assistant_with_usage(
|
||||||
.push(ConversationMessage::assistant_with_usage(
|
|
||||||
vec![
|
vec![
|
||||||
ContentBlock::Text {
|
ContentBlock::Text {
|
||||||
text: "thinking".to_string(),
|
text: "thinking".to_string(),
|
||||||
@@ -408,16 +927,15 @@ mod tests {
|
|||||||
cache_creation_input_tokens: 1,
|
cache_creation_input_tokens: 1,
|
||||||
cache_read_input_tokens: 2,
|
cache_read_input_tokens: 2,
|
||||||
}),
|
}),
|
||||||
));
|
))
|
||||||
session.messages.push(ConversationMessage::tool_result(
|
.expect("assistant message should append");
|
||||||
|
session
|
||||||
|
.push_message(ConversationMessage::tool_result(
|
||||||
"tool-1", "bash", "hi", false,
|
"tool-1", "bash", "hi", false,
|
||||||
));
|
))
|
||||||
|
.expect("tool result should append");
|
||||||
|
|
||||||
let nanos = SystemTime::now()
|
let path = temp_session_path("jsonl");
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.expect("system time should be after epoch")
|
|
||||||
.as_nanos();
|
|
||||||
let path = std::env::temp_dir().join(format!("runtime-session-{nanos}.json"));
|
|
||||||
session.save_to_path(&path).expect("session should save");
|
session.save_to_path(&path).expect("session should save");
|
||||||
let restored = Session::load_from_path(&path).expect("session should load");
|
let restored = Session::load_from_path(&path).expect("session should load");
|
||||||
fs::remove_file(&path).expect("temp file should be removable");
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
@@ -428,5 +946,157 @@ mod tests {
|
|||||||
restored.messages[1].usage.expect("usage").total_tokens(),
|
restored.messages[1].usage.expect("usage").total_tokens(),
|
||||||
17
|
17
|
||||||
);
|
);
|
||||||
|
assert_eq!(restored.session_id, session.session_id);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn loads_legacy_session_json_object() {
|
||||||
|
let path = temp_session_path("legacy");
|
||||||
|
let legacy = JsonValue::Object(
|
||||||
|
[
|
||||||
|
("version".to_string(), JsonValue::Number(1)),
|
||||||
|
(
|
||||||
|
"messages".to_string(),
|
||||||
|
JsonValue::Array(vec![ConversationMessage::user_text("legacy").to_json()]),
|
||||||
|
),
|
||||||
|
]
|
||||||
|
.into_iter()
|
||||||
|
.collect(),
|
||||||
|
);
|
||||||
|
fs::write(&path, legacy.render()).expect("legacy file should write");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("legacy session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 1);
|
||||||
|
assert_eq!(
|
||||||
|
restored.messages[0],
|
||||||
|
ConversationMessage::user_text("legacy")
|
||||||
|
);
|
||||||
|
assert!(!restored.session_id.is_empty());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn appends_messages_to_persisted_jsonl_session() {
|
||||||
|
let path = temp_session_path("append");
|
||||||
|
let mut session = Session::new().with_persistence_path(path.clone());
|
||||||
|
session
|
||||||
|
.save_to_path(&path)
|
||||||
|
.expect("initial save should succeed");
|
||||||
|
session
|
||||||
|
.push_user_text("hi")
|
||||||
|
.expect("user append should succeed");
|
||||||
|
session
|
||||||
|
.push_message(ConversationMessage::assistant(vec![ContentBlock::Text {
|
||||||
|
text: "hello".to_string(),
|
||||||
|
}]))
|
||||||
|
.expect("assistant append should succeed");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("session should replay from jsonl");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_eq!(restored.messages.len(), 2);
|
||||||
|
assert_eq!(restored.messages[0], ConversationMessage::user_text("hi"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn persists_compaction_metadata() {
|
||||||
|
let path = temp_session_path("compaction");
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("before")
|
||||||
|
.expect("message should append");
|
||||||
|
session.record_compaction("summarized earlier work", 4);
|
||||||
|
session.save_to_path(&path).expect("session should save");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
let compaction = restored.compaction.expect("compaction metadata");
|
||||||
|
assert_eq!(compaction.count, 1);
|
||||||
|
assert_eq!(compaction.removed_message_count, 4);
|
||||||
|
assert!(compaction.summary.contains("summarized"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn forks_sessions_with_branch_metadata_and_persists_it() {
|
||||||
|
let path = temp_session_path("fork");
|
||||||
|
let mut session = Session::new();
|
||||||
|
session
|
||||||
|
.push_user_text("before fork")
|
||||||
|
.expect("message should append");
|
||||||
|
|
||||||
|
let forked = session
|
||||||
|
.fork(Some("investigation".to_string()))
|
||||||
|
.with_persistence_path(path.clone());
|
||||||
|
forked
|
||||||
|
.save_to_path(&path)
|
||||||
|
.expect("forked session should save");
|
||||||
|
|
||||||
|
let restored = Session::load_from_path(&path).expect("forked session should load");
|
||||||
|
fs::remove_file(&path).expect("temp file should be removable");
|
||||||
|
|
||||||
|
assert_ne!(restored.session_id, session.session_id);
|
||||||
|
assert_eq!(
|
||||||
|
restored.fork,
|
||||||
|
Some(SessionFork {
|
||||||
|
parent_session_id: session.session_id,
|
||||||
|
branch_name: Some("investigation".to_string()),
|
||||||
|
})
|
||||||
|
);
|
||||||
|
assert_eq!(restored.messages, forked.messages);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn rotates_and_cleans_up_large_session_logs() {
|
||||||
|
let path = temp_session_path("rotation");
|
||||||
|
fs::write(&path, "x".repeat((super::ROTATE_AFTER_BYTES + 10) as usize))
|
||||||
|
.expect("oversized file should write");
|
||||||
|
rotate_session_file_if_needed(&path).expect("rotation should succeed");
|
||||||
|
assert!(
|
||||||
|
!path.exists(),
|
||||||
|
"original path should be rotated away before rewrite"
|
||||||
|
);
|
||||||
|
|
||||||
|
for _ in 0..5 {
|
||||||
|
let rotated = super::rotated_log_path(&path);
|
||||||
|
fs::write(&rotated, "old").expect("rotated file should write");
|
||||||
|
}
|
||||||
|
cleanup_rotated_logs(&path).expect("cleanup should succeed");
|
||||||
|
|
||||||
|
let rotated_count = rotation_files(&path).len();
|
||||||
|
assert!(rotated_count <= super::MAX_ROTATED_FILES);
|
||||||
|
for rotated in rotation_files(&path) {
|
||||||
|
fs::remove_file(rotated).expect("rotated file should be removable");
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temp_session_path(label: &str) -> PathBuf {
|
||||||
|
let nanos = SystemTime::now()
|
||||||
|
.duration_since(UNIX_EPOCH)
|
||||||
|
.expect("system time should be after epoch")
|
||||||
|
.as_nanos();
|
||||||
|
std::env::temp_dir().join(format!("runtime-session-{label}-{nanos}.json"))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn rotation_files(path: &PathBuf) -> Vec<PathBuf> {
|
||||||
|
let stem = path
|
||||||
|
.file_stem()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.expect("temp path should have file stem")
|
||||||
|
.to_string();
|
||||||
|
fs::read_dir(path.parent().expect("temp path should have parent"))
|
||||||
|
.expect("temp dir should read")
|
||||||
|
.filter_map(Result::ok)
|
||||||
|
.map(|entry| entry.path())
|
||||||
|
.filter(|entry_path| {
|
||||||
|
entry_path
|
||||||
|
.file_name()
|
||||||
|
.and_then(|value| value.to_str())
|
||||||
|
.is_some_and(|name| {
|
||||||
|
name.starts_with(&format!("{stem}.rot-")) && name.ends_with(".jsonl")
|
||||||
|
})
|
||||||
|
})
|
||||||
|
.collect()
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -286,9 +286,8 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_from_session_messages() {
|
fn reconstructs_usage_from_session_messages() {
|
||||||
let session = Session {
|
let mut session = Session::new();
|
||||||
version: 1,
|
session.messages = vec![ConversationMessage {
|
||||||
messages: vec![ConversationMessage {
|
|
||||||
role: MessageRole::Assistant,
|
role: MessageRole::Assistant,
|
||||||
blocks: vec![ContentBlock::Text {
|
blocks: vec![ContentBlock::Text {
|
||||||
text: "done".to_string(),
|
text: "done".to_string(),
|
||||||
@@ -299,8 +298,7 @@ mod tests {
|
|||||||
cache_creation_input_tokens: 1,
|
cache_creation_input_tokens: 1,
|
||||||
cache_read_input_tokens: 0,
|
cache_read_input_tokens: 0,
|
||||||
}),
|
}),
|
||||||
}],
|
}];
|
||||||
};
|
|
||||||
|
|
||||||
let tracker = UsageTracker::from_session(&session);
|
let tracker = UsageTracker::from_session(&session);
|
||||||
assert_eq!(tracker.turns(), 1);
|
assert_eq!(tracker.turns(), 1);
|
||||||
|
|||||||
@@ -9,7 +9,7 @@ use std::io::{self, Read, Write};
|
|||||||
use std::net::TcpListener;
|
use std::net::TcpListener;
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::{Path, PathBuf};
|
||||||
use std::process::Command;
|
use std::process::Command;
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
use std::time::UNIX_EPOCH;
|
||||||
|
|
||||||
use api::{
|
use api::{
|
||||||
resolve_startup_auth_source, AnthropicClient, AuthSource, ContentBlockDelta, InputContentBlock,
|
resolve_startup_auth_source, AnthropicClient, AuthSource, ContentBlockDelta, InputContentBlock,
|
||||||
@@ -27,8 +27,8 @@ use runtime::{
|
|||||||
clear_oauth_credentials, generate_pkce_pair, generate_state, load_system_prompt,
|
clear_oauth_credentials, generate_pkce_pair, generate_state, load_system_prompt,
|
||||||
parse_oauth_callback_request_target, save_oauth_credentials, ApiClient, ApiRequest,
|
parse_oauth_callback_request_target, save_oauth_credentials, ApiClient, ApiRequest,
|
||||||
AssistantEvent, CompactionConfig, ConfigLoader, ConfigSource, ContentBlock,
|
AssistantEvent, CompactionConfig, ConfigLoader, ConfigSource, ContentBlock,
|
||||||
ConversationMessage, ConversationRuntime, MessageRole, OAuthAuthorizationRequest,
|
ConversationMessage, ConversationRuntime, MessageRole, OAuthAuthorizationRequest, OAuthConfig,
|
||||||
OAuthConfig, OAuthTokenExchangeRequest, PermissionMode, PermissionPolicy, ProjectContext, RuntimeError,
|
OAuthTokenExchangeRequest, PermissionMode, PermissionPolicy, ProjectContext, RuntimeError,
|
||||||
Session, TokenUsage, ToolError, ToolExecutor, UsageTracker,
|
Session, TokenUsage, ToolError, ToolExecutor, UsageTracker,
|
||||||
};
|
};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
@@ -47,6 +47,8 @@ const DEFAULT_OAUTH_CALLBACK_PORT: u16 = 4545;
|
|||||||
const VERSION: &str = env!("CARGO_PKG_VERSION");
|
const VERSION: &str = env!("CARGO_PKG_VERSION");
|
||||||
const BUILD_TARGET: Option<&str> = option_env!("TARGET");
|
const BUILD_TARGET: Option<&str> = option_env!("TARGET");
|
||||||
const GIT_SHA: Option<&str> = option_env!("GIT_SHA");
|
const GIT_SHA: Option<&str> = option_env!("GIT_SHA");
|
||||||
|
const PRIMARY_SESSION_EXTENSION: &str = "jsonl";
|
||||||
|
const LEGACY_SESSION_EXTENSION: &str = "json";
|
||||||
|
|
||||||
type AllowedToolSet = BTreeSet<String>;
|
type AllowedToolSet = BTreeSet<String>;
|
||||||
|
|
||||||
@@ -589,7 +591,19 @@ fn print_version() {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn resume_session(session_path: &Path, commands: &[String]) {
|
fn resume_session(session_path: &Path, commands: &[String]) {
|
||||||
let session = match Session::load_from_path(session_path) {
|
let resolved_path = if session_path.exists() {
|
||||||
|
session_path.to_path_buf()
|
||||||
|
} else {
|
||||||
|
match resolve_session_reference(&session_path.display().to_string()) {
|
||||||
|
Ok(handle) => handle.path,
|
||||||
|
Err(error) => {
|
||||||
|
eprintln!("failed to restore session: {error}");
|
||||||
|
std::process::exit(1);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
|
||||||
|
let session = match Session::load_from_path(&resolved_path) {
|
||||||
Ok(session) => session,
|
Ok(session) => session,
|
||||||
Err(error) => {
|
Err(error) => {
|
||||||
eprintln!("failed to restore session: {error}");
|
eprintln!("failed to restore session: {error}");
|
||||||
@@ -600,7 +614,7 @@ fn resume_session(session_path: &Path, commands: &[String]) {
|
|||||||
if commands.is_empty() {
|
if commands.is_empty() {
|
||||||
println!(
|
println!(
|
||||||
"Restored session from {} ({} messages).",
|
"Restored session from {} ({} messages).",
|
||||||
session_path.display(),
|
resolved_path.display(),
|
||||||
session.messages.len()
|
session.messages.len()
|
||||||
);
|
);
|
||||||
return;
|
return;
|
||||||
@@ -612,7 +626,7 @@ fn resume_session(session_path: &Path, commands: &[String]) {
|
|||||||
eprintln!("unsupported resumed command: {raw_command}");
|
eprintln!("unsupported resumed command: {raw_command}");
|
||||||
std::process::exit(2);
|
std::process::exit(2);
|
||||||
};
|
};
|
||||||
match run_resume_command(session_path, &session, &command) {
|
match run_resume_command(&resolved_path, &session, &command) {
|
||||||
Ok(ResumeCommandOutcome {
|
Ok(ResumeCommandOutcome {
|
||||||
session: next_session,
|
session: next_session,
|
||||||
message,
|
message,
|
||||||
@@ -973,6 +987,8 @@ struct ManagedSessionSummary {
|
|||||||
path: PathBuf,
|
path: PathBuf,
|
||||||
modified_epoch_secs: u64,
|
modified_epoch_secs: u64,
|
||||||
message_count: usize,
|
message_count: usize,
|
||||||
|
parent_session_id: Option<String>,
|
||||||
|
branch_name: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
struct LiveCli {
|
struct LiveCli {
|
||||||
@@ -992,9 +1008,10 @@ impl LiveCli {
|
|||||||
permission_mode: PermissionMode,
|
permission_mode: PermissionMode,
|
||||||
) -> Result<Self, Box<dyn std::error::Error>> {
|
) -> Result<Self, Box<dyn std::error::Error>> {
|
||||||
let system_prompt = build_system_prompt()?;
|
let system_prompt = build_system_prompt()?;
|
||||||
let session = create_managed_session_handle()?;
|
let session_state = Session::new();
|
||||||
|
let session = create_managed_session_handle(&session_state.session_id)?;
|
||||||
let runtime = build_runtime(
|
let runtime = build_runtime(
|
||||||
Session::new(),
|
session_state.with_persistence_path(session.path.clone()),
|
||||||
model.clone(),
|
model.clone(),
|
||||||
system_prompt.clone(),
|
system_prompt.clone(),
|
||||||
enable_tools,
|
enable_tools,
|
||||||
@@ -1297,9 +1314,10 @@ impl LiveCli {
|
|||||||
return Ok(false);
|
return Ok(false);
|
||||||
}
|
}
|
||||||
|
|
||||||
self.session = create_managed_session_handle()?;
|
let session_state = Session::new();
|
||||||
|
self.session = create_managed_session_handle(&session_state.session_id)?;
|
||||||
self.runtime = build_runtime(
|
self.runtime = build_runtime(
|
||||||
Session::new(),
|
session_state.with_persistence_path(self.session.path.clone()),
|
||||||
self.model.clone(),
|
self.model.clone(),
|
||||||
self.system_prompt.clone(),
|
self.system_prompt.clone(),
|
||||||
true,
|
true,
|
||||||
@@ -1333,6 +1351,7 @@ impl LiveCli {
|
|||||||
let handle = resolve_session_reference(&session_ref)?;
|
let handle = resolve_session_reference(&session_ref)?;
|
||||||
let session = Session::load_from_path(&handle.path)?;
|
let session = Session::load_from_path(&handle.path)?;
|
||||||
let message_count = session.messages.len();
|
let message_count = session.messages.len();
|
||||||
|
let session_id = session.session_id.clone();
|
||||||
self.runtime = build_runtime(
|
self.runtime = build_runtime(
|
||||||
session,
|
session,
|
||||||
self.model.clone(),
|
self.model.clone(),
|
||||||
@@ -1342,7 +1361,10 @@ impl LiveCli {
|
|||||||
self.allowed_tools.clone(),
|
self.allowed_tools.clone(),
|
||||||
self.permission_mode,
|
self.permission_mode,
|
||||||
)?;
|
)?;
|
||||||
self.session = handle;
|
self.session = SessionHandle {
|
||||||
|
id: session_id,
|
||||||
|
path: handle.path,
|
||||||
|
};
|
||||||
println!(
|
println!(
|
||||||
"{}",
|
"{}",
|
||||||
format_resume_report(
|
format_resume_report(
|
||||||
@@ -1405,6 +1427,7 @@ impl LiveCli {
|
|||||||
let handle = resolve_session_reference(target)?;
|
let handle = resolve_session_reference(target)?;
|
||||||
let session = Session::load_from_path(&handle.path)?;
|
let session = Session::load_from_path(&handle.path)?;
|
||||||
let message_count = session.messages.len();
|
let message_count = session.messages.len();
|
||||||
|
let session_id = session.session_id.clone();
|
||||||
self.runtime = build_runtime(
|
self.runtime = build_runtime(
|
||||||
session,
|
session,
|
||||||
self.model.clone(),
|
self.model.clone(),
|
||||||
@@ -1414,7 +1437,10 @@ impl LiveCli {
|
|||||||
self.allowed_tools.clone(),
|
self.allowed_tools.clone(),
|
||||||
self.permission_mode,
|
self.permission_mode,
|
||||||
)?;
|
)?;
|
||||||
self.session = handle;
|
self.session = SessionHandle {
|
||||||
|
id: session_id,
|
||||||
|
path: handle.path,
|
||||||
|
};
|
||||||
println!(
|
println!(
|
||||||
"Session switched\n Active session {}\n File {}\n Messages {}",
|
"Session switched\n Active session {}\n File {}\n Messages {}",
|
||||||
self.session.id,
|
self.session.id,
|
||||||
@@ -1423,8 +1449,41 @@ impl LiveCli {
|
|||||||
);
|
);
|
||||||
Ok(true)
|
Ok(true)
|
||||||
}
|
}
|
||||||
|
Some("fork") => {
|
||||||
|
let forked = self.runtime.fork_session(target.map(ToOwned::to_owned));
|
||||||
|
let parent_session_id = self.session.id.clone();
|
||||||
|
let handle = create_managed_session_handle(&forked.session_id)?;
|
||||||
|
let branch_name = forked
|
||||||
|
.fork
|
||||||
|
.as_ref()
|
||||||
|
.and_then(|fork| fork.branch_name.clone());
|
||||||
|
let forked = forked.with_persistence_path(handle.path.clone());
|
||||||
|
let message_count = forked.messages.len();
|
||||||
|
forked.save_to_path(&handle.path)?;
|
||||||
|
self.runtime = build_runtime(
|
||||||
|
forked,
|
||||||
|
self.model.clone(),
|
||||||
|
self.system_prompt.clone(),
|
||||||
|
true,
|
||||||
|
true,
|
||||||
|
self.allowed_tools.clone(),
|
||||||
|
self.permission_mode,
|
||||||
|
)?;
|
||||||
|
self.session = handle;
|
||||||
|
println!(
|
||||||
|
"Session forked\n Parent session {}\n Active session {}\n Branch {}\n File {}\n Messages {}",
|
||||||
|
parent_session_id,
|
||||||
|
self.session.id,
|
||||||
|
branch_name.as_deref().unwrap_or("(unnamed)"),
|
||||||
|
self.session.path.display(),
|
||||||
|
message_count,
|
||||||
|
);
|
||||||
|
Ok(true)
|
||||||
|
}
|
||||||
Some(other) => {
|
Some(other) => {
|
||||||
println!("Unknown /session action '{other}'. Use /session list or /session switch <session-id>.");
|
println!(
|
||||||
|
"Unknown /session action '{other}'. Use /session list, /session switch <session-id>, or /session fork [branch-name]."
|
||||||
|
);
|
||||||
Ok(false)
|
Ok(false)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -1457,44 +1516,61 @@ fn sessions_dir() -> Result<PathBuf, Box<dyn std::error::Error>> {
|
|||||||
Ok(path)
|
Ok(path)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn create_managed_session_handle() -> Result<SessionHandle, Box<dyn std::error::Error>> {
|
fn create_managed_session_handle(
|
||||||
let id = generate_session_id();
|
session_id: &str,
|
||||||
let path = sessions_dir()?.join(format!("{id}.json"));
|
) -> Result<SessionHandle, Box<dyn std::error::Error>> {
|
||||||
|
let id = session_id.to_string();
|
||||||
|
let path = sessions_dir()?.join(format!("{id}.{PRIMARY_SESSION_EXTENSION}"));
|
||||||
Ok(SessionHandle { id, path })
|
Ok(SessionHandle { id, path })
|
||||||
}
|
}
|
||||||
|
|
||||||
fn generate_session_id() -> String {
|
|
||||||
let millis = SystemTime::now()
|
|
||||||
.duration_since(UNIX_EPOCH)
|
|
||||||
.map(|duration| duration.as_millis())
|
|
||||||
.unwrap_or_default();
|
|
||||||
format!("session-{millis}")
|
|
||||||
}
|
|
||||||
|
|
||||||
fn resolve_session_reference(reference: &str) -> Result<SessionHandle, Box<dyn std::error::Error>> {
|
fn resolve_session_reference(reference: &str) -> Result<SessionHandle, Box<dyn std::error::Error>> {
|
||||||
let direct = PathBuf::from(reference);
|
let direct = PathBuf::from(reference);
|
||||||
|
let looks_like_path = direct.extension().is_some() || direct.components().count() > 1;
|
||||||
let path = if direct.exists() {
|
let path = if direct.exists() {
|
||||||
direct
|
direct
|
||||||
} else {
|
} else if looks_like_path {
|
||||||
sessions_dir()?.join(format!("{reference}.json"))
|
|
||||||
};
|
|
||||||
if !path.exists() {
|
|
||||||
return Err(format!("session not found: {reference}").into());
|
return Err(format!("session not found: {reference}").into());
|
||||||
}
|
} else {
|
||||||
|
resolve_managed_session_path(reference)?
|
||||||
|
};
|
||||||
let id = path
|
let id = path
|
||||||
.file_stem()
|
.file_name()
|
||||||
.and_then(|value| value.to_str())
|
.and_then(|value| value.to_str())
|
||||||
|
.and_then(|name| {
|
||||||
|
name.strip_suffix(&format!(".{PRIMARY_SESSION_EXTENSION}"))
|
||||||
|
.or_else(|| name.strip_suffix(&format!(".{LEGACY_SESSION_EXTENSION}")))
|
||||||
|
})
|
||||||
.unwrap_or(reference)
|
.unwrap_or(reference)
|
||||||
.to_string();
|
.to_string();
|
||||||
Ok(SessionHandle { id, path })
|
Ok(SessionHandle { id, path })
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn resolve_managed_session_path(session_id: &str) -> Result<PathBuf, Box<dyn std::error::Error>> {
|
||||||
|
let directory = sessions_dir()?;
|
||||||
|
for extension in [PRIMARY_SESSION_EXTENSION, LEGACY_SESSION_EXTENSION] {
|
||||||
|
let path = directory.join(format!("{session_id}.{extension}"));
|
||||||
|
if path.exists() {
|
||||||
|
return Ok(path);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Err(format!("session not found: {session_id}").into())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn is_managed_session_file(path: &Path) -> bool {
|
||||||
|
path.extension()
|
||||||
|
.and_then(|ext| ext.to_str())
|
||||||
|
.is_some_and(|extension| {
|
||||||
|
extension == PRIMARY_SESSION_EXTENSION || extension == LEGACY_SESSION_EXTENSION
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
fn list_managed_sessions() -> Result<Vec<ManagedSessionSummary>, Box<dyn std::error::Error>> {
|
fn list_managed_sessions() -> Result<Vec<ManagedSessionSummary>, Box<dyn std::error::Error>> {
|
||||||
let mut sessions = Vec::new();
|
let mut sessions = Vec::new();
|
||||||
for entry in fs::read_dir(sessions_dir()?)? {
|
for entry in fs::read_dir(sessions_dir()?)? {
|
||||||
let entry = entry?;
|
let entry = entry?;
|
||||||
let path = entry.path();
|
let path = entry.path();
|
||||||
if path.extension().and_then(|ext| ext.to_str()) != Some("json") {
|
if !is_managed_session_file(&path) {
|
||||||
continue;
|
continue;
|
||||||
}
|
}
|
||||||
let metadata = entry.metadata()?;
|
let metadata = entry.metadata()?;
|
||||||
@@ -1504,19 +1580,41 @@ fn list_managed_sessions() -> Result<Vec<ManagedSessionSummary>, Box<dyn std::er
|
|||||||
.and_then(|time| time.duration_since(UNIX_EPOCH).ok())
|
.and_then(|time| time.duration_since(UNIX_EPOCH).ok())
|
||||||
.map(|duration| duration.as_secs())
|
.map(|duration| duration.as_secs())
|
||||||
.unwrap_or_default();
|
.unwrap_or_default();
|
||||||
let message_count = Session::load_from_path(&path)
|
let (id, message_count, parent_session_id, branch_name) = Session::load_from_path(&path)
|
||||||
.map(|session| session.messages.len())
|
.map(|session| {
|
||||||
.unwrap_or_default();
|
let parent_session_id = session
|
||||||
let id = path
|
.fork
|
||||||
.file_stem()
|
.as_ref()
|
||||||
|
.map(|fork| fork.parent_session_id.clone());
|
||||||
|
let branch_name = session
|
||||||
|
.fork
|
||||||
|
.as_ref()
|
||||||
|
.and_then(|fork| fork.branch_name.clone());
|
||||||
|
(
|
||||||
|
session.session_id,
|
||||||
|
session.messages.len(),
|
||||||
|
parent_session_id,
|
||||||
|
branch_name,
|
||||||
|
)
|
||||||
|
})
|
||||||
|
.unwrap_or_else(|_| {
|
||||||
|
(
|
||||||
|
path.file_stem()
|
||||||
.and_then(|value| value.to_str())
|
.and_then(|value| value.to_str())
|
||||||
.unwrap_or("unknown")
|
.unwrap_or("unknown")
|
||||||
.to_string();
|
.to_string(),
|
||||||
|
0,
|
||||||
|
None,
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
});
|
||||||
sessions.push(ManagedSessionSummary {
|
sessions.push(ManagedSessionSummary {
|
||||||
id,
|
id,
|
||||||
path,
|
path,
|
||||||
modified_epoch_secs,
|
modified_epoch_secs,
|
||||||
message_count,
|
message_count,
|
||||||
|
parent_session_id,
|
||||||
|
branch_name,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
sessions.sort_by(|left, right| right.modified_epoch_secs.cmp(&left.modified_epoch_secs));
|
sessions.sort_by(|left, right| right.modified_epoch_secs.cmp(&left.modified_epoch_secs));
|
||||||
@@ -1539,11 +1637,23 @@ fn render_session_list(active_session_id: &str) -> Result<String, Box<dyn std::e
|
|||||||
} else {
|
} else {
|
||||||
"○ saved"
|
"○ saved"
|
||||||
};
|
};
|
||||||
|
let lineage = match (
|
||||||
|
session.branch_name.as_deref(),
|
||||||
|
session.parent_session_id.as_deref(),
|
||||||
|
) {
|
||||||
|
(Some(branch_name), Some(parent_session_id)) => {
|
||||||
|
format!(" branch={branch_name} from={parent_session_id}")
|
||||||
|
}
|
||||||
|
(None, Some(parent_session_id)) => format!(" from={parent_session_id}"),
|
||||||
|
(Some(branch_name), None) => format!(" branch={branch_name}"),
|
||||||
|
(None, None) => String::new(),
|
||||||
|
};
|
||||||
lines.push(format!(
|
lines.push(format!(
|
||||||
" {id:<20} {marker:<10} msgs={msgs:<4} modified={modified} path={path}",
|
" {id:<20} {marker:<10} msgs={msgs:<4} modified={modified}{lineage} path={path}",
|
||||||
id = session.id,
|
id = session.id,
|
||||||
msgs = session.message_count,
|
msgs = session.message_count,
|
||||||
modified = session.modified_epoch_secs,
|
modified = session.modified_epoch_secs,
|
||||||
|
lineage = lineage,
|
||||||
path = session.path.display(),
|
path = session.path.display(),
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
@@ -1903,6 +2013,15 @@ fn build_system_prompt() -> Result<Vec<String>, Box<dyn std::error::Error>> {
|
|||||||
)?)
|
)?)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn build_runtime_feature_config(
|
||||||
|
) -> Result<runtime::RuntimeFeatureConfig, Box<dyn std::error::Error>> {
|
||||||
|
let cwd = env::current_dir()?;
|
||||||
|
Ok(ConfigLoader::default_for(cwd)
|
||||||
|
.load()?
|
||||||
|
.feature_config()
|
||||||
|
.clone())
|
||||||
|
}
|
||||||
|
|
||||||
fn build_runtime(
|
fn build_runtime(
|
||||||
session: Session,
|
session: Session,
|
||||||
model: String,
|
model: String,
|
||||||
@@ -1913,12 +2032,13 @@ fn build_runtime(
|
|||||||
permission_mode: PermissionMode,
|
permission_mode: PermissionMode,
|
||||||
) -> Result<ConversationRuntime<AnthropicRuntimeClient, CliToolExecutor>, Box<dyn std::error::Error>>
|
) -> Result<ConversationRuntime<AnthropicRuntimeClient, CliToolExecutor>, Box<dyn std::error::Error>>
|
||||||
{
|
{
|
||||||
Ok(ConversationRuntime::new(
|
Ok(ConversationRuntime::new_with_features(
|
||||||
session,
|
session,
|
||||||
AnthropicRuntimeClient::new(model, enable_tools, emit_output, allowed_tools.clone())?,
|
AnthropicRuntimeClient::new(model, enable_tools, emit_output, allowed_tools.clone())?,
|
||||||
CliToolExecutor::new(allowed_tools, emit_output),
|
CliToolExecutor::new(allowed_tools, emit_output),
|
||||||
permission_policy(permission_mode),
|
permission_policy(permission_mode),
|
||||||
system_prompt,
|
system_prompt,
|
||||||
|
build_runtime_feature_config()?,
|
||||||
))
|
))
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -2737,7 +2857,7 @@ fn print_help_to(out: &mut impl Write) -> io::Result<()> {
|
|||||||
writeln!(out, " Shorthand non-interactive prompt mode")?;
|
writeln!(out, " Shorthand non-interactive prompt mode")?;
|
||||||
writeln!(
|
writeln!(
|
||||||
out,
|
out,
|
||||||
" claw --resume SESSION.json [/status] [/compact] [...]"
|
" claw --resume SESSION.jsonl [/status] [/compact] [...]"
|
||||||
)?;
|
)?;
|
||||||
writeln!(
|
writeln!(
|
||||||
out,
|
out,
|
||||||
@@ -2797,7 +2917,7 @@ fn print_help_to(out: &mut impl Write) -> io::Result<()> {
|
|||||||
)?;
|
)?;
|
||||||
writeln!(
|
writeln!(
|
||||||
out,
|
out,
|
||||||
" claw --resume session.json /status /diff /export notes.txt"
|
" claw --resume session.jsonl /status /diff /export notes.txt"
|
||||||
)?;
|
)?;
|
||||||
writeln!(out, " claw login")?;
|
writeln!(out, " claw login")?;
|
||||||
writeln!(out, " claw init")?;
|
writeln!(out, " claw init")?;
|
||||||
@@ -2811,18 +2931,23 @@ fn print_help() {
|
|||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
filter_tool_specs, format_compact_report, format_cost_report, format_model_report,
|
create_managed_session_handle, filter_tool_specs, format_compact_report,
|
||||||
format_model_switch_report, format_permissions_report, format_permissions_switch_report,
|
format_cost_report, format_model_report, format_model_switch_report,
|
||||||
format_resume_report, format_status_report, format_tool_call_start, format_tool_result,
|
format_permissions_report, format_permissions_switch_report, format_resume_report,
|
||||||
|
format_status_report, format_tool_call_start, format_tool_result,
|
||||||
normalize_permission_mode, parse_args, parse_git_status_metadata, print_help_to,
|
normalize_permission_mode, parse_args, parse_git_status_metadata, print_help_to,
|
||||||
push_output_block, render_config_report, render_memory_report, render_repl_help,
|
push_output_block, render_config_report, render_memory_report, render_repl_help,
|
||||||
resolve_model_alias, response_to_events, resume_supported_slash_commands, status_context,
|
resolve_model_alias, resolve_session_reference, response_to_events,
|
||||||
CliAction, CliOutputFormat, SlashCommand, StatusUsage, DEFAULT_MODEL,
|
resume_supported_slash_commands, status_context, CliAction, CliOutputFormat, SlashCommand,
|
||||||
|
StatusUsage, DEFAULT_MODEL,
|
||||||
};
|
};
|
||||||
use api::{MessageResponse, OutputContentBlock, Usage};
|
use api::{MessageResponse, OutputContentBlock, Usage};
|
||||||
use runtime::{AssistantEvent, ContentBlock, ConversationMessage, MessageRole, PermissionMode};
|
use runtime::{
|
||||||
|
AssistantEvent, ContentBlock, ConversationMessage, MessageRole, PermissionMode, Session,
|
||||||
|
};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
|
use std::sync::{Mutex, OnceLock};
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn defaults_to_repl_when_no_args() {
|
fn defaults_to_repl_when_no_args() {
|
||||||
@@ -2996,13 +3121,13 @@ mod tests {
|
|||||||
fn parses_resume_flag_with_slash_command() {
|
fn parses_resume_flag_with_slash_command() {
|
||||||
let args = vec![
|
let args = vec![
|
||||||
"--resume".to_string(),
|
"--resume".to_string(),
|
||||||
"session.json".to_string(),
|
"session.jsonl".to_string(),
|
||||||
"/compact".to_string(),
|
"/compact".to_string(),
|
||||||
];
|
];
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
parse_args(&args).expect("args should parse"),
|
parse_args(&args).expect("args should parse"),
|
||||||
CliAction::ResumeSession {
|
CliAction::ResumeSession {
|
||||||
session_path: PathBuf::from("session.json"),
|
session_path: PathBuf::from("session.jsonl"),
|
||||||
commands: vec!["/compact".to_string()],
|
commands: vec!["/compact".to_string()],
|
||||||
}
|
}
|
||||||
);
|
);
|
||||||
@@ -3012,7 +3137,7 @@ mod tests {
|
|||||||
fn parses_resume_flag_with_multiple_slash_commands() {
|
fn parses_resume_flag_with_multiple_slash_commands() {
|
||||||
let args = vec![
|
let args = vec![
|
||||||
"--resume".to_string(),
|
"--resume".to_string(),
|
||||||
"session.json".to_string(),
|
"session.jsonl".to_string(),
|
||||||
"/status".to_string(),
|
"/status".to_string(),
|
||||||
"/compact".to_string(),
|
"/compact".to_string(),
|
||||||
"/cost".to_string(),
|
"/cost".to_string(),
|
||||||
@@ -3020,7 +3145,7 @@ mod tests {
|
|||||||
assert_eq!(
|
assert_eq!(
|
||||||
parse_args(&args).expect("args should parse"),
|
parse_args(&args).expect("args should parse"),
|
||||||
CliAction::ResumeSession {
|
CliAction::ResumeSession {
|
||||||
session_path: PathBuf::from("session.json"),
|
session_path: PathBuf::from("session.jsonl"),
|
||||||
commands: vec![
|
commands: vec![
|
||||||
"/status".to_string(),
|
"/status".to_string(),
|
||||||
"/compact".to_string(),
|
"/compact".to_string(),
|
||||||
@@ -3048,7 +3173,7 @@ mod tests {
|
|||||||
fn shared_help_uses_resume_annotation_copy() {
|
fn shared_help_uses_resume_annotation_copy() {
|
||||||
let help = commands::render_slash_command_help();
|
let help = commands::render_slash_command_help();
|
||||||
assert!(help.contains("Slash commands"));
|
assert!(help.contains("Slash commands"));
|
||||||
assert!(help.contains("works with --resume SESSION.json"));
|
assert!(help.contains("works with --resume SESSION.jsonl"));
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
@@ -3068,7 +3193,7 @@ mod tests {
|
|||||||
assert!(help.contains("/diff"));
|
assert!(help.contains("/diff"));
|
||||||
assert!(help.contains("/version"));
|
assert!(help.contains("/version"));
|
||||||
assert!(help.contains("/export [file]"));
|
assert!(help.contains("/export [file]"));
|
||||||
assert!(help.contains("/session [list|switch <session-id>]"));
|
assert!(help.contains("/session [list|switch <session-id>|fork [branch-name]]"));
|
||||||
assert!(help.contains("/exit"));
|
assert!(help.contains("/exit"));
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -3089,9 +3214,9 @@ mod tests {
|
|||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn resume_report_uses_sectioned_layout() {
|
fn resume_report_uses_sectioned_layout() {
|
||||||
let report = format_resume_report("session.json", 14, 6);
|
let report = format_resume_report("session.jsonl", 14, 6);
|
||||||
assert!(report.contains("Session resumed"));
|
assert!(report.contains("Session resumed"));
|
||||||
assert!(report.contains("Session file session.json"));
|
assert!(report.contains("Session file session.jsonl"));
|
||||||
assert!(report.contains("Messages 14"));
|
assert!(report.contains("Messages 14"));
|
||||||
assert!(report.contains("Turns 6"));
|
assert!(report.contains("Turns 6"));
|
||||||
}
|
}
|
||||||
@@ -3193,7 +3318,7 @@ mod tests {
|
|||||||
"workspace-write",
|
"workspace-write",
|
||||||
&super::StatusContext {
|
&super::StatusContext {
|
||||||
cwd: PathBuf::from("/tmp/project"),
|
cwd: PathBuf::from("/tmp/project"),
|
||||||
session_path: Some(PathBuf::from("session.json")),
|
session_path: Some(PathBuf::from("session.jsonl")),
|
||||||
loaded_config_files: 2,
|
loaded_config_files: 2,
|
||||||
discovered_config_files: 3,
|
discovered_config_files: 3,
|
||||||
memory_file_count: 4,
|
memory_file_count: 4,
|
||||||
@@ -3210,7 +3335,7 @@ mod tests {
|
|||||||
assert!(status.contains("Cwd /tmp/project"));
|
assert!(status.contains("Cwd /tmp/project"));
|
||||||
assert!(status.contains("Project root /tmp"));
|
assert!(status.contains("Project root /tmp"));
|
||||||
assert!(status.contains("Git branch main"));
|
assert!(status.contains("Git branch main"));
|
||||||
assert!(status.contains("Session session.json"));
|
assert!(status.contains("Session session.jsonl"));
|
||||||
assert!(status.contains("Config files loaded 2/3"));
|
assert!(status.contains("Config files loaded 2/3"));
|
||||||
assert!(status.contains("Memory files 4"));
|
assert!(status.contains("Memory files 4"));
|
||||||
}
|
}
|
||||||
@@ -3285,9 +3410,9 @@ mod tests {
|
|||||||
#[test]
|
#[test]
|
||||||
fn parses_resume_and_config_slash_commands() {
|
fn parses_resume_and_config_slash_commands() {
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
SlashCommand::parse("/resume saved-session.json"),
|
SlashCommand::parse("/resume saved-session.jsonl"),
|
||||||
Some(SlashCommand::Resume {
|
Some(SlashCommand::Resume {
|
||||||
session_path: Some("saved-session.json".to_string())
|
session_path: Some("saved-session.jsonl".to_string())
|
||||||
})
|
})
|
||||||
);
|
);
|
||||||
assert_eq!(
|
assert_eq!(
|
||||||
@@ -3306,6 +3431,65 @@ mod tests {
|
|||||||
);
|
);
|
||||||
assert_eq!(SlashCommand::parse("/memory"), Some(SlashCommand::Memory));
|
assert_eq!(SlashCommand::parse("/memory"), Some(SlashCommand::Memory));
|
||||||
assert_eq!(SlashCommand::parse("/init"), Some(SlashCommand::Init));
|
assert_eq!(SlashCommand::parse("/init"), Some(SlashCommand::Init));
|
||||||
|
assert_eq!(
|
||||||
|
SlashCommand::parse("/session fork incident-review"),
|
||||||
|
Some(SlashCommand::Session {
|
||||||
|
action: Some("fork".to_string()),
|
||||||
|
target: Some("incident-review".to_string())
|
||||||
|
})
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn help_mentions_jsonl_resume_examples() {
|
||||||
|
let mut help = Vec::new();
|
||||||
|
print_help_to(&mut help).expect("help should render");
|
||||||
|
let help = String::from_utf8(help).expect("help should be utf8");
|
||||||
|
assert!(help.contains("claw --resume SESSION.jsonl"));
|
||||||
|
assert!(help.contains("claw --resume session.jsonl /status /diff /export notes.txt"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn managed_sessions_default_to_jsonl_and_resolve_legacy_json() {
|
||||||
|
let _guard = cwd_lock().lock().expect("cwd lock");
|
||||||
|
let workspace = temp_workspace("session-resolution");
|
||||||
|
std::fs::create_dir_all(&workspace).expect("workspace should create");
|
||||||
|
let previous = std::env::current_dir().expect("cwd");
|
||||||
|
std::env::set_current_dir(&workspace).expect("switch cwd");
|
||||||
|
|
||||||
|
let handle = create_managed_session_handle("session-alpha").expect("jsonl handle");
|
||||||
|
assert!(handle.path.ends_with("session-alpha.jsonl"));
|
||||||
|
|
||||||
|
let legacy_path = workspace.join(".claude/sessions/legacy.json");
|
||||||
|
std::fs::create_dir_all(
|
||||||
|
legacy_path
|
||||||
|
.parent()
|
||||||
|
.expect("legacy path should have parent directory"),
|
||||||
|
)
|
||||||
|
.expect("session dir should exist");
|
||||||
|
Session::new()
|
||||||
|
.with_persistence_path(legacy_path.clone())
|
||||||
|
.save_to_path(&legacy_path)
|
||||||
|
.expect("legacy session should save");
|
||||||
|
|
||||||
|
let resolved = resolve_session_reference("legacy").expect("legacy session should resolve");
|
||||||
|
assert_eq!(resolved.path, legacy_path);
|
||||||
|
|
||||||
|
std::env::set_current_dir(previous).expect("restore cwd");
|
||||||
|
std::fs::remove_dir_all(workspace).expect("workspace should clean up");
|
||||||
|
}
|
||||||
|
|
||||||
|
fn cwd_lock() -> &'static Mutex<()> {
|
||||||
|
static LOCK: OnceLock<Mutex<()>> = OnceLock::new();
|
||||||
|
LOCK.get_or_init(|| Mutex::new(()))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn temp_workspace(label: &str) -> PathBuf {
|
||||||
|
let nanos = std::time::SystemTime::now()
|
||||||
|
.duration_since(std::time::UNIX_EPOCH)
|
||||||
|
.expect("system time should be after epoch")
|
||||||
|
.as_nanos();
|
||||||
|
std::env::temp_dir().join(format!("claw-cli-{label}-{nanos}"))
|
||||||
}
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
|
|||||||
Reference in New Issue
Block a user