Compare commits
13 Commits
rcc/ui-pol
...
rcc/hook-p
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c38eac7a90 | ||
|
|
197065bfc8 | ||
|
|
555a245456 | ||
|
|
9efd029e26 | ||
|
|
eb89fc95e7 | ||
|
|
94199beabb | ||
|
|
ac6c5d00a8 | ||
|
|
a94ef61b01 | ||
|
|
a9ac7e5bb8 | ||
|
|
0175ee0a90 | ||
|
|
1bd0eef368 | ||
|
|
ba220d210e | ||
|
|
04b1f1e85d |
5
.claude.json
Normal file
5
.claude.json
Normal file
@@ -0,0 +1,5 @@
|
|||||||
|
{
|
||||||
|
"permissions": {
|
||||||
|
"defaultMode": "dontAsk"
|
||||||
|
}
|
||||||
|
}
|
||||||
3
.gitignore
vendored
3
.gitignore
vendored
@@ -2,3 +2,6 @@ __pycache__/
|
|||||||
archive/
|
archive/
|
||||||
.omx/
|
.omx/
|
||||||
.clawd-agents/
|
.clawd-agents/
|
||||||
|
# Claude Code local artifacts
|
||||||
|
.claude/settings.local.json
|
||||||
|
.claude/sessions/
|
||||||
|
|||||||
21
CLAUDE.md
Normal file
21
CLAUDE.md
Normal file
@@ -0,0 +1,21 @@
|
|||||||
|
# CLAUDE.md
|
||||||
|
|
||||||
|
This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
|
||||||
|
|
||||||
|
## Detected stack
|
||||||
|
- Languages: Rust.
|
||||||
|
- Frameworks: none detected from the supported starter markers.
|
||||||
|
|
||||||
|
## Verification
|
||||||
|
- Run Rust verification from `rust/`: `cargo fmt`, `cargo clippy --workspace --all-targets -- -D warnings`, `cargo test --workspace`
|
||||||
|
- `src/` and `tests/` are both present; update both surfaces together when behavior changes.
|
||||||
|
|
||||||
|
## Repository shape
|
||||||
|
- `rust/` contains the Rust workspace and active CLI/runtime implementation.
|
||||||
|
- `src/` contains source files that should stay consistent with generated guidance and tests.
|
||||||
|
- `tests/` contains validation surfaces that should be reviewed alongside code changes.
|
||||||
|
|
||||||
|
## Working agreement
|
||||||
|
- Prefer small, reviewable changes and keep generated bootstrap files aligned with actual repo workflows.
|
||||||
|
- Keep shared defaults in `.claude.json`; reserve `.claude/settings.local.json` for machine-local overrides.
|
||||||
|
- Do not overwrite existing `CLAUDE.md` content automatically; update it intentionally when repo workflows change.
|
||||||
1
rust/.claude/sessions/session-1775012674485.json
Normal file
1
rust/.claude/sessions/session-1775012674485.json
Normal file
@@ -0,0 +1 @@
|
|||||||
|
{"messages":[{"blocks":[{"text":"clear","type":"text"}],"role":"user"},{"blocks":[{"text":"\n\nI've cleared the conversation. How can I help you today?","type":"text"}],"role":"assistant","usage":{"cache_creation_input_tokens":0,"cache_read_input_tokens":0,"input_tokens":4272,"output_tokens":17}}],"version":1}
|
||||||
1
rust/.claude/sessions/session-1775012687059.json
Normal file
1
rust/.claude/sessions/session-1775012687059.json
Normal file
@@ -0,0 +1 @@
|
|||||||
|
{"messages":[{"blocks":[{"text":"exit","type":"text"}],"role":"user"},{"blocks":[{"text":"\n\nGoodbye! 👋","type":"text"}],"role":"assistant","usage":{"cache_creation_input_tokens":0,"cache_read_input_tokens":0,"input_tokens":4272,"output_tokens":10}}],"version":1}
|
||||||
1
rust/.claude/sessions/session-1775013221875.json
Normal file
1
rust/.claude/sessions/session-1775013221875.json
Normal file
@@ -0,0 +1 @@
|
|||||||
|
{"messages":[],"version":1}
|
||||||
@@ -1,22 +1,27 @@
|
|||||||
[
|
[
|
||||||
{
|
{
|
||||||
"content": "Phase 0: Structural Cleanup — spawn 4 agents for 0.1-0.4",
|
"content": "Architecture & dependency analysis",
|
||||||
"activeForm": "Executing Phase 0: Structural Cleanup via sub-agents",
|
"activeForm": "Complete",
|
||||||
|
"status": "completed"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"content": "Runtime crate deep analysis",
|
||||||
|
"activeForm": "Complete",
|
||||||
|
"status": "completed"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"content": "CLI & Tools analysis",
|
||||||
|
"activeForm": "Complete",
|
||||||
|
"status": "completed"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"content": "Code quality verification",
|
||||||
|
"activeForm": "Complete",
|
||||||
|
"status": "completed"
|
||||||
|
},
|
||||||
|
{
|
||||||
|
"content": "Synthesize findings into unified report",
|
||||||
|
"activeForm": "Writing report",
|
||||||
"status": "in_progress"
|
"status": "in_progress"
|
||||||
},
|
|
||||||
{
|
|
||||||
"content": "Phase 1.1-1.2: Status bar with live HUD and token counter",
|
|
||||||
"activeForm": "Awaiting Phase 0",
|
|
||||||
"status": "pending"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"content": "Phase 2.4: Remove artificial 8ms stream delay",
|
|
||||||
"activeForm": "Awaiting Phase 0",
|
|
||||||
"status": "pending"
|
|
||||||
},
|
|
||||||
{
|
|
||||||
"content": "Phase 3.1: Collapsible tool output",
|
|
||||||
"activeForm": "Awaiting Phase 0",
|
|
||||||
"status": "pending"
|
|
||||||
}
|
}
|
||||||
]
|
]
|
||||||
2
rust/Cargo.lock
generated
2
rust/Cargo.lock
generated
@@ -1545,10 +1545,12 @@ dependencies = [
|
|||||||
name = "tools"
|
name = "tools"
|
||||||
version = "0.1.0"
|
version = "0.1.0"
|
||||||
dependencies = [
|
dependencies = [
|
||||||
|
"api",
|
||||||
"reqwest",
|
"reqwest",
|
||||||
"runtime",
|
"runtime",
|
||||||
"serde",
|
"serde",
|
||||||
"serde_json",
|
"serde_json",
|
||||||
|
"tokio",
|
||||||
]
|
]
|
||||||
|
|
||||||
[[package]]
|
[[package]]
|
||||||
|
|||||||
353
rust/README.md
353
rust/README.md
@@ -1,230 +1,149 @@
|
|||||||
# Rusty Claude CLI
|
# 🦞 Claw Code — Rust Implementation
|
||||||
|
|
||||||
`rust/` contains the Rust workspace for the integrated `rusty-claude-cli` deliverable.
|
A high-performance Rust rewrite of the Claude Code CLI agent harness. Built for speed, safety, and native tool execution.
|
||||||
It is intended to be something you can clone, build, and run directly.
|
|
||||||
|
|
||||||
## Workspace layout
|
## Quick Start
|
||||||
|
|
||||||
```text
|
```bash
|
||||||
|
# Build
|
||||||
|
cd rust/
|
||||||
|
cargo build --release
|
||||||
|
|
||||||
|
# Run interactive REPL
|
||||||
|
./target/release/claw
|
||||||
|
|
||||||
|
# One-shot prompt
|
||||||
|
./target/release/claw prompt "explain this codebase"
|
||||||
|
|
||||||
|
# With specific model
|
||||||
|
./target/release/claw --model sonnet prompt "fix the bug in main.rs"
|
||||||
|
```
|
||||||
|
|
||||||
|
## Configuration
|
||||||
|
|
||||||
|
Set your API credentials:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
export ANTHROPIC_API_KEY="sk-ant-..."
|
||||||
|
# Or use a proxy
|
||||||
|
export ANTHROPIC_BASE_URL="https://your-proxy.com"
|
||||||
|
```
|
||||||
|
|
||||||
|
Or authenticate via OAuth:
|
||||||
|
|
||||||
|
```bash
|
||||||
|
claw login
|
||||||
|
```
|
||||||
|
|
||||||
|
## Features
|
||||||
|
|
||||||
|
| Feature | Status |
|
||||||
|
|---------|--------|
|
||||||
|
| Anthropic API + streaming | ✅ |
|
||||||
|
| OAuth login/logout | ✅ |
|
||||||
|
| Interactive REPL (rustyline) | ✅ |
|
||||||
|
| Tool system (bash, read, write, edit, grep, glob) | ✅ |
|
||||||
|
| Web tools (search, fetch) | ✅ |
|
||||||
|
| Sub-agent orchestration | ✅ |
|
||||||
|
| Todo tracking | ✅ |
|
||||||
|
| Notebook editing | ✅ |
|
||||||
|
| CLAUDE.md / project memory | ✅ |
|
||||||
|
| Config file hierarchy (.claude.json) | ✅ |
|
||||||
|
| Permission system | ✅ |
|
||||||
|
| MCP server lifecycle | ✅ |
|
||||||
|
| Session persistence + resume | ✅ |
|
||||||
|
| Extended thinking (thinking blocks) | ✅ |
|
||||||
|
| Cost tracking + usage display | ✅ |
|
||||||
|
| Git integration | ✅ |
|
||||||
|
| Markdown terminal rendering (ANSI) | ✅ |
|
||||||
|
| Model aliases (opus/sonnet/haiku) | ✅ |
|
||||||
|
| Slash commands (/status, /compact, /clear, etc.) | ✅ |
|
||||||
|
| Hooks (PreToolUse/PostToolUse) | 🔧 Config only |
|
||||||
|
| Plugin system | 📋 Planned |
|
||||||
|
| Skills registry | 📋 Planned |
|
||||||
|
|
||||||
|
## Model Aliases
|
||||||
|
|
||||||
|
Short names resolve to the latest model versions:
|
||||||
|
|
||||||
|
| Alias | Resolves To |
|
||||||
|
|-------|------------|
|
||||||
|
| `opus` | `claude-opus-4-6` |
|
||||||
|
| `sonnet` | `claude-sonnet-4-6` |
|
||||||
|
| `haiku` | `claude-haiku-4-5-20251213` |
|
||||||
|
|
||||||
|
## CLI Flags
|
||||||
|
|
||||||
|
```
|
||||||
|
claw [OPTIONS] [COMMAND]
|
||||||
|
|
||||||
|
Options:
|
||||||
|
--model MODEL Set the model (alias or full name)
|
||||||
|
--dangerously-skip-permissions Skip all permission checks
|
||||||
|
--permission-mode MODE Set read-only, workspace-write, or danger-full-access
|
||||||
|
--allowedTools TOOLS Restrict enabled tools
|
||||||
|
--output-format FORMAT Output format (text or json)
|
||||||
|
--version, -V Print version info
|
||||||
|
|
||||||
|
Commands:
|
||||||
|
prompt <text> One-shot prompt (non-interactive)
|
||||||
|
login Authenticate via OAuth
|
||||||
|
logout Clear stored credentials
|
||||||
|
init Initialize project config
|
||||||
|
doctor Check environment health
|
||||||
|
self-update Update to latest version
|
||||||
|
```
|
||||||
|
|
||||||
|
## Slash Commands (REPL)
|
||||||
|
|
||||||
|
| Command | Description |
|
||||||
|
|---------|-------------|
|
||||||
|
| `/help` | Show help |
|
||||||
|
| `/status` | Show session status (model, tokens, cost) |
|
||||||
|
| `/cost` | Show cost breakdown |
|
||||||
|
| `/compact` | Compact conversation history |
|
||||||
|
| `/clear` | Clear conversation |
|
||||||
|
| `/model [name]` | Show or switch model |
|
||||||
|
| `/permissions` | Show or switch permission mode |
|
||||||
|
| `/config [section]` | Show config (env, hooks, model) |
|
||||||
|
| `/memory` | Show CLAUDE.md contents |
|
||||||
|
| `/diff` | Show git diff |
|
||||||
|
| `/export [path]` | Export conversation |
|
||||||
|
| `/session [id]` | Resume a previous session |
|
||||||
|
| `/version` | Show version |
|
||||||
|
|
||||||
|
## Workspace Layout
|
||||||
|
|
||||||
|
```
|
||||||
rust/
|
rust/
|
||||||
├── Cargo.toml
|
├── Cargo.toml # Workspace root
|
||||||
├── Cargo.lock
|
├── Cargo.lock
|
||||||
├── README.md
|
|
||||||
└── crates/
|
└── crates/
|
||||||
├── api/ # Anthropic API client + SSE streaming support
|
├── api/ # Anthropic API client + SSE streaming
|
||||||
├── commands/ # Shared slash-command metadata/help surfaces
|
├── commands/ # Shared slash-command registry
|
||||||
├── compat-harness/ # Upstream TS manifest extraction harness
|
├── compat-harness/ # TS manifest extraction harness
|
||||||
├── runtime/ # Session/runtime/config/prompt orchestration
|
├── runtime/ # Session, config, permissions, MCP, prompts
|
||||||
├── rusty-claude-cli/ # Main CLI binary
|
├── rusty-claude-cli/ # Main CLI binary (`claw`)
|
||||||
└── tools/ # Built-in tool implementations
|
└── tools/ # Built-in tool implementations
|
||||||
```
|
```
|
||||||
|
|
||||||
## Prerequisites
|
### Crate Responsibilities
|
||||||
|
|
||||||
- Rust toolchain installed (`rustup`, stable toolchain)
|
- **api** — HTTP client, SSE stream parser, request/response types, auth (API key + OAuth bearer)
|
||||||
- Network access and Anthropic credentials for live prompt/REPL usage
|
- **commands** — Slash command definitions and help text generation
|
||||||
|
- **compat-harness** — Extracts tool/prompt manifests from upstream TS source
|
||||||
|
- **runtime** — `ConversationRuntime` agentic loop, `ConfigLoader` hierarchy, `Session` persistence, permission policy, MCP client, system prompt assembly, usage tracking
|
||||||
|
- **rusty-claude-cli** — REPL, one-shot prompt, streaming display, tool call rendering, CLI argument parsing
|
||||||
|
- **tools** — Tool specs + execution: Bash, ReadFile, WriteFile, EditFile, GlobSearch, GrepSearch, WebSearch, WebFetch, Agent, TodoWrite, NotebookEdit, Skill, ToolSearch, REPL runtimes
|
||||||
|
|
||||||
## Build
|
## Stats
|
||||||
|
|
||||||
From the repository root:
|
- **~20K lines** of Rust
|
||||||
|
- **6 crates** in workspace
|
||||||
|
- **Binary name:** `claw`
|
||||||
|
- **Default model:** `claude-opus-4-6`
|
||||||
|
- **Default permissions:** `danger-full-access`
|
||||||
|
|
||||||
```bash
|
## License
|
||||||
cd rust
|
|
||||||
cargo build --release -p rusty-claude-cli
|
|
||||||
```
|
|
||||||
|
|
||||||
The optimized binary will be written to:
|
See repository root.
|
||||||
|
|
||||||
```bash
|
|
||||||
./target/release/rusty-claude-cli
|
|
||||||
```
|
|
||||||
|
|
||||||
## Test
|
|
||||||
|
|
||||||
Run the verified workspace test suite used for release-readiness:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo test --workspace --exclude compat-harness
|
|
||||||
```
|
|
||||||
|
|
||||||
## Quick start
|
|
||||||
|
|
||||||
### Show help
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --help
|
|
||||||
```
|
|
||||||
|
|
||||||
### Print version
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --version
|
|
||||||
```
|
|
||||||
|
|
||||||
### Login with OAuth
|
|
||||||
|
|
||||||
Configure `settings.json` with an `oauth` block containing `clientId`, `authorizeUrl`, `tokenUrl`, optional `callbackPort`, and optional `scopes`, then run:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- login
|
|
||||||
```
|
|
||||||
|
|
||||||
This opens the browser, listens on the configured localhost callback, exchanges the auth code for tokens, and stores OAuth credentials in `~/.claude/credentials.json` (or `$CLAUDE_CONFIG_HOME/credentials.json`).
|
|
||||||
|
|
||||||
### Logout
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- logout
|
|
||||||
```
|
|
||||||
|
|
||||||
This removes only the stored OAuth credentials and preserves unrelated JSON fields in `credentials.json`.
|
|
||||||
|
|
||||||
### Self-update
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- self-update
|
|
||||||
```
|
|
||||||
|
|
||||||
The command checks the latest GitHub release for `instructkr/clawd-code`, compares it to the current binary version, downloads the matching binary asset plus checksum manifest, verifies SHA-256, replaces the current executable, and prints the release changelog. If no published release or matching asset exists, it exits safely with an explanatory message.
|
|
||||||
|
|
||||||
## Usage examples
|
|
||||||
|
|
||||||
### 1) Prompt mode
|
|
||||||
|
|
||||||
Send one prompt, stream the answer, then exit:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- prompt "Summarize the architecture of this repository"
|
|
||||||
```
|
|
||||||
|
|
||||||
Use a specific model:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --model claude-sonnet-4-20250514 prompt "List the key crates in this workspace"
|
|
||||||
```
|
|
||||||
|
|
||||||
Restrict enabled tools in an interactive session:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --allowedTools read,glob
|
|
||||||
```
|
|
||||||
|
|
||||||
Bootstrap Claude project files for the current repo:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- init
|
|
||||||
```
|
|
||||||
|
|
||||||
### 2) REPL mode
|
|
||||||
|
|
||||||
Start the interactive shell:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli --
|
|
||||||
```
|
|
||||||
|
|
||||||
Inside the REPL, useful commands include:
|
|
||||||
|
|
||||||
```text
|
|
||||||
/help
|
|
||||||
/status
|
|
||||||
/model claude-sonnet-4-20250514
|
|
||||||
/permissions workspace-write
|
|
||||||
/cost
|
|
||||||
/compact
|
|
||||||
/memory
|
|
||||||
/config
|
|
||||||
/init
|
|
||||||
/diff
|
|
||||||
/version
|
|
||||||
/export notes.txt
|
|
||||||
/sessions
|
|
||||||
/session list
|
|
||||||
/exit
|
|
||||||
```
|
|
||||||
|
|
||||||
### 3) Resume an existing session
|
|
||||||
|
|
||||||
Inspect or maintain a saved session file without entering the REPL:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --resume session-123456 /status /compact /cost
|
|
||||||
```
|
|
||||||
|
|
||||||
You can also inspect memory/config state for a restored session:
|
|
||||||
|
|
||||||
```bash
|
|
||||||
cd rust
|
|
||||||
cargo run -p rusty-claude-cli -- --resume ~/.claude/sessions/session-123456.json /memory /config
|
|
||||||
```
|
|
||||||
|
|
||||||
## Available commands
|
|
||||||
|
|
||||||
### Top-level CLI commands
|
|
||||||
|
|
||||||
- `prompt <text...>` — run one prompt non-interactively
|
|
||||||
- `--resume <session-id-or-path> [/commands...]` — inspect or maintain a saved session stored under `~/.claude/sessions/`
|
|
||||||
- `dump-manifests` — print extracted upstream manifest counts
|
|
||||||
- `bootstrap-plan` — print the current bootstrap skeleton
|
|
||||||
- `system-prompt [--cwd PATH] [--date YYYY-MM-DD]` — render the synthesized system prompt
|
|
||||||
- `self-update` — update the installed binary from the latest GitHub release when a matching asset is available
|
|
||||||
- `--help` / `-h` — show CLI help
|
|
||||||
- `--version` / `-V` — print the CLI version and build info locally (no API call)
|
|
||||||
- `--output-format text|json` — choose non-interactive prompt output rendering
|
|
||||||
- `--allowedTools <tool[,tool...]>` — restrict enabled tools for interactive sessions and prompt-mode tool use
|
|
||||||
|
|
||||||
### Interactive slash commands
|
|
||||||
|
|
||||||
- `/help` — show command help
|
|
||||||
- `/status` — show current session status
|
|
||||||
- `/compact` — compact local session history
|
|
||||||
- `/model [model]` — inspect or switch the active model
|
|
||||||
- `/permissions [read-only|workspace-write|danger-full-access]` — inspect or switch permissions
|
|
||||||
- `/clear [--confirm]` — clear the current local session
|
|
||||||
- `/cost` — show token usage totals
|
|
||||||
- `/resume <session-id-or-path>` — load a saved session into the REPL
|
|
||||||
- `/config [env|hooks|model]` — inspect discovered Claude config
|
|
||||||
- `/memory` — inspect loaded instruction memory files
|
|
||||||
- `/init` — bootstrap `.claude.json`, `.claude/`, `CLAUDE.md`, and local ignore rules
|
|
||||||
- `/diff` — show the current git diff for the workspace
|
|
||||||
- `/version` — print version and build metadata locally
|
|
||||||
- `/export [file]` — export the current conversation transcript
|
|
||||||
- `/sessions` — list recent managed local sessions from `~/.claude/sessions/`
|
|
||||||
- `/session [list|switch <session-id>]` — inspect or switch managed local sessions
|
|
||||||
- `/exit` — leave the REPL
|
|
||||||
|
|
||||||
## Environment variables
|
|
||||||
|
|
||||||
### Anthropic/API
|
|
||||||
|
|
||||||
- `ANTHROPIC_API_KEY` — highest-precedence API credential
|
|
||||||
- `ANTHROPIC_AUTH_TOKEN` — bearer-token override used when no API key is set
|
|
||||||
- Persisted OAuth credentials in `~/.claude/credentials.json` — used when neither env var is set
|
|
||||||
- `ANTHROPIC_BASE_URL` — override the Anthropic API base URL
|
|
||||||
- `ANTHROPIC_MODEL` — default model used by selected live integration tests
|
|
||||||
|
|
||||||
### CLI/runtime
|
|
||||||
|
|
||||||
- `RUSTY_CLAUDE_PERMISSION_MODE` — default REPL permission mode (`read-only`, `workspace-write`, or `danger-full-access`)
|
|
||||||
- `CLAUDE_CONFIG_HOME` — override Claude config discovery root
|
|
||||||
- `CLAUDE_CODE_REMOTE` — enable remote-session bootstrap handling when supported
|
|
||||||
- `CLAUDE_CODE_REMOTE_SESSION_ID` — remote session identifier when using remote mode
|
|
||||||
- `CLAUDE_CODE_UPSTREAM` — override the upstream TS source path for compat-harness extraction
|
|
||||||
- `CLAWD_WEB_SEARCH_BASE_URL` — override the built-in web search service endpoint used by tooling
|
|
||||||
|
|
||||||
## Notes
|
|
||||||
|
|
||||||
- `compat-harness` exists to compare the Rust port against the upstream TypeScript codebase and is intentionally excluded from the requested release test run.
|
|
||||||
- The CLI currently focuses on a practical integrated workflow: prompt execution, REPL operation, session inspection/resume, config discovery, and tool/runtime plumbing.
|
|
||||||
|
|||||||
@@ -4,8 +4,8 @@ mod sse;
|
|||||||
mod types;
|
mod types;
|
||||||
|
|
||||||
pub use client::{
|
pub use client::{
|
||||||
oauth_token_is_expired, read_base_url, resolve_saved_oauth_token,
|
oauth_token_is_expired, read_base_url, resolve_saved_oauth_token, resolve_startup_auth_source,
|
||||||
resolve_startup_auth_source, AnthropicClient, AuthSource, MessageStream, OAuthTokenSet,
|
AnthropicClient, AuthSource, MessageStream, OAuthTokenSet,
|
||||||
};
|
};
|
||||||
pub use error::ApiError;
|
pub use error::ApiError;
|
||||||
pub use sse::{parse_frame, SseParser};
|
pub use sse::{parse_frame, SseParser};
|
||||||
|
|||||||
@@ -37,13 +37,29 @@ pub struct RuntimeConfig {
|
|||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
pub struct RuntimeFeatureConfig {
|
pub struct RuntimeFeatureConfig {
|
||||||
|
hooks: RuntimeHookConfig,
|
||||||
mcp: McpConfigCollection,
|
mcp: McpConfigCollection,
|
||||||
oauth: Option<OAuthConfig>,
|
oauth: Option<OAuthConfig>,
|
||||||
model: Option<String>,
|
model: Option<String>,
|
||||||
permission_mode: Option<ResolvedPermissionMode>,
|
permission_mode: Option<ResolvedPermissionMode>,
|
||||||
|
permission_rules: RuntimePermissionRuleConfig,
|
||||||
sandbox: SandboxConfig,
|
sandbox: SandboxConfig,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct RuntimeHookConfig {
|
||||||
|
pre_tool_use: Vec<String>,
|
||||||
|
post_tool_use: Vec<String>,
|
||||||
|
post_tool_use_failure: Vec<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct RuntimePermissionRuleConfig {
|
||||||
|
allow: Vec<String>,
|
||||||
|
deny: Vec<String>,
|
||||||
|
ask: Vec<String>,
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
pub struct McpConfigCollection {
|
pub struct McpConfigCollection {
|
||||||
servers: BTreeMap<String, ScopedMcpServerConfig>,
|
servers: BTreeMap<String, ScopedMcpServerConfig>,
|
||||||
@@ -221,12 +237,14 @@ impl ConfigLoader {
|
|||||||
let merged_value = JsonValue::Object(merged.clone());
|
let merged_value = JsonValue::Object(merged.clone());
|
||||||
|
|
||||||
let feature_config = RuntimeFeatureConfig {
|
let feature_config = RuntimeFeatureConfig {
|
||||||
|
hooks: parse_optional_hooks_config(&merged_value)?,
|
||||||
mcp: McpConfigCollection {
|
mcp: McpConfigCollection {
|
||||||
servers: mcp_servers,
|
servers: mcp_servers,
|
||||||
},
|
},
|
||||||
oauth: parse_optional_oauth_config(&merged_value, "merged settings.oauth")?,
|
oauth: parse_optional_oauth_config(&merged_value, "merged settings.oauth")?,
|
||||||
model: parse_optional_model(&merged_value),
|
model: parse_optional_model(&merged_value),
|
||||||
permission_mode: parse_optional_permission_mode(&merged_value)?,
|
permission_mode: parse_optional_permission_mode(&merged_value)?,
|
||||||
|
permission_rules: parse_optional_permission_rules(&merged_value)?,
|
||||||
sandbox: parse_optional_sandbox_config(&merged_value)?,
|
sandbox: parse_optional_sandbox_config(&merged_value)?,
|
||||||
};
|
};
|
||||||
|
|
||||||
@@ -278,6 +296,11 @@ impl RuntimeConfig {
|
|||||||
&self.feature_config.mcp
|
&self.feature_config.mcp
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn hooks(&self) -> &RuntimeHookConfig {
|
||||||
|
&self.feature_config.hooks
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
pub fn oauth(&self) -> Option<&OAuthConfig> {
|
||||||
self.feature_config.oauth.as_ref()
|
self.feature_config.oauth.as_ref()
|
||||||
@@ -293,6 +316,11 @@ impl RuntimeConfig {
|
|||||||
self.feature_config.permission_mode
|
self.feature_config.permission_mode
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn permission_rules(&self) -> &RuntimePermissionRuleConfig {
|
||||||
|
&self.feature_config.permission_rules
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn sandbox(&self) -> &SandboxConfig {
|
pub fn sandbox(&self) -> &SandboxConfig {
|
||||||
&self.feature_config.sandbox
|
&self.feature_config.sandbox
|
||||||
@@ -300,6 +328,17 @@ impl RuntimeConfig {
|
|||||||
}
|
}
|
||||||
|
|
||||||
impl RuntimeFeatureConfig {
|
impl RuntimeFeatureConfig {
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_hooks(mut self, hooks: RuntimeHookConfig) -> Self {
|
||||||
|
self.hooks = hooks;
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn hooks(&self) -> &RuntimeHookConfig {
|
||||||
|
&self.hooks
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn mcp(&self) -> &McpConfigCollection {
|
pub fn mcp(&self) -> &McpConfigCollection {
|
||||||
&self.mcp
|
&self.mcp
|
||||||
@@ -320,12 +359,69 @@ impl RuntimeFeatureConfig {
|
|||||||
self.permission_mode
|
self.permission_mode
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn permission_rules(&self) -> &RuntimePermissionRuleConfig {
|
||||||
|
&self.permission_rules
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn sandbox(&self) -> &SandboxConfig {
|
pub fn sandbox(&self) -> &SandboxConfig {
|
||||||
&self.sandbox
|
&self.sandbox
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
impl RuntimeHookConfig {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(
|
||||||
|
pre_tool_use: Vec<String>,
|
||||||
|
post_tool_use: Vec<String>,
|
||||||
|
post_tool_use_failure: Vec<String>,
|
||||||
|
) -> Self {
|
||||||
|
Self {
|
||||||
|
pre_tool_use,
|
||||||
|
post_tool_use,
|
||||||
|
post_tool_use_failure,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn pre_tool_use(&self) -> &[String] {
|
||||||
|
&self.pre_tool_use
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn post_tool_use(&self) -> &[String] {
|
||||||
|
&self.post_tool_use
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn post_tool_use_failure(&self) -> &[String] {
|
||||||
|
&self.post_tool_use_failure
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl RuntimePermissionRuleConfig {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(allow: Vec<String>, deny: Vec<String>, ask: Vec<String>) -> Self {
|
||||||
|
Self { allow, deny, ask }
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn allow(&self) -> &[String] {
|
||||||
|
&self.allow
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn deny(&self) -> &[String] {
|
||||||
|
&self.deny
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn ask(&self) -> &[String] {
|
||||||
|
&self.ask
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
impl McpConfigCollection {
|
impl McpConfigCollection {
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn servers(&self) -> &BTreeMap<String, ScopedMcpServerConfig> {
|
pub fn servers(&self) -> &BTreeMap<String, ScopedMcpServerConfig> {
|
||||||
@@ -424,6 +520,48 @@ fn parse_optional_model(root: &JsonValue) -> Option<String> {
|
|||||||
.map(ToOwned::to_owned)
|
.map(ToOwned::to_owned)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn parse_optional_hooks_config(root: &JsonValue) -> Result<RuntimeHookConfig, ConfigError> {
|
||||||
|
let Some(object) = root.as_object() else {
|
||||||
|
return Ok(RuntimeHookConfig::default());
|
||||||
|
};
|
||||||
|
let Some(hooks_value) = object.get("hooks") else {
|
||||||
|
return Ok(RuntimeHookConfig::default());
|
||||||
|
};
|
||||||
|
let hooks = expect_object(hooks_value, "merged settings.hooks")?;
|
||||||
|
Ok(RuntimeHookConfig {
|
||||||
|
pre_tool_use: optional_string_array(hooks, "PreToolUse", "merged settings.hooks")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
post_tool_use: optional_string_array(hooks, "PostToolUse", "merged settings.hooks")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
post_tool_use_failure: optional_string_array(
|
||||||
|
hooks,
|
||||||
|
"PostToolUseFailure",
|
||||||
|
"merged settings.hooks",
|
||||||
|
)?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn parse_optional_permission_rules(
|
||||||
|
root: &JsonValue,
|
||||||
|
) -> Result<RuntimePermissionRuleConfig, ConfigError> {
|
||||||
|
let Some(object) = root.as_object() else {
|
||||||
|
return Ok(RuntimePermissionRuleConfig::default());
|
||||||
|
};
|
||||||
|
let Some(permissions) = object.get("permissions").and_then(JsonValue::as_object) else {
|
||||||
|
return Ok(RuntimePermissionRuleConfig::default());
|
||||||
|
};
|
||||||
|
|
||||||
|
Ok(RuntimePermissionRuleConfig {
|
||||||
|
allow: optional_string_array(permissions, "allow", "merged settings.permissions")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
deny: optional_string_array(permissions, "deny", "merged settings.permissions")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
ask: optional_string_array(permissions, "ask", "merged settings.permissions")?
|
||||||
|
.unwrap_or_default(),
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
fn parse_optional_permission_mode(
|
fn parse_optional_permission_mode(
|
||||||
root: &JsonValue,
|
root: &JsonValue,
|
||||||
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
) -> Result<Option<ResolvedPermissionMode>, ConfigError> {
|
||||||
@@ -783,7 +921,7 @@ mod tests {
|
|||||||
.expect("write user compat config");
|
.expect("write user compat config");
|
||||||
fs::write(
|
fs::write(
|
||||||
home.join("settings.json"),
|
home.join("settings.json"),
|
||||||
r#"{"model":"sonnet","env":{"A2":"1"},"hooks":{"PreToolUse":["base"]},"permissions":{"defaultMode":"plan"}}"#,
|
r#"{"model":"sonnet","env":{"A2":"1"},"hooks":{"PreToolUse":["base"]},"permissions":{"defaultMode":"plan","allow":["Read"],"deny":["Bash(rm -rf)"]}}"#,
|
||||||
)
|
)
|
||||||
.expect("write user settings");
|
.expect("write user settings");
|
||||||
fs::write(
|
fs::write(
|
||||||
@@ -793,7 +931,7 @@ mod tests {
|
|||||||
.expect("write project compat config");
|
.expect("write project compat config");
|
||||||
fs::write(
|
fs::write(
|
||||||
cwd.join(".claude").join("settings.json"),
|
cwd.join(".claude").join("settings.json"),
|
||||||
r#"{"env":{"C":"3"},"hooks":{"PostToolUse":["project"]},"mcpServers":{"project":{"command":"uvx","args":["project"]}}}"#,
|
r#"{"env":{"C":"3"},"hooks":{"PostToolUse":["project"],"PostToolUseFailure":["project-failure"]},"permissions":{"ask":["Edit"]},"mcpServers":{"project":{"command":"uvx","args":["project"]}}}"#,
|
||||||
)
|
)
|
||||||
.expect("write project settings");
|
.expect("write project settings");
|
||||||
fs::write(
|
fs::write(
|
||||||
@@ -836,6 +974,18 @@ mod tests {
|
|||||||
.and_then(JsonValue::as_object)
|
.and_then(JsonValue::as_object)
|
||||||
.expect("hooks object")
|
.expect("hooks object")
|
||||||
.contains_key("PostToolUse"));
|
.contains_key("PostToolUse"));
|
||||||
|
assert_eq!(loaded.hooks().pre_tool_use(), &["base".to_string()]);
|
||||||
|
assert_eq!(loaded.hooks().post_tool_use(), &["project".to_string()]);
|
||||||
|
assert_eq!(
|
||||||
|
loaded.hooks().post_tool_use_failure(),
|
||||||
|
&["project-failure".to_string()]
|
||||||
|
);
|
||||||
|
assert_eq!(loaded.permission_rules().allow(), &["Read".to_string()]);
|
||||||
|
assert_eq!(
|
||||||
|
loaded.permission_rules().deny(),
|
||||||
|
&["Bash(rm -rf)".to_string()]
|
||||||
|
);
|
||||||
|
assert_eq!(loaded.permission_rules().ask(), &["Edit".to_string()]);
|
||||||
assert!(loaded.mcp().get("home").is_some());
|
assert!(loaded.mcp().get("home").is_some());
|
||||||
assert!(loaded.mcp().get("project").is_some());
|
assert!(loaded.mcp().get("project").is_some());
|
||||||
|
|
||||||
|
|||||||
@@ -4,7 +4,11 @@ use std::fmt::{Display, Formatter};
|
|||||||
use crate::compact::{
|
use crate::compact::{
|
||||||
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
compact_session, estimate_session_tokens, CompactionConfig, CompactionResult,
|
||||||
};
|
};
|
||||||
use crate::permissions::{PermissionOutcome, PermissionPolicy, PermissionPrompter};
|
use crate::config::RuntimeFeatureConfig;
|
||||||
|
use crate::hooks::{HookAbortSignal, HookProgressReporter, HookRunResult, HookRunner};
|
||||||
|
use crate::permissions::{
|
||||||
|
PermissionContext, PermissionOutcome, PermissionPolicy, PermissionPrompter,
|
||||||
|
};
|
||||||
use crate::session::{ContentBlock, ConversationMessage, Session};
|
use crate::session::{ContentBlock, ConversationMessage, Session};
|
||||||
use crate::usage::{TokenUsage, UsageTracker};
|
use crate::usage::{TokenUsage, UsageTracker};
|
||||||
|
|
||||||
@@ -94,6 +98,9 @@ pub struct ConversationRuntime<C, T> {
|
|||||||
system_prompt: Vec<String>,
|
system_prompt: Vec<String>,
|
||||||
max_iterations: usize,
|
max_iterations: usize,
|
||||||
usage_tracker: UsageTracker,
|
usage_tracker: UsageTracker,
|
||||||
|
hook_runner: HookRunner,
|
||||||
|
hook_abort_signal: HookAbortSignal,
|
||||||
|
hook_progress_reporter: Option<Box<dyn HookProgressReporter>>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl<C, T> ConversationRuntime<C, T>
|
impl<C, T> ConversationRuntime<C, T>
|
||||||
@@ -108,6 +115,26 @@ where
|
|||||||
tool_executor: T,
|
tool_executor: T,
|
||||||
permission_policy: PermissionPolicy,
|
permission_policy: PermissionPolicy,
|
||||||
system_prompt: Vec<String>,
|
system_prompt: Vec<String>,
|
||||||
|
) -> Self {
|
||||||
|
Self::new_with_features(
|
||||||
|
session,
|
||||||
|
api_client,
|
||||||
|
tool_executor,
|
||||||
|
permission_policy,
|
||||||
|
system_prompt,
|
||||||
|
RuntimeFeatureConfig::default(),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
#[allow(clippy::needless_pass_by_value)]
|
||||||
|
pub fn new_with_features(
|
||||||
|
session: Session,
|
||||||
|
api_client: C,
|
||||||
|
tool_executor: T,
|
||||||
|
permission_policy: PermissionPolicy,
|
||||||
|
system_prompt: Vec<String>,
|
||||||
|
feature_config: RuntimeFeatureConfig,
|
||||||
) -> Self {
|
) -> Self {
|
||||||
let usage_tracker = UsageTracker::from_session(&session);
|
let usage_tracker = UsageTracker::from_session(&session);
|
||||||
Self {
|
Self {
|
||||||
@@ -118,6 +145,9 @@ where
|
|||||||
system_prompt,
|
system_prompt,
|
||||||
max_iterations: usize::MAX,
|
max_iterations: usize::MAX,
|
||||||
usage_tracker,
|
usage_tracker,
|
||||||
|
hook_runner: HookRunner::from_feature_config(&feature_config),
|
||||||
|
hook_abort_signal: HookAbortSignal::default(),
|
||||||
|
hook_progress_reporter: None,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -127,6 +157,93 @@ where
|
|||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_hook_abort_signal(mut self, hook_abort_signal: HookAbortSignal) -> Self {
|
||||||
|
self.hook_abort_signal = hook_abort_signal;
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_hook_progress_reporter(
|
||||||
|
mut self,
|
||||||
|
hook_progress_reporter: Box<dyn HookProgressReporter>,
|
||||||
|
) -> Self {
|
||||||
|
self.hook_progress_reporter = Some(hook_progress_reporter);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_pre_tool_use_hook(&mut self, tool_name: &str, input: &str) -> HookRunResult {
|
||||||
|
if let Some(reporter) = self.hook_progress_reporter.as_mut() {
|
||||||
|
self.hook_runner.run_pre_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
Some(reporter.as_mut()),
|
||||||
|
)
|
||||||
|
} else {
|
||||||
|
self.hook_runner.run_pre_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_post_tool_use_hook(
|
||||||
|
&mut self,
|
||||||
|
tool_name: &str,
|
||||||
|
input: &str,
|
||||||
|
output: &str,
|
||||||
|
is_error: bool,
|
||||||
|
) -> HookRunResult {
|
||||||
|
if let Some(reporter) = self.hook_progress_reporter.as_mut() {
|
||||||
|
self.hook_runner.run_post_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
output,
|
||||||
|
is_error,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
Some(reporter.as_mut()),
|
||||||
|
)
|
||||||
|
} else {
|
||||||
|
self.hook_runner.run_post_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
output,
|
||||||
|
is_error,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_post_tool_use_failure_hook(
|
||||||
|
&mut self,
|
||||||
|
tool_name: &str,
|
||||||
|
input: &str,
|
||||||
|
output: &str,
|
||||||
|
) -> HookRunResult {
|
||||||
|
if let Some(reporter) = self.hook_progress_reporter.as_mut() {
|
||||||
|
self.hook_runner.run_post_tool_use_failure_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
output,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
Some(reporter.as_mut()),
|
||||||
|
)
|
||||||
|
} else {
|
||||||
|
self.hook_runner.run_post_tool_use_failure_with_context(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
output,
|
||||||
|
Some(&self.hook_abort_signal),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(clippy::too_many_lines)]
|
||||||
pub fn run_turn(
|
pub fn run_turn(
|
||||||
&mut self,
|
&mut self,
|
||||||
user_input: impl Into<String>,
|
user_input: impl Into<String>,
|
||||||
@@ -176,33 +293,85 @@ where
|
|||||||
}
|
}
|
||||||
|
|
||||||
for (tool_use_id, tool_name, input) in pending_tool_uses {
|
for (tool_use_id, tool_name, input) in pending_tool_uses {
|
||||||
let permission_outcome = if let Some(prompt) = prompter.as_mut() {
|
let pre_hook_result = self.run_pre_tool_use_hook(&tool_name, &input);
|
||||||
self.permission_policy
|
let effective_input = pre_hook_result
|
||||||
.authorize(&tool_name, &input, Some(*prompt))
|
.updated_input()
|
||||||
|
.map_or_else(|| input.clone(), ToOwned::to_owned);
|
||||||
|
let permission_context = PermissionContext::new(
|
||||||
|
pre_hook_result.permission_override(),
|
||||||
|
pre_hook_result.permission_reason().map(ToOwned::to_owned),
|
||||||
|
);
|
||||||
|
|
||||||
|
let permission_outcome = if pre_hook_result.is_cancelled() {
|
||||||
|
PermissionOutcome::Deny {
|
||||||
|
reason: format_hook_message(
|
||||||
|
&pre_hook_result,
|
||||||
|
&format!("PreToolUse hook cancelled tool `{tool_name}`"),
|
||||||
|
),
|
||||||
|
}
|
||||||
|
} else if pre_hook_result.is_denied() {
|
||||||
|
PermissionOutcome::Deny {
|
||||||
|
reason: format_hook_message(
|
||||||
|
&pre_hook_result,
|
||||||
|
&format!("PreToolUse hook denied tool `{tool_name}`"),
|
||||||
|
),
|
||||||
|
}
|
||||||
|
} else if let Some(prompt) = prompter.as_mut() {
|
||||||
|
self.permission_policy.authorize_with_context(
|
||||||
|
&tool_name,
|
||||||
|
&effective_input,
|
||||||
|
&permission_context,
|
||||||
|
Some(*prompt),
|
||||||
|
)
|
||||||
} else {
|
} else {
|
||||||
self.permission_policy.authorize(&tool_name, &input, None)
|
self.permission_policy.authorize_with_context(
|
||||||
|
&tool_name,
|
||||||
|
&effective_input,
|
||||||
|
&permission_context,
|
||||||
|
None,
|
||||||
|
)
|
||||||
};
|
};
|
||||||
|
|
||||||
let result_message = match permission_outcome {
|
let result_message = match permission_outcome {
|
||||||
PermissionOutcome::Allow => {
|
PermissionOutcome::Allow => {
|
||||||
match self.tool_executor.execute(&tool_name, &input) {
|
let (mut output, mut is_error) =
|
||||||
Ok(output) => ConversationMessage::tool_result(
|
match self.tool_executor.execute(&tool_name, &effective_input) {
|
||||||
tool_use_id,
|
Ok(output) => (output, false),
|
||||||
tool_name,
|
Err(error) => (error.to_string(), true),
|
||||||
output,
|
};
|
||||||
|
output = merge_hook_feedback(pre_hook_result.messages(), output, false);
|
||||||
|
|
||||||
|
let post_hook_result = if is_error {
|
||||||
|
self.run_post_tool_use_failure_hook(
|
||||||
|
&tool_name,
|
||||||
|
&effective_input,
|
||||||
|
&output,
|
||||||
|
)
|
||||||
|
} else {
|
||||||
|
self.run_post_tool_use_hook(
|
||||||
|
&tool_name,
|
||||||
|
&effective_input,
|
||||||
|
&output,
|
||||||
false,
|
false,
|
||||||
),
|
)
|
||||||
Err(error) => ConversationMessage::tool_result(
|
};
|
||||||
tool_use_id,
|
if post_hook_result.is_denied() || post_hook_result.is_cancelled() {
|
||||||
tool_name,
|
is_error = true;
|
||||||
error.to_string(),
|
|
||||||
true,
|
|
||||||
),
|
|
||||||
}
|
}
|
||||||
|
output = merge_hook_feedback(
|
||||||
|
post_hook_result.messages(),
|
||||||
|
output,
|
||||||
|
post_hook_result.is_denied() || post_hook_result.is_cancelled(),
|
||||||
|
);
|
||||||
|
|
||||||
|
ConversationMessage::tool_result(tool_use_id, tool_name, output, is_error)
|
||||||
}
|
}
|
||||||
PermissionOutcome::Deny { reason } => {
|
PermissionOutcome::Deny { reason } => ConversationMessage::tool_result(
|
||||||
ConversationMessage::tool_result(tool_use_id, tool_name, reason, true)
|
tool_use_id,
|
||||||
}
|
tool_name,
|
||||||
|
merge_hook_feedback(pre_hook_result.messages(), reason, true),
|
||||||
|
true,
|
||||||
|
),
|
||||||
};
|
};
|
||||||
self.session.messages.push(result_message.clone());
|
self.session.messages.push(result_message.clone());
|
||||||
tool_results.push(result_message);
|
tool_results.push(result_message);
|
||||||
@@ -290,6 +459,32 @@ fn flush_text_block(text: &mut String, blocks: &mut Vec<ContentBlock>) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn format_hook_message(result: &HookRunResult, fallback: &str) -> String {
|
||||||
|
if result.messages().is_empty() {
|
||||||
|
fallback.to_string()
|
||||||
|
} else {
|
||||||
|
result.messages().join("\n")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn merge_hook_feedback(messages: &[String], output: String, denied: bool) -> String {
|
||||||
|
if messages.is_empty() {
|
||||||
|
return output;
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut sections = Vec::new();
|
||||||
|
if !output.trim().is_empty() {
|
||||||
|
sections.push(output);
|
||||||
|
}
|
||||||
|
let label = if denied {
|
||||||
|
"Hook feedback (denied)"
|
||||||
|
} else {
|
||||||
|
"Hook feedback"
|
||||||
|
};
|
||||||
|
sections.push(format!("{label}:\n{}", messages.join("\n")));
|
||||||
|
sections.join("\n\n")
|
||||||
|
}
|
||||||
|
|
||||||
type ToolHandler = Box<dyn FnMut(&str) -> Result<String, ToolError>>;
|
type ToolHandler = Box<dyn FnMut(&str) -> Result<String, ToolError>>;
|
||||||
|
|
||||||
#[derive(Default)]
|
#[derive(Default)]
|
||||||
@@ -329,6 +524,7 @@ mod tests {
|
|||||||
StaticToolExecutor,
|
StaticToolExecutor,
|
||||||
};
|
};
|
||||||
use crate::compact::CompactionConfig;
|
use crate::compact::CompactionConfig;
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
use crate::permissions::{
|
use crate::permissions::{
|
||||||
PermissionMode, PermissionPolicy, PermissionPromptDecision, PermissionPrompter,
|
PermissionMode, PermissionPolicy, PermissionPromptDecision, PermissionPrompter,
|
||||||
PermissionRequest,
|
PermissionRequest,
|
||||||
@@ -503,6 +699,143 @@ mod tests {
|
|||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn denies_tool_use_when_pre_tool_hook_blocks() {
|
||||||
|
struct SingleCallApiClient;
|
||||||
|
impl ApiClient for SingleCallApiClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
if request
|
||||||
|
.messages
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.role == MessageRole::Tool)
|
||||||
|
{
|
||||||
|
return Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("blocked".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
]);
|
||||||
|
}
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "blocked".to_string(),
|
||||||
|
input: r#"{"path":"secret.txt"}"#.to_string(),
|
||||||
|
},
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut runtime = ConversationRuntime::new_with_features(
|
||||||
|
Session::new(),
|
||||||
|
SingleCallApiClient,
|
||||||
|
StaticToolExecutor::new().register("blocked", |_input| {
|
||||||
|
panic!("tool should not execute when hook denies")
|
||||||
|
}),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn("use the tool", None)
|
||||||
|
.expect("conversation should continue after hook denial");
|
||||||
|
|
||||||
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
|
let ContentBlock::ToolResult {
|
||||||
|
is_error, output, ..
|
||||||
|
} = &summary.tool_results[0].blocks[0]
|
||||||
|
else {
|
||||||
|
panic!("expected tool result block");
|
||||||
|
};
|
||||||
|
assert!(
|
||||||
|
*is_error,
|
||||||
|
"hook denial should produce an error result: {output}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("denied tool") || output.contains("blocked by hook"),
|
||||||
|
"unexpected hook denial output: {output:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn appends_post_tool_hook_feedback_to_tool_result() {
|
||||||
|
struct TwoCallApiClient {
|
||||||
|
calls: usize,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ApiClient for TwoCallApiClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
self.calls += 1;
|
||||||
|
match self.calls {
|
||||||
|
1 => Ok(vec![
|
||||||
|
AssistantEvent::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "add".to_string(),
|
||||||
|
input: r#"{"lhs":2,"rhs":2}"#.to_string(),
|
||||||
|
},
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
]),
|
||||||
|
2 => {
|
||||||
|
assert!(request
|
||||||
|
.messages
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.role == MessageRole::Tool));
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("done".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
_ => Err(RuntimeError::new("unexpected extra API call")),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
let mut runtime = ConversationRuntime::new_with_features(
|
||||||
|
Session::new(),
|
||||||
|
TwoCallApiClient { calls: 0 },
|
||||||
|
StaticToolExecutor::new().register("add", |_input| Ok("4".to_string())),
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
vec!["system".to_string()],
|
||||||
|
RuntimeFeatureConfig::default().with_hooks(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'pre hook ran'")],
|
||||||
|
vec![shell_snippet("printf 'post hook ran'")],
|
||||||
|
Vec::new(),
|
||||||
|
)),
|
||||||
|
);
|
||||||
|
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn("use add", None)
|
||||||
|
.expect("tool loop succeeds");
|
||||||
|
|
||||||
|
assert_eq!(summary.tool_results.len(), 1);
|
||||||
|
let ContentBlock::ToolResult {
|
||||||
|
is_error, output, ..
|
||||||
|
} = &summary.tool_results[0].blocks[0]
|
||||||
|
else {
|
||||||
|
panic!("expected tool result block");
|
||||||
|
};
|
||||||
|
assert!(
|
||||||
|
!*is_error,
|
||||||
|
"post hook should preserve non-error result: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains('4'),
|
||||||
|
"tool output missing value: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("pre hook ran"),
|
||||||
|
"tool output missing pre hook feedback: {output:?}"
|
||||||
|
);
|
||||||
|
assert!(
|
||||||
|
output.contains("post hook ran"),
|
||||||
|
"tool output missing post hook feedback: {output:?}"
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn reconstructs_usage_tracker_from_restored_session() {
|
fn reconstructs_usage_tracker_from_restored_session() {
|
||||||
struct SimpleApi;
|
struct SimpleApi;
|
||||||
@@ -581,4 +914,14 @@ mod tests {
|
|||||||
MessageRole::System
|
MessageRole::System
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.replace('\'', "\"")
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.to_string()
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
853
rust/crates/runtime/src/hooks.rs
Normal file
853
rust/crates/runtime/src/hooks.rs
Normal file
@@ -0,0 +1,853 @@
|
|||||||
|
use std::ffi::OsStr;
|
||||||
|
use std::io::Write;
|
||||||
|
use std::process::{Command, Stdio};
|
||||||
|
use std::sync::{
|
||||||
|
atomic::{AtomicBool, Ordering},
|
||||||
|
Arc,
|
||||||
|
};
|
||||||
|
use std::thread;
|
||||||
|
use std::time::Duration;
|
||||||
|
|
||||||
|
use serde_json::{json, Value};
|
||||||
|
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
|
use crate::permissions::PermissionOverride;
|
||||||
|
|
||||||
|
pub type HookPermissionDecision = PermissionOverride;
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum HookEvent {
|
||||||
|
PreToolUse,
|
||||||
|
PostToolUse,
|
||||||
|
PostToolUseFailure,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookEvent {
|
||||||
|
#[must_use]
|
||||||
|
pub fn as_str(self) -> &'static str {
|
||||||
|
match self {
|
||||||
|
Self::PreToolUse => "PreToolUse",
|
||||||
|
Self::PostToolUse => "PostToolUse",
|
||||||
|
Self::PostToolUseFailure => "PostToolUseFailure",
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub enum HookProgressEvent {
|
||||||
|
Started {
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: String,
|
||||||
|
command: String,
|
||||||
|
},
|
||||||
|
Completed {
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: String,
|
||||||
|
command: String,
|
||||||
|
},
|
||||||
|
Cancelled {
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: String,
|
||||||
|
command: String,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
pub trait HookProgressReporter {
|
||||||
|
fn on_event(&mut self, event: &HookProgressEvent);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Default)]
|
||||||
|
pub struct HookAbortSignal {
|
||||||
|
aborted: Arc<AtomicBool>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookAbortSignal {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new() -> Self {
|
||||||
|
Self::default()
|
||||||
|
}
|
||||||
|
|
||||||
|
pub fn abort(&self) {
|
||||||
|
self.aborted.store(true, Ordering::SeqCst);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn is_aborted(&self) -> bool {
|
||||||
|
self.aborted.load(Ordering::SeqCst)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
pub struct HookRunResult {
|
||||||
|
denied: bool,
|
||||||
|
cancelled: bool,
|
||||||
|
messages: Vec<String>,
|
||||||
|
permission_override: Option<PermissionOverride>,
|
||||||
|
permission_reason: Option<String>,
|
||||||
|
updated_input: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookRunResult {
|
||||||
|
#[must_use]
|
||||||
|
pub fn allow(messages: Vec<String>) -> Self {
|
||||||
|
Self {
|
||||||
|
denied: false,
|
||||||
|
cancelled: false,
|
||||||
|
messages,
|
||||||
|
permission_override: None,
|
||||||
|
permission_reason: None,
|
||||||
|
updated_input: None,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn is_denied(&self) -> bool {
|
||||||
|
self.denied
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn is_cancelled(&self) -> bool {
|
||||||
|
self.cancelled
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn messages(&self) -> &[String] {
|
||||||
|
&self.messages
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn permission_override(&self) -> Option<PermissionOverride> {
|
||||||
|
self.permission_override
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn permission_decision(&self) -> Option<HookPermissionDecision> {
|
||||||
|
self.permission_override
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn permission_reason(&self) -> Option<&str> {
|
||||||
|
self.permission_reason.as_deref()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn updated_input(&self) -> Option<&str> {
|
||||||
|
self.updated_input.as_deref()
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn updated_input_json(&self) -> Option<&str> {
|
||||||
|
self.updated_input()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct HookRunner {
|
||||||
|
config: RuntimeHookConfig,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookRunner {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(config: RuntimeHookConfig) -> Self {
|
||||||
|
Self { config }
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn from_feature_config(feature_config: &RuntimeFeatureConfig) -> Self {
|
||||||
|
Self::new(feature_config.hooks().clone())
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_pre_tool_use(&self, tool_name: &str, tool_input: &str) -> HookRunResult {
|
||||||
|
self.run_pre_tool_use_with_context(tool_name, tool_input, None, None)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_pre_tool_use_with_context(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
reporter: Option<&mut dyn HookProgressReporter>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
Self::run_commands(
|
||||||
|
HookEvent::PreToolUse,
|
||||||
|
self.config.pre_tool_use(),
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
None,
|
||||||
|
false,
|
||||||
|
abort_signal,
|
||||||
|
reporter,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_pre_tool_use_with_signal(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_pre_tool_use_with_context(tool_name, tool_input, abort_signal, None)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: &str,
|
||||||
|
is_error: bool,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_post_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
tool_output,
|
||||||
|
is_error,
|
||||||
|
None,
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use_with_context(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: &str,
|
||||||
|
is_error: bool,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
reporter: Option<&mut dyn HookProgressReporter>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
Self::run_commands(
|
||||||
|
HookEvent::PostToolUse,
|
||||||
|
self.config.post_tool_use(),
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
Some(tool_output),
|
||||||
|
is_error,
|
||||||
|
abort_signal,
|
||||||
|
reporter,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use_with_signal(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: &str,
|
||||||
|
is_error: bool,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_post_tool_use_with_context(
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
tool_output,
|
||||||
|
is_error,
|
||||||
|
abort_signal,
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use_failure(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_error: &str,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_post_tool_use_failure_with_context(tool_name, tool_input, tool_error, None, None)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use_failure_with_context(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_error: &str,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
reporter: Option<&mut dyn HookProgressReporter>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
Self::run_commands(
|
||||||
|
HookEvent::PostToolUseFailure,
|
||||||
|
self.config.post_tool_use_failure(),
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
Some(tool_error),
|
||||||
|
true,
|
||||||
|
abort_signal,
|
||||||
|
reporter,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn run_post_tool_use_failure_with_signal(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_error: &str,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
self.run_post_tool_use_failure_with_context(
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
tool_error,
|
||||||
|
abort_signal,
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(clippy::too_many_arguments)]
|
||||||
|
fn run_commands(
|
||||||
|
event: HookEvent,
|
||||||
|
commands: &[String],
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: Option<&str>,
|
||||||
|
is_error: bool,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
mut reporter: Option<&mut dyn HookProgressReporter>,
|
||||||
|
) -> HookRunResult {
|
||||||
|
if commands.is_empty() {
|
||||||
|
return HookRunResult::allow(Vec::new());
|
||||||
|
}
|
||||||
|
|
||||||
|
if abort_signal.is_some_and(HookAbortSignal::is_aborted) {
|
||||||
|
return HookRunResult {
|
||||||
|
denied: false,
|
||||||
|
cancelled: true,
|
||||||
|
messages: vec![format!(
|
||||||
|
"{} hook cancelled before execution",
|
||||||
|
event.as_str()
|
||||||
|
)],
|
||||||
|
permission_override: None,
|
||||||
|
permission_reason: None,
|
||||||
|
updated_input: None,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
let payload = hook_payload(event, tool_name, tool_input, tool_output, is_error).to_string();
|
||||||
|
let mut result = HookRunResult::allow(Vec::new());
|
||||||
|
|
||||||
|
for command in commands {
|
||||||
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
|
reporter.on_event(&HookProgressEvent::Started {
|
||||||
|
event,
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
command: command.clone(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
|
||||||
|
match Self::run_command(
|
||||||
|
command,
|
||||||
|
event,
|
||||||
|
tool_name,
|
||||||
|
tool_input,
|
||||||
|
tool_output,
|
||||||
|
is_error,
|
||||||
|
&payload,
|
||||||
|
abort_signal,
|
||||||
|
) {
|
||||||
|
HookCommandOutcome::Allow { parsed } => {
|
||||||
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
|
event,
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
command: command.clone(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
merge_parsed_hook_output(&mut result, parsed);
|
||||||
|
}
|
||||||
|
HookCommandOutcome::Deny { parsed } => {
|
||||||
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
|
event,
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
command: command.clone(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
merge_parsed_hook_output(&mut result, parsed);
|
||||||
|
result.denied = true;
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
HookCommandOutcome::Warn { message } => {
|
||||||
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
|
reporter.on_event(&HookProgressEvent::Completed {
|
||||||
|
event,
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
command: command.clone(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
result.messages.push(message);
|
||||||
|
}
|
||||||
|
HookCommandOutcome::Cancelled { message } => {
|
||||||
|
if let Some(reporter) = reporter.as_deref_mut() {
|
||||||
|
reporter.on_event(&HookProgressEvent::Cancelled {
|
||||||
|
event,
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
command: command.clone(),
|
||||||
|
});
|
||||||
|
}
|
||||||
|
result.cancelled = true;
|
||||||
|
result.messages.push(message);
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
result
|
||||||
|
}
|
||||||
|
|
||||||
|
#[allow(clippy::too_many_arguments)]
|
||||||
|
fn run_command(
|
||||||
|
command: &str,
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: Option<&str>,
|
||||||
|
is_error: bool,
|
||||||
|
payload: &str,
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
) -> HookCommandOutcome {
|
||||||
|
let mut child = shell_command(command);
|
||||||
|
child.stdin(Stdio::piped());
|
||||||
|
child.stdout(Stdio::piped());
|
||||||
|
child.stderr(Stdio::piped());
|
||||||
|
child.env("HOOK_EVENT", event.as_str());
|
||||||
|
child.env("HOOK_TOOL_NAME", tool_name);
|
||||||
|
child.env("HOOK_TOOL_INPUT", tool_input);
|
||||||
|
child.env("HOOK_TOOL_IS_ERROR", if is_error { "1" } else { "0" });
|
||||||
|
if let Some(tool_output) = tool_output {
|
||||||
|
child.env("HOOK_TOOL_OUTPUT", tool_output);
|
||||||
|
}
|
||||||
|
|
||||||
|
match child.output_with_stdin(payload.as_bytes(), abort_signal) {
|
||||||
|
Ok(CommandExecution::Finished(output)) => {
|
||||||
|
let stdout = String::from_utf8_lossy(&output.stdout).trim().to_string();
|
||||||
|
let stderr = String::from_utf8_lossy(&output.stderr).trim().to_string();
|
||||||
|
let parsed = parse_hook_output(&stdout);
|
||||||
|
match output.status.code() {
|
||||||
|
Some(0) => {
|
||||||
|
if parsed.deny {
|
||||||
|
HookCommandOutcome::Deny { parsed }
|
||||||
|
} else {
|
||||||
|
HookCommandOutcome::Allow { parsed }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Some(2) => HookCommandOutcome::Deny {
|
||||||
|
parsed: parsed.with_fallback_message(format!(
|
||||||
|
"{} hook denied tool `{tool_name}`",
|
||||||
|
event.as_str()
|
||||||
|
)),
|
||||||
|
},
|
||||||
|
Some(code) => HookCommandOutcome::Warn {
|
||||||
|
message: format_hook_warning(
|
||||||
|
command,
|
||||||
|
code,
|
||||||
|
parsed.primary_message(),
|
||||||
|
stderr.as_str(),
|
||||||
|
),
|
||||||
|
},
|
||||||
|
None => HookCommandOutcome::Warn {
|
||||||
|
message: format!(
|
||||||
|
"{} hook `{command}` terminated by signal while handling `{tool_name}`",
|
||||||
|
event.as_str()
|
||||||
|
),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
Ok(CommandExecution::Cancelled) => HookCommandOutcome::Cancelled {
|
||||||
|
message: format!(
|
||||||
|
"{} hook `{command}` cancelled while handling `{tool_name}`",
|
||||||
|
event.as_str()
|
||||||
|
),
|
||||||
|
},
|
||||||
|
Err(error) => HookCommandOutcome::Warn {
|
||||||
|
message: format!(
|
||||||
|
"{} hook `{command}` failed to start for `{tool_name}`: {error}",
|
||||||
|
event.as_str()
|
||||||
|
),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
enum HookCommandOutcome {
|
||||||
|
Allow { parsed: ParsedHookOutput },
|
||||||
|
Deny { parsed: ParsedHookOutput },
|
||||||
|
Warn { message: String },
|
||||||
|
Cancelled { message: String },
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
struct ParsedHookOutput {
|
||||||
|
messages: Vec<String>,
|
||||||
|
deny: bool,
|
||||||
|
permission_override: Option<PermissionOverride>,
|
||||||
|
permission_reason: Option<String>,
|
||||||
|
updated_input: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ParsedHookOutput {
|
||||||
|
fn with_fallback_message(mut self, fallback: String) -> Self {
|
||||||
|
if self.messages.is_empty() {
|
||||||
|
self.messages.push(fallback);
|
||||||
|
}
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn primary_message(&self) -> Option<&str> {
|
||||||
|
self.messages.first().map(String::as_str)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn merge_parsed_hook_output(target: &mut HookRunResult, parsed: ParsedHookOutput) {
|
||||||
|
target.messages.extend(parsed.messages);
|
||||||
|
if parsed.permission_override.is_some() {
|
||||||
|
target.permission_override = parsed.permission_override;
|
||||||
|
}
|
||||||
|
if parsed.permission_reason.is_some() {
|
||||||
|
target.permission_reason = parsed.permission_reason;
|
||||||
|
}
|
||||||
|
if parsed.updated_input.is_some() {
|
||||||
|
target.updated_input = parsed.updated_input;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn parse_hook_output(stdout: &str) -> ParsedHookOutput {
|
||||||
|
if stdout.is_empty() {
|
||||||
|
return ParsedHookOutput::default();
|
||||||
|
}
|
||||||
|
|
||||||
|
let Ok(Value::Object(root)) = serde_json::from_str::<Value>(stdout) else {
|
||||||
|
return ParsedHookOutput {
|
||||||
|
messages: vec![stdout.to_string()],
|
||||||
|
..ParsedHookOutput::default()
|
||||||
|
};
|
||||||
|
};
|
||||||
|
|
||||||
|
let mut parsed = ParsedHookOutput::default();
|
||||||
|
|
||||||
|
if let Some(message) = root.get("systemMessage").and_then(Value::as_str) {
|
||||||
|
parsed.messages.push(message.to_string());
|
||||||
|
}
|
||||||
|
if let Some(message) = root.get("reason").and_then(Value::as_str) {
|
||||||
|
parsed.messages.push(message.to_string());
|
||||||
|
}
|
||||||
|
if root.get("continue").and_then(Value::as_bool) == Some(false)
|
||||||
|
|| root.get("decision").and_then(Value::as_str) == Some("block")
|
||||||
|
{
|
||||||
|
parsed.deny = true;
|
||||||
|
}
|
||||||
|
|
||||||
|
if let Some(Value::Object(specific)) = root.get("hookSpecificOutput") {
|
||||||
|
if let Some(Value::String(additional_context)) = specific.get("additionalContext") {
|
||||||
|
parsed.messages.push(additional_context.clone());
|
||||||
|
}
|
||||||
|
if let Some(decision) = specific.get("permissionDecision").and_then(Value::as_str) {
|
||||||
|
parsed.permission_override = match decision {
|
||||||
|
"allow" => Some(PermissionOverride::Allow),
|
||||||
|
"deny" => Some(PermissionOverride::Deny),
|
||||||
|
"ask" => Some(PermissionOverride::Ask),
|
||||||
|
_ => None,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
if let Some(reason) = specific
|
||||||
|
.get("permissionDecisionReason")
|
||||||
|
.and_then(Value::as_str)
|
||||||
|
{
|
||||||
|
parsed.permission_reason = Some(reason.to_string());
|
||||||
|
}
|
||||||
|
if let Some(updated_input) = specific.get("updatedInput") {
|
||||||
|
parsed.updated_input = serde_json::to_string(updated_input).ok();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if parsed.messages.is_empty() {
|
||||||
|
parsed.messages.push(stdout.to_string());
|
||||||
|
}
|
||||||
|
|
||||||
|
parsed
|
||||||
|
}
|
||||||
|
|
||||||
|
fn hook_payload(
|
||||||
|
event: HookEvent,
|
||||||
|
tool_name: &str,
|
||||||
|
tool_input: &str,
|
||||||
|
tool_output: Option<&str>,
|
||||||
|
is_error: bool,
|
||||||
|
) -> Value {
|
||||||
|
match event {
|
||||||
|
HookEvent::PostToolUseFailure => json!({
|
||||||
|
"hook_event_name": event.as_str(),
|
||||||
|
"tool_name": tool_name,
|
||||||
|
"tool_input": parse_tool_input(tool_input),
|
||||||
|
"tool_input_json": tool_input,
|
||||||
|
"tool_error": tool_output,
|
||||||
|
"tool_result_is_error": true,
|
||||||
|
}),
|
||||||
|
_ => json!({
|
||||||
|
"hook_event_name": event.as_str(),
|
||||||
|
"tool_name": tool_name,
|
||||||
|
"tool_input": parse_tool_input(tool_input),
|
||||||
|
"tool_input_json": tool_input,
|
||||||
|
"tool_output": tool_output,
|
||||||
|
"tool_result_is_error": is_error,
|
||||||
|
}),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn parse_tool_input(tool_input: &str) -> Value {
|
||||||
|
serde_json::from_str(tool_input).unwrap_or_else(|_| json!({ "raw": tool_input }))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn format_hook_warning(command: &str, code: i32, stdout: Option<&str>, stderr: &str) -> String {
|
||||||
|
let mut message =
|
||||||
|
format!("Hook `{command}` exited with status {code}; allowing tool execution to continue");
|
||||||
|
if let Some(stdout) = stdout.filter(|stdout| !stdout.is_empty()) {
|
||||||
|
message.push_str(": ");
|
||||||
|
message.push_str(stdout);
|
||||||
|
} else if !stderr.is_empty() {
|
||||||
|
message.push_str(": ");
|
||||||
|
message.push_str(stderr);
|
||||||
|
}
|
||||||
|
message
|
||||||
|
}
|
||||||
|
|
||||||
|
fn shell_command(command: &str) -> CommandWithStdin {
|
||||||
|
#[cfg(windows)]
|
||||||
|
let mut command_builder = {
|
||||||
|
let mut command_builder = Command::new("cmd");
|
||||||
|
command_builder.arg("/C").arg(command);
|
||||||
|
CommandWithStdin::new(command_builder)
|
||||||
|
};
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
let command_builder = {
|
||||||
|
let mut command_builder = Command::new("sh");
|
||||||
|
command_builder.arg("-lc").arg(command);
|
||||||
|
CommandWithStdin::new(command_builder)
|
||||||
|
};
|
||||||
|
|
||||||
|
command_builder
|
||||||
|
}
|
||||||
|
|
||||||
|
struct CommandWithStdin {
|
||||||
|
command: Command,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl CommandWithStdin {
|
||||||
|
fn new(command: Command) -> Self {
|
||||||
|
Self { command }
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stdin(&mut self, cfg: Stdio) -> &mut Self {
|
||||||
|
self.command.stdin(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stdout(&mut self, cfg: Stdio) -> &mut Self {
|
||||||
|
self.command.stdout(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stderr(&mut self, cfg: Stdio) -> &mut Self {
|
||||||
|
self.command.stderr(cfg);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn env<K, V>(&mut self, key: K, value: V) -> &mut Self
|
||||||
|
where
|
||||||
|
K: AsRef<OsStr>,
|
||||||
|
V: AsRef<OsStr>,
|
||||||
|
{
|
||||||
|
self.command.env(key, value);
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
|
fn output_with_stdin(
|
||||||
|
&mut self,
|
||||||
|
stdin: &[u8],
|
||||||
|
abort_signal: Option<&HookAbortSignal>,
|
||||||
|
) -> std::io::Result<CommandExecution> {
|
||||||
|
let mut child = self.command.spawn()?;
|
||||||
|
if let Some(mut child_stdin) = child.stdin.take() {
|
||||||
|
child_stdin.write_all(stdin)?;
|
||||||
|
}
|
||||||
|
|
||||||
|
loop {
|
||||||
|
if abort_signal.is_some_and(HookAbortSignal::is_aborted) {
|
||||||
|
let _ = child.kill();
|
||||||
|
let _ = child.wait_with_output();
|
||||||
|
return Ok(CommandExecution::Cancelled);
|
||||||
|
}
|
||||||
|
|
||||||
|
match child.try_wait()? {
|
||||||
|
Some(_) => return child.wait_with_output().map(CommandExecution::Finished),
|
||||||
|
None => thread::sleep(Duration::from_millis(20)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
enum CommandExecution {
|
||||||
|
Finished(std::process::Output),
|
||||||
|
Cancelled,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(test)]
|
||||||
|
mod tests {
|
||||||
|
use std::thread;
|
||||||
|
use std::time::Duration;
|
||||||
|
|
||||||
|
use super::{
|
||||||
|
HookAbortSignal, HookEvent, HookProgressEvent, HookProgressReporter, HookRunResult,
|
||||||
|
HookRunner,
|
||||||
|
};
|
||||||
|
use crate::config::{RuntimeFeatureConfig, RuntimeHookConfig};
|
||||||
|
use crate::permissions::PermissionOverride;
|
||||||
|
|
||||||
|
struct RecordingReporter {
|
||||||
|
events: Vec<HookProgressEvent>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookProgressReporter for RecordingReporter {
|
||||||
|
fn on_event(&mut self, event: &HookProgressEvent) {
|
||||||
|
self.events.push(event.clone());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn allows_exit_code_zero_and_captures_stdout() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'pre ok'")],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Read", r#"{"path":"README.md"}"#);
|
||||||
|
|
||||||
|
assert_eq!(result, HookRunResult::allow(vec!["pre ok".to_string()]));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn denies_exit_code_two() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'blocked by hook'; exit 2")],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Bash", r#"{"command":"pwd"}"#);
|
||||||
|
|
||||||
|
assert!(result.is_denied());
|
||||||
|
assert_eq!(result.messages(), &["blocked by hook".to_string()]);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn warns_for_other_non_zero_statuses() {
|
||||||
|
let runner = HookRunner::from_feature_config(&RuntimeFeatureConfig::default().with_hooks(
|
||||||
|
RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("printf 'warning hook'; exit 1")],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("Edit", r#"{"file":"src/lib.rs"}"#);
|
||||||
|
|
||||||
|
assert!(!result.is_denied());
|
||||||
|
assert!(result
|
||||||
|
.messages()
|
||||||
|
.iter()
|
||||||
|
.any(|message| message.contains("allowing tool execution to continue")));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn parses_pre_hook_permission_override_and_updated_input() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet(
|
||||||
|
r#"printf '%s' '{"systemMessage":"updated","hookSpecificOutput":{"permissionDecision":"allow","permissionDecisionReason":"hook ok","updatedInput":{"command":"git status"}}}'"#,
|
||||||
|
)],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use("bash", r#"{"command":"pwd"}"#);
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
result.permission_override(),
|
||||||
|
Some(PermissionOverride::Allow)
|
||||||
|
);
|
||||||
|
assert_eq!(result.permission_reason(), Some("hook ok"));
|
||||||
|
assert_eq!(result.updated_input(), Some(r#"{"command":"git status"}"#));
|
||||||
|
assert!(result.messages().iter().any(|message| message == "updated"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn runs_post_tool_use_failure_hooks() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
vec![shell_snippet("printf 'failure hook ran'")],
|
||||||
|
));
|
||||||
|
|
||||||
|
let result =
|
||||||
|
runner.run_post_tool_use_failure("bash", r#"{"command":"false"}"#, "command failed");
|
||||||
|
|
||||||
|
assert!(!result.is_denied());
|
||||||
|
assert_eq!(result.messages(), &["failure hook ran".to_string()]);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn abort_signal_cancels_long_running_hook_and_reports_progress() {
|
||||||
|
let runner = HookRunner::new(RuntimeHookConfig::new(
|
||||||
|
vec![shell_snippet("sleep 5")],
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
));
|
||||||
|
let abort_signal = HookAbortSignal::new();
|
||||||
|
let abort_signal_for_thread = abort_signal.clone();
|
||||||
|
let mut reporter = RecordingReporter { events: Vec::new() };
|
||||||
|
|
||||||
|
thread::spawn(move || {
|
||||||
|
thread::sleep(Duration::from_millis(100));
|
||||||
|
abort_signal_for_thread.abort();
|
||||||
|
});
|
||||||
|
|
||||||
|
let result = runner.run_pre_tool_use_with_context(
|
||||||
|
"bash",
|
||||||
|
r#"{"command":"sleep 5"}"#,
|
||||||
|
Some(&abort_signal),
|
||||||
|
Some(&mut reporter),
|
||||||
|
);
|
||||||
|
|
||||||
|
assert!(result.is_cancelled());
|
||||||
|
assert!(reporter.events.iter().any(|event| matches!(
|
||||||
|
event,
|
||||||
|
HookProgressEvent::Started {
|
||||||
|
event: HookEvent::PreToolUse,
|
||||||
|
..
|
||||||
|
}
|
||||||
|
)));
|
||||||
|
assert!(reporter.events.iter().any(|event| matches!(
|
||||||
|
event,
|
||||||
|
HookProgressEvent::Cancelled {
|
||||||
|
event: HookEvent::PreToolUse,
|
||||||
|
..
|
||||||
|
}
|
||||||
|
)));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(windows)]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.replace('\'', "\"")
|
||||||
|
}
|
||||||
|
|
||||||
|
#[cfg(not(windows))]
|
||||||
|
fn shell_snippet(script: &str) -> String {
|
||||||
|
script.to_string()
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -4,6 +4,7 @@ mod compact;
|
|||||||
mod config;
|
mod config;
|
||||||
mod conversation;
|
mod conversation;
|
||||||
mod file_ops;
|
mod file_ops;
|
||||||
|
mod hooks;
|
||||||
mod json;
|
mod json;
|
||||||
mod mcp;
|
mod mcp;
|
||||||
mod mcp_client;
|
mod mcp_client;
|
||||||
@@ -26,8 +27,8 @@ pub use config::{
|
|||||||
ConfigEntry, ConfigError, ConfigLoader, ConfigSource, McpClaudeAiProxyServerConfig,
|
ConfigEntry, ConfigError, ConfigLoader, ConfigSource, McpClaudeAiProxyServerConfig,
|
||||||
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
McpConfigCollection, McpOAuthConfig, McpRemoteServerConfig, McpSdkServerConfig,
|
||||||
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
McpServerConfig, McpStdioServerConfig, McpTransport, McpWebSocketServerConfig, OAuthConfig,
|
||||||
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, ScopedMcpServerConfig,
|
ResolvedPermissionMode, RuntimeConfig, RuntimeFeatureConfig, RuntimeHookConfig,
|
||||||
CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
RuntimePermissionRuleConfig, ScopedMcpServerConfig, CLAUDE_CODE_SETTINGS_SCHEMA_NAME,
|
||||||
};
|
};
|
||||||
pub use conversation::{
|
pub use conversation::{
|
||||||
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
ApiClient, ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, StaticToolExecutor,
|
||||||
@@ -38,6 +39,9 @@ pub use file_ops::{
|
|||||||
GrepSearchInput, GrepSearchOutput, ReadFileOutput, StructuredPatchHunk, TextFilePayload,
|
GrepSearchInput, GrepSearchOutput, ReadFileOutput, StructuredPatchHunk, TextFilePayload,
|
||||||
WriteFileOutput,
|
WriteFileOutput,
|
||||||
};
|
};
|
||||||
|
pub use hooks::{
|
||||||
|
HookAbortSignal, HookEvent, HookProgressEvent, HookProgressReporter, HookRunResult, HookRunner,
|
||||||
|
};
|
||||||
pub use mcp::{
|
pub use mcp::{
|
||||||
mcp_server_signature, mcp_tool_name, mcp_tool_prefix, normalize_name_for_mcp,
|
mcp_server_signature, mcp_tool_name, mcp_tool_prefix, normalize_name_for_mcp,
|
||||||
scoped_mcp_config_hash, unwrap_ccr_proxy_url,
|
scoped_mcp_config_hash, unwrap_ccr_proxy_url,
|
||||||
@@ -62,8 +66,8 @@ pub use oauth::{
|
|||||||
PkceChallengeMethod, PkceCodePair,
|
PkceChallengeMethod, PkceCodePair,
|
||||||
};
|
};
|
||||||
pub use permissions::{
|
pub use permissions::{
|
||||||
PermissionMode, PermissionOutcome, PermissionPolicy, PermissionPromptDecision,
|
PermissionContext, PermissionMode, PermissionOutcome, PermissionOverride, PermissionPolicy,
|
||||||
PermissionPrompter, PermissionRequest,
|
PermissionPromptDecision, PermissionPrompter, PermissionRequest,
|
||||||
};
|
};
|
||||||
pub use prompt::{
|
pub use prompt::{
|
||||||
load_system_prompt, prepend_bullets, ContextFile, ProjectContext, PromptBuildError,
|
load_system_prompt, prepend_bullets, ContextFile, ProjectContext, PromptBuildError,
|
||||||
|
|||||||
@@ -1,5 +1,9 @@
|
|||||||
use std::collections::BTreeMap;
|
use std::collections::BTreeMap;
|
||||||
|
|
||||||
|
use serde_json::Value;
|
||||||
|
|
||||||
|
use crate::config::RuntimePermissionRuleConfig;
|
||||||
|
|
||||||
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
|
#[derive(Debug, Clone, Copy, PartialEq, Eq, PartialOrd, Ord)]
|
||||||
pub enum PermissionMode {
|
pub enum PermissionMode {
|
||||||
ReadOnly,
|
ReadOnly,
|
||||||
@@ -22,12 +26,49 @@ impl PermissionMode {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
|
||||||
|
pub enum PermissionOverride {
|
||||||
|
Allow,
|
||||||
|
Deny,
|
||||||
|
Ask,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq, Default)]
|
||||||
|
pub struct PermissionContext {
|
||||||
|
override_decision: Option<PermissionOverride>,
|
||||||
|
override_reason: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl PermissionContext {
|
||||||
|
#[must_use]
|
||||||
|
pub fn new(
|
||||||
|
override_decision: Option<PermissionOverride>,
|
||||||
|
override_reason: Option<String>,
|
||||||
|
) -> Self {
|
||||||
|
Self {
|
||||||
|
override_decision,
|
||||||
|
override_reason,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn override_decision(&self) -> Option<PermissionOverride> {
|
||||||
|
self.override_decision
|
||||||
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn override_reason(&self) -> Option<&str> {
|
||||||
|
self.override_reason.as_deref()
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
pub struct PermissionRequest {
|
pub struct PermissionRequest {
|
||||||
pub tool_name: String,
|
pub tool_name: String,
|
||||||
pub input: String,
|
pub input: String,
|
||||||
pub current_mode: PermissionMode,
|
pub current_mode: PermissionMode,
|
||||||
pub required_mode: PermissionMode,
|
pub required_mode: PermissionMode,
|
||||||
|
pub reason: Option<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Clone, PartialEq, Eq)]
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
@@ -50,6 +91,9 @@ pub enum PermissionOutcome {
|
|||||||
pub struct PermissionPolicy {
|
pub struct PermissionPolicy {
|
||||||
active_mode: PermissionMode,
|
active_mode: PermissionMode,
|
||||||
tool_requirements: BTreeMap<String, PermissionMode>,
|
tool_requirements: BTreeMap<String, PermissionMode>,
|
||||||
|
allow_rules: Vec<PermissionRule>,
|
||||||
|
deny_rules: Vec<PermissionRule>,
|
||||||
|
ask_rules: Vec<PermissionRule>,
|
||||||
}
|
}
|
||||||
|
|
||||||
impl PermissionPolicy {
|
impl PermissionPolicy {
|
||||||
@@ -58,6 +102,9 @@ impl PermissionPolicy {
|
|||||||
Self {
|
Self {
|
||||||
active_mode,
|
active_mode,
|
||||||
tool_requirements: BTreeMap::new(),
|
tool_requirements: BTreeMap::new(),
|
||||||
|
allow_rules: Vec::new(),
|
||||||
|
deny_rules: Vec::new(),
|
||||||
|
ask_rules: Vec::new(),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -72,6 +119,26 @@ impl PermissionPolicy {
|
|||||||
self
|
self
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[must_use]
|
||||||
|
pub fn with_permission_rules(mut self, config: &RuntimePermissionRuleConfig) -> Self {
|
||||||
|
self.allow_rules = config
|
||||||
|
.allow()
|
||||||
|
.iter()
|
||||||
|
.map(|rule| PermissionRule::parse(rule))
|
||||||
|
.collect();
|
||||||
|
self.deny_rules = config
|
||||||
|
.deny()
|
||||||
|
.iter()
|
||||||
|
.map(|rule| PermissionRule::parse(rule))
|
||||||
|
.collect();
|
||||||
|
self.ask_rules = config
|
||||||
|
.ask()
|
||||||
|
.iter()
|
||||||
|
.map(|rule| PermissionRule::parse(rule))
|
||||||
|
.collect();
|
||||||
|
self
|
||||||
|
}
|
||||||
|
|
||||||
#[must_use]
|
#[must_use]
|
||||||
pub fn active_mode(&self) -> PermissionMode {
|
pub fn active_mode(&self) -> PermissionMode {
|
||||||
self.active_mode
|
self.active_mode
|
||||||
@@ -90,38 +157,121 @@ impl PermissionPolicy {
|
|||||||
&self,
|
&self,
|
||||||
tool_name: &str,
|
tool_name: &str,
|
||||||
input: &str,
|
input: &str,
|
||||||
mut prompter: Option<&mut dyn PermissionPrompter>,
|
prompter: Option<&mut dyn PermissionPrompter>,
|
||||||
) -> PermissionOutcome {
|
) -> PermissionOutcome {
|
||||||
let current_mode = self.active_mode();
|
self.authorize_with_context(tool_name, input, &PermissionContext::default(), prompter)
|
||||||
let required_mode = self.required_mode_for(tool_name);
|
}
|
||||||
if current_mode == PermissionMode::Allow || current_mode >= required_mode {
|
|
||||||
return PermissionOutcome::Allow;
|
#[must_use]
|
||||||
|
#[allow(clippy::too_many_lines)]
|
||||||
|
pub fn authorize_with_context(
|
||||||
|
&self,
|
||||||
|
tool_name: &str,
|
||||||
|
input: &str,
|
||||||
|
context: &PermissionContext,
|
||||||
|
prompter: Option<&mut dyn PermissionPrompter>,
|
||||||
|
) -> PermissionOutcome {
|
||||||
|
if let Some(rule) = Self::find_matching_rule(&self.deny_rules, tool_name, input) {
|
||||||
|
return PermissionOutcome::Deny {
|
||||||
|
reason: format!(
|
||||||
|
"Permission to use {tool_name} has been denied by rule '{}'",
|
||||||
|
rule.raw
|
||||||
|
),
|
||||||
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
let request = PermissionRequest {
|
let current_mode = self.active_mode();
|
||||||
tool_name: tool_name.to_string(),
|
let required_mode = self.required_mode_for(tool_name);
|
||||||
input: input.to_string(),
|
let ask_rule = Self::find_matching_rule(&self.ask_rules, tool_name, input);
|
||||||
current_mode,
|
let allow_rule = Self::find_matching_rule(&self.allow_rules, tool_name, input);
|
||||||
required_mode,
|
|
||||||
};
|
match context.override_decision() {
|
||||||
|
Some(PermissionOverride::Deny) => {
|
||||||
|
return PermissionOutcome::Deny {
|
||||||
|
reason: context.override_reason().map_or_else(
|
||||||
|
|| format!("tool '{tool_name}' denied by hook"),
|
||||||
|
ToOwned::to_owned,
|
||||||
|
),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
Some(PermissionOverride::Ask) => {
|
||||||
|
let reason = context.override_reason().map_or_else(
|
||||||
|
|| format!("tool '{tool_name}' requires approval due to hook guidance"),
|
||||||
|
ToOwned::to_owned,
|
||||||
|
);
|
||||||
|
return Self::prompt_or_deny(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
current_mode,
|
||||||
|
required_mode,
|
||||||
|
Some(reason),
|
||||||
|
prompter,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
Some(PermissionOverride::Allow) => {
|
||||||
|
if let Some(rule) = ask_rule {
|
||||||
|
let reason = format!(
|
||||||
|
"tool '{tool_name}' requires approval due to ask rule '{}'",
|
||||||
|
rule.raw
|
||||||
|
);
|
||||||
|
return Self::prompt_or_deny(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
current_mode,
|
||||||
|
required_mode,
|
||||||
|
Some(reason),
|
||||||
|
prompter,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
if allow_rule.is_some()
|
||||||
|
|| current_mode == PermissionMode::Allow
|
||||||
|
|| current_mode >= required_mode
|
||||||
|
{
|
||||||
|
return PermissionOutcome::Allow;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
None => {}
|
||||||
|
}
|
||||||
|
|
||||||
|
if let Some(rule) = ask_rule {
|
||||||
|
let reason = format!(
|
||||||
|
"tool '{tool_name}' requires approval due to ask rule '{}'",
|
||||||
|
rule.raw
|
||||||
|
);
|
||||||
|
return Self::prompt_or_deny(
|
||||||
|
tool_name,
|
||||||
|
input,
|
||||||
|
current_mode,
|
||||||
|
required_mode,
|
||||||
|
Some(reason),
|
||||||
|
prompter,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
if allow_rule.is_some()
|
||||||
|
|| current_mode == PermissionMode::Allow
|
||||||
|
|| current_mode >= required_mode
|
||||||
|
{
|
||||||
|
return PermissionOutcome::Allow;
|
||||||
|
}
|
||||||
|
|
||||||
if current_mode == PermissionMode::Prompt
|
if current_mode == PermissionMode::Prompt
|
||||||
|| (current_mode == PermissionMode::WorkspaceWrite
|
|| (current_mode == PermissionMode::WorkspaceWrite
|
||||||
&& required_mode == PermissionMode::DangerFullAccess)
|
&& required_mode == PermissionMode::DangerFullAccess)
|
||||||
{
|
{
|
||||||
return match prompter.as_mut() {
|
let reason = Some(format!(
|
||||||
Some(prompter) => match prompter.decide(&request) {
|
"tool '{tool_name}' requires approval to escalate from {} to {}",
|
||||||
PermissionPromptDecision::Allow => PermissionOutcome::Allow,
|
current_mode.as_str(),
|
||||||
PermissionPromptDecision::Deny { reason } => PermissionOutcome::Deny { reason },
|
required_mode.as_str()
|
||||||
},
|
));
|
||||||
None => PermissionOutcome::Deny {
|
return Self::prompt_or_deny(
|
||||||
reason: format!(
|
tool_name,
|
||||||
"tool '{tool_name}' requires approval to escalate from {} to {}",
|
input,
|
||||||
current_mode.as_str(),
|
current_mode,
|
||||||
required_mode.as_str()
|
required_mode,
|
||||||
),
|
reason,
|
||||||
},
|
prompter,
|
||||||
};
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
PermissionOutcome::Deny {
|
PermissionOutcome::Deny {
|
||||||
@@ -132,14 +282,191 @@ impl PermissionPolicy {
|
|||||||
),
|
),
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn prompt_or_deny(
|
||||||
|
tool_name: &str,
|
||||||
|
input: &str,
|
||||||
|
current_mode: PermissionMode,
|
||||||
|
required_mode: PermissionMode,
|
||||||
|
reason: Option<String>,
|
||||||
|
mut prompter: Option<&mut dyn PermissionPrompter>,
|
||||||
|
) -> PermissionOutcome {
|
||||||
|
let request = PermissionRequest {
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
input: input.to_string(),
|
||||||
|
current_mode,
|
||||||
|
required_mode,
|
||||||
|
reason: reason.clone(),
|
||||||
|
};
|
||||||
|
|
||||||
|
match prompter.as_mut() {
|
||||||
|
Some(prompter) => match prompter.decide(&request) {
|
||||||
|
PermissionPromptDecision::Allow => PermissionOutcome::Allow,
|
||||||
|
PermissionPromptDecision::Deny { reason } => PermissionOutcome::Deny { reason },
|
||||||
|
},
|
||||||
|
None => PermissionOutcome::Deny {
|
||||||
|
reason: reason.unwrap_or_else(|| {
|
||||||
|
format!(
|
||||||
|
"tool '{tool_name}' requires approval to run while mode is {}",
|
||||||
|
current_mode.as_str()
|
||||||
|
)
|
||||||
|
}),
|
||||||
|
},
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn find_matching_rule<'a>(
|
||||||
|
rules: &'a [PermissionRule],
|
||||||
|
tool_name: &str,
|
||||||
|
input: &str,
|
||||||
|
) -> Option<&'a PermissionRule> {
|
||||||
|
rules.iter().find(|rule| rule.matches(tool_name, input))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
struct PermissionRule {
|
||||||
|
raw: String,
|
||||||
|
tool_name: String,
|
||||||
|
matcher: PermissionRuleMatcher,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone, PartialEq, Eq)]
|
||||||
|
enum PermissionRuleMatcher {
|
||||||
|
Any,
|
||||||
|
Exact(String),
|
||||||
|
Prefix(String),
|
||||||
|
}
|
||||||
|
|
||||||
|
impl PermissionRule {
|
||||||
|
fn parse(raw: &str) -> Self {
|
||||||
|
let trimmed = raw.trim();
|
||||||
|
let open = find_first_unescaped(trimmed, '(');
|
||||||
|
let close = find_last_unescaped(trimmed, ')');
|
||||||
|
|
||||||
|
if let (Some(open), Some(close)) = (open, close) {
|
||||||
|
if close == trimmed.len() - 1 && open < close {
|
||||||
|
let tool_name = trimmed[..open].trim();
|
||||||
|
let content = &trimmed[open + 1..close];
|
||||||
|
if !tool_name.is_empty() {
|
||||||
|
let matcher = parse_rule_matcher(content);
|
||||||
|
return Self {
|
||||||
|
raw: trimmed.to_string(),
|
||||||
|
tool_name: tool_name.to_string(),
|
||||||
|
matcher,
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
Self {
|
||||||
|
raw: trimmed.to_string(),
|
||||||
|
tool_name: trimmed.to_string(),
|
||||||
|
matcher: PermissionRuleMatcher::Any,
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn matches(&self, tool_name: &str, input: &str) -> bool {
|
||||||
|
if self.tool_name != tool_name {
|
||||||
|
return false;
|
||||||
|
}
|
||||||
|
|
||||||
|
match &self.matcher {
|
||||||
|
PermissionRuleMatcher::Any => true,
|
||||||
|
PermissionRuleMatcher::Exact(expected) => {
|
||||||
|
extract_permission_subject(input).is_some_and(|candidate| candidate == *expected)
|
||||||
|
}
|
||||||
|
PermissionRuleMatcher::Prefix(prefix) => extract_permission_subject(input)
|
||||||
|
.is_some_and(|candidate| candidate.starts_with(prefix)),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn parse_rule_matcher(content: &str) -> PermissionRuleMatcher {
|
||||||
|
let unescaped = unescape_rule_content(content.trim());
|
||||||
|
if unescaped.is_empty() || unescaped == "*" {
|
||||||
|
PermissionRuleMatcher::Any
|
||||||
|
} else if let Some(prefix) = unescaped.strip_suffix(":*") {
|
||||||
|
PermissionRuleMatcher::Prefix(prefix.to_string())
|
||||||
|
} else {
|
||||||
|
PermissionRuleMatcher::Exact(unescaped)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn unescape_rule_content(content: &str) -> String {
|
||||||
|
content
|
||||||
|
.replace(r"\(", "(")
|
||||||
|
.replace(r"\)", ")")
|
||||||
|
.replace(r"\\", r"\")
|
||||||
|
}
|
||||||
|
|
||||||
|
fn find_first_unescaped(value: &str, needle: char) -> Option<usize> {
|
||||||
|
let mut escaped = false;
|
||||||
|
for (idx, ch) in value.char_indices() {
|
||||||
|
if ch == '\\' {
|
||||||
|
escaped = !escaped;
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
if ch == needle && !escaped {
|
||||||
|
return Some(idx);
|
||||||
|
}
|
||||||
|
escaped = false;
|
||||||
|
}
|
||||||
|
None
|
||||||
|
}
|
||||||
|
|
||||||
|
fn find_last_unescaped(value: &str, needle: char) -> Option<usize> {
|
||||||
|
let chars = value.char_indices().collect::<Vec<_>>();
|
||||||
|
for (pos, (idx, ch)) in chars.iter().enumerate().rev() {
|
||||||
|
if *ch != needle {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
|
let mut backslashes = 0;
|
||||||
|
for (_, prev) in chars[..pos].iter().rev() {
|
||||||
|
if *prev == '\\' {
|
||||||
|
backslashes += 1;
|
||||||
|
} else {
|
||||||
|
break;
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if backslashes % 2 == 0 {
|
||||||
|
return Some(*idx);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
None
|
||||||
|
}
|
||||||
|
|
||||||
|
fn extract_permission_subject(input: &str) -> Option<String> {
|
||||||
|
let parsed = serde_json::from_str::<Value>(input).ok();
|
||||||
|
if let Some(Value::Object(object)) = parsed {
|
||||||
|
for key in [
|
||||||
|
"command",
|
||||||
|
"path",
|
||||||
|
"file_path",
|
||||||
|
"filePath",
|
||||||
|
"notebook_path",
|
||||||
|
"notebookPath",
|
||||||
|
"url",
|
||||||
|
"pattern",
|
||||||
|
"code",
|
||||||
|
"message",
|
||||||
|
] {
|
||||||
|
if let Some(value) = object.get(key).and_then(Value::as_str) {
|
||||||
|
return Some(value.to_string());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
(!input.trim().is_empty()).then(|| input.to_string())
|
||||||
}
|
}
|
||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
use super::{
|
use super::{
|
||||||
PermissionMode, PermissionOutcome, PermissionPolicy, PermissionPromptDecision,
|
PermissionContext, PermissionMode, PermissionOutcome, PermissionOverride, PermissionPolicy,
|
||||||
PermissionPrompter, PermissionRequest,
|
PermissionPromptDecision, PermissionPrompter, PermissionRequest,
|
||||||
};
|
};
|
||||||
|
use crate::config::RuntimePermissionRuleConfig;
|
||||||
|
|
||||||
struct RecordingPrompter {
|
struct RecordingPrompter {
|
||||||
seen: Vec<PermissionRequest>,
|
seen: Vec<PermissionRequest>,
|
||||||
@@ -229,4 +556,120 @@ mod tests {
|
|||||||
PermissionOutcome::Deny { reason } if reason == "not now"
|
PermissionOutcome::Deny { reason } if reason == "not now"
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn applies_rule_based_denials_and_allows() {
|
||||||
|
let rules = RuntimePermissionRuleConfig::new(
|
||||||
|
vec!["bash(git:*)".to_string()],
|
||||||
|
vec!["bash(rm -rf:*)".to_string()],
|
||||||
|
Vec::new(),
|
||||||
|
);
|
||||||
|
let policy = PermissionPolicy::new(PermissionMode::ReadOnly)
|
||||||
|
.with_tool_requirement("bash", PermissionMode::DangerFullAccess)
|
||||||
|
.with_permission_rules(&rules);
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
policy.authorize("bash", r#"{"command":"git status"}"#, None),
|
||||||
|
PermissionOutcome::Allow
|
||||||
|
);
|
||||||
|
assert!(matches!(
|
||||||
|
policy.authorize("bash", r#"{"command":"rm -rf /tmp/x"}"#, None),
|
||||||
|
PermissionOutcome::Deny { reason } if reason.contains("denied by rule")
|
||||||
|
));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn ask_rules_force_prompt_even_when_mode_allows() {
|
||||||
|
let rules = RuntimePermissionRuleConfig::new(
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
vec!["bash(git:*)".to_string()],
|
||||||
|
);
|
||||||
|
let policy = PermissionPolicy::new(PermissionMode::DangerFullAccess)
|
||||||
|
.with_tool_requirement("bash", PermissionMode::DangerFullAccess)
|
||||||
|
.with_permission_rules(&rules);
|
||||||
|
let mut prompter = RecordingPrompter {
|
||||||
|
seen: Vec::new(),
|
||||||
|
allow: true,
|
||||||
|
};
|
||||||
|
|
||||||
|
let outcome = policy.authorize("bash", r#"{"command":"git status"}"#, Some(&mut prompter));
|
||||||
|
|
||||||
|
assert_eq!(outcome, PermissionOutcome::Allow);
|
||||||
|
assert_eq!(prompter.seen.len(), 1);
|
||||||
|
assert!(prompter.seen[0]
|
||||||
|
.reason
|
||||||
|
.as_deref()
|
||||||
|
.is_some_and(|reason| reason.contains("ask rule")));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hook_allow_still_respects_ask_rules() {
|
||||||
|
let rules = RuntimePermissionRuleConfig::new(
|
||||||
|
Vec::new(),
|
||||||
|
Vec::new(),
|
||||||
|
vec!["bash(git:*)".to_string()],
|
||||||
|
);
|
||||||
|
let policy = PermissionPolicy::new(PermissionMode::ReadOnly)
|
||||||
|
.with_tool_requirement("bash", PermissionMode::DangerFullAccess)
|
||||||
|
.with_permission_rules(&rules);
|
||||||
|
let context = PermissionContext::new(
|
||||||
|
Some(PermissionOverride::Allow),
|
||||||
|
Some("hook approved".to_string()),
|
||||||
|
);
|
||||||
|
let mut prompter = RecordingPrompter {
|
||||||
|
seen: Vec::new(),
|
||||||
|
allow: true,
|
||||||
|
};
|
||||||
|
|
||||||
|
let outcome = policy.authorize_with_context(
|
||||||
|
"bash",
|
||||||
|
r#"{"command":"git status"}"#,
|
||||||
|
&context,
|
||||||
|
Some(&mut prompter),
|
||||||
|
);
|
||||||
|
|
||||||
|
assert_eq!(outcome, PermissionOutcome::Allow);
|
||||||
|
assert_eq!(prompter.seen.len(), 1);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hook_deny_short_circuits_permission_flow() {
|
||||||
|
let policy = PermissionPolicy::new(PermissionMode::DangerFullAccess)
|
||||||
|
.with_tool_requirement("bash", PermissionMode::DangerFullAccess);
|
||||||
|
let context = PermissionContext::new(
|
||||||
|
Some(PermissionOverride::Deny),
|
||||||
|
Some("blocked by hook".to_string()),
|
||||||
|
);
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
policy.authorize_with_context("bash", "{}", &context, None),
|
||||||
|
PermissionOutcome::Deny {
|
||||||
|
reason: "blocked by hook".to_string(),
|
||||||
|
}
|
||||||
|
);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hook_ask_forces_prompt() {
|
||||||
|
let policy = PermissionPolicy::new(PermissionMode::DangerFullAccess)
|
||||||
|
.with_tool_requirement("bash", PermissionMode::DangerFullAccess);
|
||||||
|
let context = PermissionContext::new(
|
||||||
|
Some(PermissionOverride::Ask),
|
||||||
|
Some("hook requested confirmation".to_string()),
|
||||||
|
);
|
||||||
|
let mut prompter = RecordingPrompter {
|
||||||
|
seen: Vec::new(),
|
||||||
|
allow: true,
|
||||||
|
};
|
||||||
|
|
||||||
|
let outcome = policy.authorize_with_context("bash", "{}", &context, Some(&mut prompter));
|
||||||
|
|
||||||
|
assert_eq!(outcome, PermissionOutcome::Allow);
|
||||||
|
assert_eq!(prompter.seen.len(), 1);
|
||||||
|
assert_eq!(
|
||||||
|
prompter.seen[0].reason.as_deref(),
|
||||||
|
Some("hook requested confirmation")
|
||||||
|
);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -19,7 +19,7 @@ rustyline = "15"
|
|||||||
runtime = { path = "../runtime" }
|
runtime = { path = "../runtime" }
|
||||||
serde_json = "1"
|
serde_json = "1"
|
||||||
syntect = "5"
|
syntect = "5"
|
||||||
tokio = { version = "1", features = ["rt-multi-thread", "time"] }
|
tokio = { version = "1", features = ["rt-multi-thread", "signal", "time"] }
|
||||||
tools = { path = "../tools" }
|
tools = { path = "../tools" }
|
||||||
|
|
||||||
[lints]
|
[lints]
|
||||||
|
|||||||
@@ -9,6 +9,8 @@ use std::io::{self, Read, Write};
|
|||||||
use std::net::TcpListener;
|
use std::net::TcpListener;
|
||||||
use std::path::{Path, PathBuf};
|
use std::path::{Path, PathBuf};
|
||||||
use std::process::Command;
|
use std::process::Command;
|
||||||
|
use std::sync::mpsc::{self, Receiver, Sender};
|
||||||
|
use std::thread::{self, JoinHandle};
|
||||||
use std::time::{SystemTime, UNIX_EPOCH};
|
use std::time::{SystemTime, UNIX_EPOCH};
|
||||||
|
|
||||||
use api::{
|
use api::{
|
||||||
@@ -27,7 +29,7 @@ use runtime::{
|
|||||||
clear_oauth_credentials, generate_pkce_pair, generate_state, load_system_prompt,
|
clear_oauth_credentials, generate_pkce_pair, generate_state, load_system_prompt,
|
||||||
parse_oauth_callback_request_target, save_oauth_credentials, ApiClient, ApiRequest,
|
parse_oauth_callback_request_target, save_oauth_credentials, ApiClient, ApiRequest,
|
||||||
AssistantEvent, CompactionConfig, ConfigLoader, ConfigSource, ContentBlock,
|
AssistantEvent, CompactionConfig, ConfigLoader, ConfigSource, ContentBlock,
|
||||||
ConversationMessage, ConversationRuntime, MessageRole, OAuthAuthorizationRequest,
|
ConversationMessage, ConversationRuntime, MessageRole, OAuthAuthorizationRequest, OAuthConfig,
|
||||||
OAuthTokenExchangeRequest, PermissionMode, PermissionPolicy, ProjectContext, RuntimeError,
|
OAuthTokenExchangeRequest, PermissionMode, PermissionPolicy, ProjectContext, RuntimeError,
|
||||||
Session, TokenUsage, ToolError, ToolExecutor, UsageTracker,
|
Session, TokenUsage, ToolError, ToolExecutor, UsageTracker,
|
||||||
};
|
};
|
||||||
@@ -196,6 +198,25 @@ fn parse_args(args: &[String]) -> Result<CliAction, String> {
|
|||||||
permission_mode = PermissionMode::DangerFullAccess;
|
permission_mode = PermissionMode::DangerFullAccess;
|
||||||
index += 1;
|
index += 1;
|
||||||
}
|
}
|
||||||
|
"-p" => {
|
||||||
|
// Claude Code compat: -p "prompt" = one-shot prompt
|
||||||
|
let prompt = args[index + 1..].join(" ");
|
||||||
|
if prompt.trim().is_empty() {
|
||||||
|
return Err("-p requires a prompt string".to_string());
|
||||||
|
}
|
||||||
|
return Ok(CliAction::Prompt {
|
||||||
|
prompt,
|
||||||
|
model: resolve_model_alias(&model).to_string(),
|
||||||
|
output_format,
|
||||||
|
allowed_tools: normalize_allowed_tools(&allowed_tool_values)?,
|
||||||
|
permission_mode,
|
||||||
|
});
|
||||||
|
}
|
||||||
|
"--print" => {
|
||||||
|
// Claude Code compat: --print makes output non-interactive
|
||||||
|
output_format = CliOutputFormat::Text;
|
||||||
|
index += 1;
|
||||||
|
}
|
||||||
"--allowedTools" | "--allowed-tools" => {
|
"--allowedTools" | "--allowed-tools" => {
|
||||||
let value = args
|
let value = args
|
||||||
.get(index + 1)
|
.get(index + 1)
|
||||||
@@ -428,15 +449,26 @@ fn print_bootstrap_plan() {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn default_oauth_config() -> OAuthConfig {
|
||||||
|
OAuthConfig {
|
||||||
|
client_id: String::from("9d1c250a-e61b-44d9-88ed-5944d1962f5e"),
|
||||||
|
authorize_url: String::from("https://platform.claude.com/oauth/authorize"),
|
||||||
|
token_url: String::from("https://platform.claude.com/v1/oauth/token"),
|
||||||
|
callback_port: None,
|
||||||
|
manual_redirect_url: None,
|
||||||
|
scopes: vec![
|
||||||
|
String::from("user:profile"),
|
||||||
|
String::from("user:inference"),
|
||||||
|
String::from("user:sessions:claude_code"),
|
||||||
|
],
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
fn run_login() -> Result<(), Box<dyn std::error::Error>> {
|
fn run_login() -> Result<(), Box<dyn std::error::Error>> {
|
||||||
let cwd = env::current_dir()?;
|
let cwd = env::current_dir()?;
|
||||||
let config = ConfigLoader::default_for(&cwd).load()?;
|
let config = ConfigLoader::default_for(&cwd).load()?;
|
||||||
let oauth = config.oauth().ok_or_else(|| {
|
let default_oauth = default_oauth_config();
|
||||||
io::Error::new(
|
let oauth = config.oauth().unwrap_or(&default_oauth);
|
||||||
io::ErrorKind::NotFound,
|
|
||||||
"OAuth config is missing. Add settings.oauth.clientId/authorizeUrl/tokenUrl first.",
|
|
||||||
)
|
|
||||||
})?;
|
|
||||||
let callback_port = oauth.callback_port.unwrap_or(DEFAULT_OAUTH_CALLBACK_PORT);
|
let callback_port = oauth.callback_port.unwrap_or(DEFAULT_OAUTH_CALLBACK_PORT);
|
||||||
let redirect_uri = runtime::loopback_redirect_uri(callback_port);
|
let redirect_uri = runtime::loopback_redirect_uri(callback_port);
|
||||||
let pkce = generate_pkce_pair()?;
|
let pkce = generate_pkce_pair()?;
|
||||||
@@ -954,6 +986,61 @@ struct LiveCli {
|
|||||||
session: SessionHandle,
|
session: SessionHandle,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
struct HookAbortMonitor {
|
||||||
|
stop_tx: Option<Sender<()>>,
|
||||||
|
join_handle: Option<JoinHandle<()>>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl HookAbortMonitor {
|
||||||
|
fn spawn(abort_signal: runtime::HookAbortSignal) -> Self {
|
||||||
|
Self::spawn_with_waiter(abort_signal, move |stop_rx, abort_signal| {
|
||||||
|
let Ok(runtime) = tokio::runtime::Builder::new_current_thread()
|
||||||
|
.enable_all()
|
||||||
|
.build()
|
||||||
|
else {
|
||||||
|
return;
|
||||||
|
};
|
||||||
|
|
||||||
|
runtime.block_on(async move {
|
||||||
|
let wait_for_stop = tokio::task::spawn_blocking(move || {
|
||||||
|
let _ = stop_rx.recv();
|
||||||
|
});
|
||||||
|
|
||||||
|
tokio::select! {
|
||||||
|
result = tokio::signal::ctrl_c() => {
|
||||||
|
if result.is_ok() {
|
||||||
|
abort_signal.abort();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
_ = wait_for_stop => {}
|
||||||
|
}
|
||||||
|
});
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
fn spawn_with_waiter<F>(abort_signal: runtime::HookAbortSignal, wait_for_interrupt: F) -> Self
|
||||||
|
where
|
||||||
|
F: FnOnce(Receiver<()>, runtime::HookAbortSignal) + Send + 'static,
|
||||||
|
{
|
||||||
|
let (stop_tx, stop_rx) = mpsc::channel();
|
||||||
|
let join_handle = thread::spawn(move || wait_for_interrupt(stop_rx, abort_signal));
|
||||||
|
|
||||||
|
Self {
|
||||||
|
stop_tx: Some(stop_tx),
|
||||||
|
join_handle: Some(join_handle),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn stop(mut self) {
|
||||||
|
if let Some(stop_tx) = self.stop_tx.take() {
|
||||||
|
let _ = stop_tx.send(());
|
||||||
|
}
|
||||||
|
if let Some(join_handle) = self.join_handle.take() {
|
||||||
|
let _ = join_handle.join();
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
impl LiveCli {
|
impl LiveCli {
|
||||||
fn new(
|
fn new(
|
||||||
model: String,
|
model: String,
|
||||||
@@ -1009,7 +1096,34 @@ impl LiveCli {
|
|||||||
)
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn prepare_turn_runtime(
|
||||||
|
&self,
|
||||||
|
emit_output: bool,
|
||||||
|
) -> Result<
|
||||||
|
(
|
||||||
|
ConversationRuntime<AnthropicRuntimeClient, CliToolExecutor>,
|
||||||
|
HookAbortMonitor,
|
||||||
|
),
|
||||||
|
Box<dyn std::error::Error>,
|
||||||
|
> {
|
||||||
|
let hook_abort_signal = runtime::HookAbortSignal::new();
|
||||||
|
let runtime = build_runtime(
|
||||||
|
self.runtime.session().clone(),
|
||||||
|
self.model.clone(),
|
||||||
|
self.system_prompt.clone(),
|
||||||
|
true,
|
||||||
|
emit_output,
|
||||||
|
self.allowed_tools.clone(),
|
||||||
|
self.permission_mode,
|
||||||
|
)?
|
||||||
|
.with_hook_abort_signal(hook_abort_signal.clone());
|
||||||
|
let hook_abort_monitor = HookAbortMonitor::spawn(hook_abort_signal);
|
||||||
|
|
||||||
|
Ok((runtime, hook_abort_monitor))
|
||||||
|
}
|
||||||
|
|
||||||
fn run_turn(&mut self, input: &str) -> Result<(), Box<dyn std::error::Error>> {
|
fn run_turn(&mut self, input: &str) -> Result<(), Box<dyn std::error::Error>> {
|
||||||
|
let (mut runtime, hook_abort_monitor) = self.prepare_turn_runtime(true)?;
|
||||||
let mut spinner = Spinner::new();
|
let mut spinner = Spinner::new();
|
||||||
let mut stdout = io::stdout();
|
let mut stdout = io::stdout();
|
||||||
spinner.tick(
|
spinner.tick(
|
||||||
@@ -1018,7 +1132,9 @@ impl LiveCli {
|
|||||||
&mut stdout,
|
&mut stdout,
|
||||||
)?;
|
)?;
|
||||||
let mut permission_prompter = CliPermissionPrompter::new(self.permission_mode);
|
let mut permission_prompter = CliPermissionPrompter::new(self.permission_mode);
|
||||||
let result = self.runtime.run_turn(input, Some(&mut permission_prompter));
|
let result = runtime.run_turn(input, Some(&mut permission_prompter));
|
||||||
|
hook_abort_monitor.stop();
|
||||||
|
self.runtime = runtime;
|
||||||
match result {
|
match result {
|
||||||
Ok(_) => {
|
Ok(_) => {
|
||||||
spinner.finish(
|
spinner.finish(
|
||||||
@@ -1053,18 +1169,11 @@ impl LiveCli {
|
|||||||
}
|
}
|
||||||
|
|
||||||
fn run_prompt_json(&mut self, input: &str) -> Result<(), Box<dyn std::error::Error>> {
|
fn run_prompt_json(&mut self, input: &str) -> Result<(), Box<dyn std::error::Error>> {
|
||||||
let session = self.runtime.session().clone();
|
let (mut runtime, hook_abort_monitor) = self.prepare_turn_runtime(false)?;
|
||||||
let mut runtime = build_runtime(
|
|
||||||
session,
|
|
||||||
self.model.clone(),
|
|
||||||
self.system_prompt.clone(),
|
|
||||||
true,
|
|
||||||
false,
|
|
||||||
self.allowed_tools.clone(),
|
|
||||||
self.permission_mode,
|
|
||||||
)?;
|
|
||||||
let mut permission_prompter = CliPermissionPrompter::new(self.permission_mode);
|
let mut permission_prompter = CliPermissionPrompter::new(self.permission_mode);
|
||||||
let summary = runtime.run_turn(input, Some(&mut permission_prompter))?;
|
let result = runtime.run_turn(input, Some(&mut permission_prompter));
|
||||||
|
hook_abort_monitor.stop();
|
||||||
|
let summary = result?;
|
||||||
self.runtime = runtime;
|
self.runtime = runtime;
|
||||||
self.persist_session()?;
|
self.persist_session()?;
|
||||||
println!(
|
println!(
|
||||||
@@ -1873,6 +1982,15 @@ fn build_system_prompt() -> Result<Vec<String>, Box<dyn std::error::Error>> {
|
|||||||
)?)
|
)?)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn build_runtime_feature_config(
|
||||||
|
) -> Result<runtime::RuntimeFeatureConfig, Box<dyn std::error::Error>> {
|
||||||
|
let cwd = env::current_dir()?;
|
||||||
|
Ok(ConfigLoader::default_for(cwd)
|
||||||
|
.load()?
|
||||||
|
.feature_config()
|
||||||
|
.clone())
|
||||||
|
}
|
||||||
|
|
||||||
fn build_runtime(
|
fn build_runtime(
|
||||||
session: Session,
|
session: Session,
|
||||||
model: String,
|
model: String,
|
||||||
@@ -1883,13 +2001,52 @@ fn build_runtime(
|
|||||||
permission_mode: PermissionMode,
|
permission_mode: PermissionMode,
|
||||||
) -> Result<ConversationRuntime<AnthropicRuntimeClient, CliToolExecutor>, Box<dyn std::error::Error>>
|
) -> Result<ConversationRuntime<AnthropicRuntimeClient, CliToolExecutor>, Box<dyn std::error::Error>>
|
||||||
{
|
{
|
||||||
Ok(ConversationRuntime::new(
|
let feature_config = build_runtime_feature_config()?;
|
||||||
|
let mut runtime = ConversationRuntime::new_with_features(
|
||||||
session,
|
session,
|
||||||
AnthropicRuntimeClient::new(model, enable_tools, emit_output, allowed_tools.clone())?,
|
AnthropicRuntimeClient::new(model, enable_tools, emit_output, allowed_tools.clone())?,
|
||||||
CliToolExecutor::new(allowed_tools, emit_output),
|
CliToolExecutor::new(allowed_tools, emit_output),
|
||||||
permission_policy(permission_mode),
|
permission_policy(permission_mode, &feature_config),
|
||||||
system_prompt,
|
system_prompt,
|
||||||
))
|
feature_config,
|
||||||
|
);
|
||||||
|
if emit_output {
|
||||||
|
runtime = runtime.with_hook_progress_reporter(Box::new(CliHookProgressReporter));
|
||||||
|
}
|
||||||
|
Ok(runtime)
|
||||||
|
}
|
||||||
|
|
||||||
|
struct CliHookProgressReporter;
|
||||||
|
|
||||||
|
impl runtime::HookProgressReporter for CliHookProgressReporter {
|
||||||
|
fn on_event(&mut self, event: &runtime::HookProgressEvent) {
|
||||||
|
match event {
|
||||||
|
runtime::HookProgressEvent::Started {
|
||||||
|
event,
|
||||||
|
tool_name,
|
||||||
|
command,
|
||||||
|
} => eprintln!(
|
||||||
|
"[hook {event_name}] {tool_name}: {command}",
|
||||||
|
event_name = event.as_str()
|
||||||
|
),
|
||||||
|
runtime::HookProgressEvent::Completed {
|
||||||
|
event,
|
||||||
|
tool_name,
|
||||||
|
command,
|
||||||
|
} => eprintln!(
|
||||||
|
"[hook done {event_name}] {tool_name}: {command}",
|
||||||
|
event_name = event.as_str()
|
||||||
|
),
|
||||||
|
runtime::HookProgressEvent::Cancelled {
|
||||||
|
event,
|
||||||
|
tool_name,
|
||||||
|
command,
|
||||||
|
} => eprintln!(
|
||||||
|
"[hook cancelled {event_name}] {tool_name}: {command}",
|
||||||
|
event_name = event.as_str()
|
||||||
|
),
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
struct CliPermissionPrompter {
|
struct CliPermissionPrompter {
|
||||||
@@ -1912,6 +2069,9 @@ impl runtime::PermissionPrompter for CliPermissionPrompter {
|
|||||||
println!(" Tool {}", request.tool_name);
|
println!(" Tool {}", request.tool_name);
|
||||||
println!(" Current mode {}", self.current_mode.as_str());
|
println!(" Current mode {}", self.current_mode.as_str());
|
||||||
println!(" Required mode {}", request.required_mode.as_str());
|
println!(" Required mode {}", request.required_mode.as_str());
|
||||||
|
if let Some(reason) = &request.reason {
|
||||||
|
println!(" Reason {reason}");
|
||||||
|
}
|
||||||
println!(" Input {}", request.input);
|
println!(" Input {}", request.input);
|
||||||
print!("Approve this tool call? [y/N]: ");
|
print!("Approve this tool call? [y/N]: ");
|
||||||
let _ = io::stdout().flush();
|
let _ = io::stdout().flush();
|
||||||
@@ -2324,13 +2484,15 @@ fn format_bash_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
.get("backgroundTaskId")
|
.get("backgroundTaskId")
|
||||||
.and_then(|value| value.as_str())
|
.and_then(|value| value.as_str())
|
||||||
{
|
{
|
||||||
lines[0].push_str(&format!(" backgrounded ({task_id})"));
|
use std::fmt::Write as _;
|
||||||
|
let _ = write!(lines[0], " backgrounded ({task_id})");
|
||||||
} else if let Some(status) = parsed
|
} else if let Some(status) = parsed
|
||||||
.get("returnCodeInterpretation")
|
.get("returnCodeInterpretation")
|
||||||
.and_then(|value| value.as_str())
|
.and_then(|value| value.as_str())
|
||||||
.filter(|status| !status.is_empty())
|
.filter(|status| !status.is_empty())
|
||||||
{
|
{
|
||||||
lines[0].push_str(&format!(" {status}"));
|
use std::fmt::Write as _;
|
||||||
|
let _ = write!(lines[0], " {status}");
|
||||||
}
|
}
|
||||||
|
|
||||||
if let Some(stdout) = parsed.get("stdout").and_then(|value| value.as_str()) {
|
if let Some(stdout) = parsed.get("stdout").and_then(|value| value.as_str()) {
|
||||||
@@ -2352,15 +2514,15 @@ fn format_read_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
let path = extract_tool_path(file);
|
let path = extract_tool_path(file);
|
||||||
let start_line = file
|
let start_line = file
|
||||||
.get("startLine")
|
.get("startLine")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(1);
|
.unwrap_or(1);
|
||||||
let num_lines = file
|
let num_lines = file
|
||||||
.get("numLines")
|
.get("numLines")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(0);
|
.unwrap_or(0);
|
||||||
let total_lines = file
|
let total_lines = file
|
||||||
.get("totalLines")
|
.get("totalLines")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(num_lines);
|
.unwrap_or(num_lines);
|
||||||
let content = file
|
let content = file
|
||||||
.get("content")
|
.get("content")
|
||||||
@@ -2386,8 +2548,7 @@ fn format_write_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
let line_count = parsed
|
let line_count = parsed
|
||||||
.get("content")
|
.get("content")
|
||||||
.and_then(|value| value.as_str())
|
.and_then(|value| value.as_str())
|
||||||
.map(|content| content.lines().count())
|
.map_or(0, |content| content.lines().count());
|
||||||
.unwrap_or(0);
|
|
||||||
format!(
|
format!(
|
||||||
"{icon} \x1b[1;32m✏️ {} {path}\x1b[0m \x1b[2m({line_count} lines)\x1b[0m",
|
"{icon} \x1b[1;32m✏️ {} {path}\x1b[0m \x1b[2m({line_count} lines)\x1b[0m",
|
||||||
if kind == "create" { "Wrote" } else { "Updated" },
|
if kind == "create" { "Wrote" } else { "Updated" },
|
||||||
@@ -2418,7 +2579,7 @@ fn format_edit_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
let path = extract_tool_path(parsed);
|
let path = extract_tool_path(parsed);
|
||||||
let suffix = if parsed
|
let suffix = if parsed
|
||||||
.get("replaceAll")
|
.get("replaceAll")
|
||||||
.and_then(|value| value.as_bool())
|
.and_then(serde_json::Value::as_bool)
|
||||||
.unwrap_or(false)
|
.unwrap_or(false)
|
||||||
{
|
{
|
||||||
" (replace all)"
|
" (replace all)"
|
||||||
@@ -2446,7 +2607,7 @@ fn format_edit_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
fn format_glob_result(icon: &str, parsed: &serde_json::Value) -> String {
|
fn format_glob_result(icon: &str, parsed: &serde_json::Value) -> String {
|
||||||
let num_files = parsed
|
let num_files = parsed
|
||||||
.get("numFiles")
|
.get("numFiles")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(0);
|
.unwrap_or(0);
|
||||||
let filenames = parsed
|
let filenames = parsed
|
||||||
.get("filenames")
|
.get("filenames")
|
||||||
@@ -2470,11 +2631,11 @@ fn format_glob_result(icon: &str, parsed: &serde_json::Value) -> String {
|
|||||||
fn format_grep_result(icon: &str, parsed: &serde_json::Value) -> String {
|
fn format_grep_result(icon: &str, parsed: &serde_json::Value) -> String {
|
||||||
let num_matches = parsed
|
let num_matches = parsed
|
||||||
.get("numMatches")
|
.get("numMatches")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(0);
|
.unwrap_or(0);
|
||||||
let num_files = parsed
|
let num_files = parsed
|
||||||
.get("numFiles")
|
.get("numFiles")
|
||||||
.and_then(|value| value.as_u64())
|
.and_then(serde_json::Value::as_u64)
|
||||||
.unwrap_or(0);
|
.unwrap_or(0);
|
||||||
let content = parsed
|
let content = parsed
|
||||||
.get("content")
|
.get("content")
|
||||||
@@ -2633,12 +2794,14 @@ impl ToolExecutor for CliToolExecutor {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn permission_policy(mode: PermissionMode) -> PermissionPolicy {
|
fn permission_policy(
|
||||||
tool_permission_specs()
|
mode: PermissionMode,
|
||||||
.into_iter()
|
feature_config: &runtime::RuntimeFeatureConfig,
|
||||||
.fold(PermissionPolicy::new(mode), |policy, spec| {
|
) -> PermissionPolicy {
|
||||||
policy.with_tool_requirement(spec.name, spec.required_permission)
|
tool_permission_specs().into_iter().fold(
|
||||||
})
|
PermissionPolicy::new(mode).with_permission_rules(feature_config.permission_rules()),
|
||||||
|
|policy, spec| policy.with_tool_requirement(spec.name, spec.required_permission),
|
||||||
|
)
|
||||||
}
|
}
|
||||||
|
|
||||||
fn tool_permission_specs() -> Vec<ToolSpec> {
|
fn tool_permission_specs() -> Vec<ToolSpec> {
|
||||||
@@ -2787,12 +2950,17 @@ mod tests {
|
|||||||
normalize_permission_mode, parse_args, parse_git_status_metadata, print_help_to,
|
normalize_permission_mode, parse_args, parse_git_status_metadata, print_help_to,
|
||||||
push_output_block, render_config_report, render_memory_report, render_repl_help,
|
push_output_block, render_config_report, render_memory_report, render_repl_help,
|
||||||
resolve_model_alias, response_to_events, resume_supported_slash_commands, status_context,
|
resolve_model_alias, response_to_events, resume_supported_slash_commands, status_context,
|
||||||
CliAction, CliOutputFormat, SlashCommand, StatusUsage, DEFAULT_MODEL,
|
CliAction, CliOutputFormat, HookAbortMonitor, SlashCommand, StatusUsage, DEFAULT_MODEL,
|
||||||
};
|
};
|
||||||
use api::{MessageResponse, OutputContentBlock, Usage};
|
use api::{MessageResponse, OutputContentBlock, Usage};
|
||||||
use runtime::{AssistantEvent, ContentBlock, ConversationMessage, MessageRole, PermissionMode};
|
use runtime::{
|
||||||
|
AssistantEvent, ContentBlock, ConversationMessage, HookAbortSignal, MessageRole,
|
||||||
|
PermissionMode,
|
||||||
|
};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
use std::path::PathBuf;
|
use std::path::PathBuf;
|
||||||
|
use std::sync::mpsc;
|
||||||
|
use std::time::Duration;
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn defaults_to_repl_when_no_args() {
|
fn defaults_to_repl_when_no_args() {
|
||||||
@@ -3451,4 +3619,43 @@ mod tests {
|
|||||||
if name == "read_file" && input == "{\"path\":\"rust/Cargo.toml\"}"
|
if name == "read_file" && input == "{\"path\":\"rust/Cargo.toml\"}"
|
||||||
));
|
));
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hook_abort_monitor_stops_without_aborting() {
|
||||||
|
let abort_signal = HookAbortSignal::new();
|
||||||
|
let (ready_tx, ready_rx) = mpsc::channel();
|
||||||
|
let monitor = HookAbortMonitor::spawn_with_waiter(
|
||||||
|
abort_signal.clone(),
|
||||||
|
move |stop_rx, abort_signal| {
|
||||||
|
ready_tx.send(()).expect("ready signal");
|
||||||
|
let _ = stop_rx.recv();
|
||||||
|
assert!(!abort_signal.is_aborted());
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
ready_rx.recv().expect("waiter should be ready");
|
||||||
|
monitor.stop();
|
||||||
|
|
||||||
|
assert!(!abort_signal.is_aborted());
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn hook_abort_monitor_propagates_interrupt() {
|
||||||
|
let abort_signal = HookAbortSignal::new();
|
||||||
|
let (done_tx, done_rx) = mpsc::channel();
|
||||||
|
let monitor = HookAbortMonitor::spawn_with_waiter(
|
||||||
|
abort_signal.clone(),
|
||||||
|
move |_stop_rx, abort_signal| {
|
||||||
|
abort_signal.abort();
|
||||||
|
done_tx.send(()).expect("done signal");
|
||||||
|
},
|
||||||
|
);
|
||||||
|
|
||||||
|
done_rx
|
||||||
|
.recv_timeout(Duration::from_secs(1))
|
||||||
|
.expect("interrupt should complete");
|
||||||
|
monitor.stop();
|
||||||
|
|
||||||
|
assert!(abort_signal.is_aborted());
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -286,7 +286,7 @@ impl TerminalRenderer {
|
|||||||
) {
|
) {
|
||||||
match event {
|
match event {
|
||||||
Event::Start(Tag::Heading { level, .. }) => {
|
Event::Start(Tag::Heading { level, .. }) => {
|
||||||
self.start_heading(state, level as u8, output)
|
Self::start_heading(state, level as u8, output);
|
||||||
}
|
}
|
||||||
Event::End(TagEnd::Paragraph) => output.push_str("\n\n"),
|
Event::End(TagEnd::Paragraph) => output.push_str("\n\n"),
|
||||||
Event::Start(Tag::BlockQuote(..)) => self.start_quote(state, output),
|
Event::Start(Tag::BlockQuote(..)) => self.start_quote(state, output),
|
||||||
@@ -426,7 +426,7 @@ impl TerminalRenderer {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
fn start_heading(&self, state: &mut RenderState, level: u8, output: &mut String) {
|
fn start_heading(state: &mut RenderState, level: u8, output: &mut String) {
|
||||||
state.heading_level = Some(level);
|
state.heading_level = Some(level);
|
||||||
if !output.is_empty() {
|
if !output.is_empty() {
|
||||||
output.push('\n');
|
output.push('\n');
|
||||||
|
|||||||
@@ -6,10 +6,12 @@ license.workspace = true
|
|||||||
publish.workspace = true
|
publish.workspace = true
|
||||||
|
|
||||||
[dependencies]
|
[dependencies]
|
||||||
|
api = { path = "../api" }
|
||||||
runtime = { path = "../runtime" }
|
runtime = { path = "../runtime" }
|
||||||
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
|
reqwest = { version = "0.12", default-features = false, features = ["blocking", "rustls-tls"] }
|
||||||
serde = { version = "1", features = ["derive"] }
|
serde = { version = "1", features = ["derive"] }
|
||||||
serde_json = "1"
|
serde_json = "1"
|
||||||
|
tokio = { version = "1", features = ["rt-multi-thread"] }
|
||||||
|
|
||||||
[lints]
|
[lints]
|
||||||
workspace = true
|
workspace = true
|
||||||
|
|||||||
@@ -3,10 +3,17 @@ use std::path::{Path, PathBuf};
|
|||||||
use std::process::Command;
|
use std::process::Command;
|
||||||
use std::time::{Duration, Instant};
|
use std::time::{Duration, Instant};
|
||||||
|
|
||||||
|
use api::{
|
||||||
|
read_base_url, AnthropicClient, ContentBlockDelta, InputContentBlock, InputMessage,
|
||||||
|
MessageRequest, MessageResponse, OutputContentBlock, StreamEvent as ApiStreamEvent, ToolChoice,
|
||||||
|
ToolDefinition, ToolResultContentBlock,
|
||||||
|
};
|
||||||
use reqwest::blocking::Client;
|
use reqwest::blocking::Client;
|
||||||
use runtime::{
|
use runtime::{
|
||||||
edit_file, execute_bash, glob_search, grep_search, read_file, write_file, BashCommandInput,
|
edit_file, execute_bash, glob_search, grep_search, load_system_prompt, read_file, write_file,
|
||||||
GrepSearchInput, PermissionMode,
|
ApiClient, ApiRequest, AssistantEvent, BashCommandInput, ContentBlock, ConversationMessage,
|
||||||
|
ConversationRuntime, GrepSearchInput, MessageRole, PermissionMode, PermissionPolicy,
|
||||||
|
RuntimeError, Session, TokenUsage, ToolError, ToolExecutor,
|
||||||
};
|
};
|
||||||
use serde::{Deserialize, Serialize};
|
use serde::{Deserialize, Serialize};
|
||||||
use serde_json::{json, Value};
|
use serde_json::{json, Value};
|
||||||
@@ -702,7 +709,7 @@ struct SkillOutput {
|
|||||||
prompt: String,
|
prompt: String,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize, Deserialize)]
|
#[derive(Debug, Clone, Serialize, Deserialize)]
|
||||||
struct AgentOutput {
|
struct AgentOutput {
|
||||||
#[serde(rename = "agentId")]
|
#[serde(rename = "agentId")]
|
||||||
agent_id: String,
|
agent_id: String,
|
||||||
@@ -718,6 +725,20 @@ struct AgentOutput {
|
|||||||
manifest_file: String,
|
manifest_file: String,
|
||||||
#[serde(rename = "createdAt")]
|
#[serde(rename = "createdAt")]
|
||||||
created_at: String,
|
created_at: String,
|
||||||
|
#[serde(rename = "startedAt", skip_serializing_if = "Option::is_none")]
|
||||||
|
started_at: Option<String>,
|
||||||
|
#[serde(rename = "completedAt", skip_serializing_if = "Option::is_none")]
|
||||||
|
completed_at: Option<String>,
|
||||||
|
#[serde(skip_serializing_if = "Option::is_none")]
|
||||||
|
error: Option<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug, Clone)]
|
||||||
|
struct AgentJob {
|
||||||
|
manifest: AgentOutput,
|
||||||
|
prompt: String,
|
||||||
|
system_prompt: Vec<String>,
|
||||||
|
allowed_tools: BTreeSet<String>,
|
||||||
}
|
}
|
||||||
|
|
||||||
#[derive(Debug, Serialize)]
|
#[derive(Debug, Serialize)]
|
||||||
@@ -1315,7 +1336,18 @@ fn resolve_skill_path(skill: &str) -> Result<std::path::PathBuf, String> {
|
|||||||
Err(format!("unknown skill: {requested}"))
|
Err(format!("unknown skill: {requested}"))
|
||||||
}
|
}
|
||||||
|
|
||||||
|
const DEFAULT_AGENT_MODEL: &str = "claude-opus-4-6";
|
||||||
|
const DEFAULT_AGENT_SYSTEM_DATE: &str = "2026-03-31";
|
||||||
|
const DEFAULT_AGENT_MAX_ITERATIONS: usize = 32;
|
||||||
|
|
||||||
fn execute_agent(input: AgentInput) -> Result<AgentOutput, String> {
|
fn execute_agent(input: AgentInput) -> Result<AgentOutput, String> {
|
||||||
|
execute_agent_with_spawn(input, spawn_agent_job)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn execute_agent_with_spawn<F>(input: AgentInput, spawn_fn: F) -> Result<AgentOutput, String>
|
||||||
|
where
|
||||||
|
F: FnOnce(AgentJob) -> Result<(), String>,
|
||||||
|
{
|
||||||
if input.description.trim().is_empty() {
|
if input.description.trim().is_empty() {
|
||||||
return Err(String::from("description must not be empty"));
|
return Err(String::from("description must not be empty"));
|
||||||
}
|
}
|
||||||
@@ -1329,6 +1361,7 @@ fn execute_agent(input: AgentInput) -> Result<AgentOutput, String> {
|
|||||||
let output_file = output_dir.join(format!("{agent_id}.md"));
|
let output_file = output_dir.join(format!("{agent_id}.md"));
|
||||||
let manifest_file = output_dir.join(format!("{agent_id}.json"));
|
let manifest_file = output_dir.join(format!("{agent_id}.json"));
|
||||||
let normalized_subagent_type = normalize_subagent_type(input.subagent_type.as_deref());
|
let normalized_subagent_type = normalize_subagent_type(input.subagent_type.as_deref());
|
||||||
|
let model = resolve_agent_model(input.model.as_deref());
|
||||||
let agent_name = input
|
let agent_name = input
|
||||||
.name
|
.name
|
||||||
.as_deref()
|
.as_deref()
|
||||||
@@ -1336,6 +1369,8 @@ fn execute_agent(input: AgentInput) -> Result<AgentOutput, String> {
|
|||||||
.filter(|name| !name.is_empty())
|
.filter(|name| !name.is_empty())
|
||||||
.unwrap_or_else(|| slugify_agent_name(&input.description));
|
.unwrap_or_else(|| slugify_agent_name(&input.description));
|
||||||
let created_at = iso8601_now();
|
let created_at = iso8601_now();
|
||||||
|
let system_prompt = build_agent_system_prompt(&normalized_subagent_type)?;
|
||||||
|
let allowed_tools = allowed_tools_for_subagent(&normalized_subagent_type);
|
||||||
|
|
||||||
let output_contents = format!(
|
let output_contents = format!(
|
||||||
"# Agent Task
|
"# Agent Task
|
||||||
@@ -1359,21 +1394,514 @@ fn execute_agent(input: AgentInput) -> Result<AgentOutput, String> {
|
|||||||
name: agent_name,
|
name: agent_name,
|
||||||
description: input.description,
|
description: input.description,
|
||||||
subagent_type: Some(normalized_subagent_type),
|
subagent_type: Some(normalized_subagent_type),
|
||||||
model: input.model,
|
model: Some(model),
|
||||||
status: String::from("queued"),
|
status: String::from("running"),
|
||||||
output_file: output_file.display().to_string(),
|
output_file: output_file.display().to_string(),
|
||||||
manifest_file: manifest_file.display().to_string(),
|
manifest_file: manifest_file.display().to_string(),
|
||||||
created_at,
|
created_at: created_at.clone(),
|
||||||
|
started_at: Some(created_at),
|
||||||
|
completed_at: None,
|
||||||
|
error: None,
|
||||||
};
|
};
|
||||||
std::fs::write(
|
write_agent_manifest(&manifest)?;
|
||||||
&manifest_file,
|
|
||||||
serde_json::to_string_pretty(&manifest).map_err(|error| error.to_string())?,
|
let manifest_for_spawn = manifest.clone();
|
||||||
)
|
let job = AgentJob {
|
||||||
.map_err(|error| error.to_string())?;
|
manifest: manifest_for_spawn,
|
||||||
|
prompt: input.prompt,
|
||||||
|
system_prompt,
|
||||||
|
allowed_tools,
|
||||||
|
};
|
||||||
|
if let Err(error) = spawn_fn(job) {
|
||||||
|
let error = format!("failed to spawn sub-agent: {error}");
|
||||||
|
persist_agent_terminal_state(&manifest, "failed", None, Some(error.clone()))?;
|
||||||
|
return Err(error);
|
||||||
|
}
|
||||||
|
|
||||||
Ok(manifest)
|
Ok(manifest)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
fn spawn_agent_job(job: AgentJob) -> Result<(), String> {
|
||||||
|
let thread_name = format!("clawd-agent-{}", job.manifest.agent_id);
|
||||||
|
std::thread::Builder::new()
|
||||||
|
.name(thread_name)
|
||||||
|
.spawn(move || {
|
||||||
|
let result =
|
||||||
|
std::panic::catch_unwind(std::panic::AssertUnwindSafe(|| run_agent_job(&job)));
|
||||||
|
match result {
|
||||||
|
Ok(Ok(())) => {}
|
||||||
|
Ok(Err(error)) => {
|
||||||
|
let _ =
|
||||||
|
persist_agent_terminal_state(&job.manifest, "failed", None, Some(error));
|
||||||
|
}
|
||||||
|
Err(_) => {
|
||||||
|
let _ = persist_agent_terminal_state(
|
||||||
|
&job.manifest,
|
||||||
|
"failed",
|
||||||
|
None,
|
||||||
|
Some(String::from("sub-agent thread panicked")),
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
})
|
||||||
|
.map(|_| ())
|
||||||
|
.map_err(|error| error.to_string())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn run_agent_job(job: &AgentJob) -> Result<(), String> {
|
||||||
|
let mut runtime = build_agent_runtime(job)?.with_max_iterations(DEFAULT_AGENT_MAX_ITERATIONS);
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn(job.prompt.clone(), None)
|
||||||
|
.map_err(|error| error.to_string())?;
|
||||||
|
let final_text = final_assistant_text(&summary);
|
||||||
|
persist_agent_terminal_state(&job.manifest, "completed", Some(final_text.as_str()), None)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn build_agent_runtime(
|
||||||
|
job: &AgentJob,
|
||||||
|
) -> Result<ConversationRuntime<AnthropicRuntimeClient, SubagentToolExecutor>, String> {
|
||||||
|
let model = job
|
||||||
|
.manifest
|
||||||
|
.model
|
||||||
|
.clone()
|
||||||
|
.unwrap_or_else(|| DEFAULT_AGENT_MODEL.to_string());
|
||||||
|
let allowed_tools = job.allowed_tools.clone();
|
||||||
|
let api_client = AnthropicRuntimeClient::new(model, allowed_tools.clone())?;
|
||||||
|
let tool_executor = SubagentToolExecutor::new(allowed_tools);
|
||||||
|
Ok(ConversationRuntime::new(
|
||||||
|
Session::new(),
|
||||||
|
api_client,
|
||||||
|
tool_executor,
|
||||||
|
agent_permission_policy(),
|
||||||
|
job.system_prompt.clone(),
|
||||||
|
))
|
||||||
|
}
|
||||||
|
|
||||||
|
fn build_agent_system_prompt(subagent_type: &str) -> Result<Vec<String>, String> {
|
||||||
|
let cwd = std::env::current_dir().map_err(|error| error.to_string())?;
|
||||||
|
let mut prompt = load_system_prompt(
|
||||||
|
cwd,
|
||||||
|
DEFAULT_AGENT_SYSTEM_DATE.to_string(),
|
||||||
|
std::env::consts::OS,
|
||||||
|
"unknown",
|
||||||
|
)
|
||||||
|
.map_err(|error| error.to_string())?;
|
||||||
|
prompt.push(format!(
|
||||||
|
"You are a background sub-agent of type `{subagent_type}`. Work only on the delegated task, use only the tools available to you, do not ask the user questions, and finish with a concise result."
|
||||||
|
));
|
||||||
|
Ok(prompt)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn resolve_agent_model(model: Option<&str>) -> String {
|
||||||
|
model
|
||||||
|
.map(str::trim)
|
||||||
|
.filter(|model| !model.is_empty())
|
||||||
|
.unwrap_or(DEFAULT_AGENT_MODEL)
|
||||||
|
.to_string()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn allowed_tools_for_subagent(subagent_type: &str) -> BTreeSet<String> {
|
||||||
|
let tools = match subagent_type {
|
||||||
|
"Explore" => vec![
|
||||||
|
"read_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"WebFetch",
|
||||||
|
"WebSearch",
|
||||||
|
"ToolSearch",
|
||||||
|
"Skill",
|
||||||
|
"StructuredOutput",
|
||||||
|
],
|
||||||
|
"Plan" => vec![
|
||||||
|
"read_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"WebFetch",
|
||||||
|
"WebSearch",
|
||||||
|
"ToolSearch",
|
||||||
|
"Skill",
|
||||||
|
"TodoWrite",
|
||||||
|
"StructuredOutput",
|
||||||
|
"SendUserMessage",
|
||||||
|
],
|
||||||
|
"Verification" => vec![
|
||||||
|
"bash",
|
||||||
|
"read_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"WebFetch",
|
||||||
|
"WebSearch",
|
||||||
|
"ToolSearch",
|
||||||
|
"TodoWrite",
|
||||||
|
"StructuredOutput",
|
||||||
|
"SendUserMessage",
|
||||||
|
"PowerShell",
|
||||||
|
],
|
||||||
|
"claude-code-guide" => vec![
|
||||||
|
"read_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"WebFetch",
|
||||||
|
"WebSearch",
|
||||||
|
"ToolSearch",
|
||||||
|
"Skill",
|
||||||
|
"StructuredOutput",
|
||||||
|
"SendUserMessage",
|
||||||
|
],
|
||||||
|
"statusline-setup" => vec![
|
||||||
|
"bash",
|
||||||
|
"read_file",
|
||||||
|
"write_file",
|
||||||
|
"edit_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"ToolSearch",
|
||||||
|
],
|
||||||
|
_ => vec![
|
||||||
|
"bash",
|
||||||
|
"read_file",
|
||||||
|
"write_file",
|
||||||
|
"edit_file",
|
||||||
|
"glob_search",
|
||||||
|
"grep_search",
|
||||||
|
"WebFetch",
|
||||||
|
"WebSearch",
|
||||||
|
"TodoWrite",
|
||||||
|
"Skill",
|
||||||
|
"ToolSearch",
|
||||||
|
"NotebookEdit",
|
||||||
|
"Sleep",
|
||||||
|
"SendUserMessage",
|
||||||
|
"Config",
|
||||||
|
"StructuredOutput",
|
||||||
|
"REPL",
|
||||||
|
"PowerShell",
|
||||||
|
],
|
||||||
|
};
|
||||||
|
tools.into_iter().map(str::to_string).collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn agent_permission_policy() -> PermissionPolicy {
|
||||||
|
mvp_tool_specs().into_iter().fold(
|
||||||
|
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||||
|
|policy, spec| policy.with_tool_requirement(spec.name, spec.required_permission),
|
||||||
|
)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn write_agent_manifest(manifest: &AgentOutput) -> Result<(), String> {
|
||||||
|
std::fs::write(
|
||||||
|
&manifest.manifest_file,
|
||||||
|
serde_json::to_string_pretty(manifest).map_err(|error| error.to_string())?,
|
||||||
|
)
|
||||||
|
.map_err(|error| error.to_string())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn persist_agent_terminal_state(
|
||||||
|
manifest: &AgentOutput,
|
||||||
|
status: &str,
|
||||||
|
result: Option<&str>,
|
||||||
|
error: Option<String>,
|
||||||
|
) -> Result<(), String> {
|
||||||
|
append_agent_output(
|
||||||
|
&manifest.output_file,
|
||||||
|
&format_agent_terminal_output(status, result, error.as_deref()),
|
||||||
|
)?;
|
||||||
|
let mut next_manifest = manifest.clone();
|
||||||
|
next_manifest.status = status.to_string();
|
||||||
|
next_manifest.completed_at = Some(iso8601_now());
|
||||||
|
next_manifest.error = error;
|
||||||
|
write_agent_manifest(&next_manifest)
|
||||||
|
}
|
||||||
|
|
||||||
|
fn append_agent_output(path: &str, suffix: &str) -> Result<(), String> {
|
||||||
|
use std::io::Write as _;
|
||||||
|
|
||||||
|
let mut file = std::fs::OpenOptions::new()
|
||||||
|
.append(true)
|
||||||
|
.open(path)
|
||||||
|
.map_err(|error| error.to_string())?;
|
||||||
|
file.write_all(suffix.as_bytes())
|
||||||
|
.map_err(|error| error.to_string())
|
||||||
|
}
|
||||||
|
|
||||||
|
fn format_agent_terminal_output(status: &str, result: Option<&str>, error: Option<&str>) -> String {
|
||||||
|
let mut sections = vec![format!("\n## Result\n\n- status: {status}\n")];
|
||||||
|
if let Some(result) = result.filter(|value| !value.trim().is_empty()) {
|
||||||
|
sections.push(format!("\n### Final response\n\n{}\n", result.trim()));
|
||||||
|
}
|
||||||
|
if let Some(error) = error.filter(|value| !value.trim().is_empty()) {
|
||||||
|
sections.push(format!("\n### Error\n\n{}\n", error.trim()));
|
||||||
|
}
|
||||||
|
sections.join("")
|
||||||
|
}
|
||||||
|
|
||||||
|
struct AnthropicRuntimeClient {
|
||||||
|
runtime: tokio::runtime::Runtime,
|
||||||
|
client: AnthropicClient,
|
||||||
|
model: String,
|
||||||
|
allowed_tools: BTreeSet<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl AnthropicRuntimeClient {
|
||||||
|
fn new(model: String, allowed_tools: BTreeSet<String>) -> Result<Self, String> {
|
||||||
|
let client = AnthropicClient::from_env()
|
||||||
|
.map_err(|error| error.to_string())?
|
||||||
|
.with_base_url(read_base_url());
|
||||||
|
Ok(Self {
|
||||||
|
runtime: tokio::runtime::Runtime::new().map_err(|error| error.to_string())?,
|
||||||
|
client,
|
||||||
|
model,
|
||||||
|
allowed_tools,
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ApiClient for AnthropicRuntimeClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
let tools = tool_specs_for_allowed_tools(Some(&self.allowed_tools))
|
||||||
|
.into_iter()
|
||||||
|
.map(|spec| ToolDefinition {
|
||||||
|
name: spec.name.to_string(),
|
||||||
|
description: Some(spec.description.to_string()),
|
||||||
|
input_schema: spec.input_schema,
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
|
let message_request = MessageRequest {
|
||||||
|
model: self.model.clone(),
|
||||||
|
max_tokens: 32_000,
|
||||||
|
messages: convert_messages(&request.messages),
|
||||||
|
system: (!request.system_prompt.is_empty()).then(|| request.system_prompt.join("\n\n")),
|
||||||
|
tools: (!tools.is_empty()).then_some(tools),
|
||||||
|
tool_choice: (!self.allowed_tools.is_empty()).then_some(ToolChoice::Auto),
|
||||||
|
stream: true,
|
||||||
|
};
|
||||||
|
|
||||||
|
self.runtime.block_on(async {
|
||||||
|
let mut stream = self
|
||||||
|
.client
|
||||||
|
.stream_message(&message_request)
|
||||||
|
.await
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
|
let mut events = Vec::new();
|
||||||
|
let mut pending_tool: Option<(String, String, String)> = None;
|
||||||
|
let mut saw_stop = false;
|
||||||
|
|
||||||
|
while let Some(event) = stream
|
||||||
|
.next_event()
|
||||||
|
.await
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?
|
||||||
|
{
|
||||||
|
match event {
|
||||||
|
ApiStreamEvent::MessageStart(start) => {
|
||||||
|
for block in start.message.content {
|
||||||
|
push_output_block(block, &mut events, &mut pending_tool, true);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ApiStreamEvent::ContentBlockStart(start) => {
|
||||||
|
push_output_block(
|
||||||
|
start.content_block,
|
||||||
|
&mut events,
|
||||||
|
&mut pending_tool,
|
||||||
|
true,
|
||||||
|
);
|
||||||
|
}
|
||||||
|
ApiStreamEvent::ContentBlockDelta(delta) => match delta.delta {
|
||||||
|
ContentBlockDelta::TextDelta { text } => {
|
||||||
|
if !text.is_empty() {
|
||||||
|
events.push(AssistantEvent::TextDelta(text));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ContentBlockDelta::InputJsonDelta { partial_json } => {
|
||||||
|
if let Some((_, _, input)) = &mut pending_tool {
|
||||||
|
input.push_str(&partial_json);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
},
|
||||||
|
ApiStreamEvent::ContentBlockStop(_) => {
|
||||||
|
if let Some((id, name, input)) = pending_tool.take() {
|
||||||
|
events.push(AssistantEvent::ToolUse { id, name, input });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
ApiStreamEvent::MessageDelta(delta) => {
|
||||||
|
events.push(AssistantEvent::Usage(TokenUsage {
|
||||||
|
input_tokens: delta.usage.input_tokens,
|
||||||
|
output_tokens: delta.usage.output_tokens,
|
||||||
|
cache_creation_input_tokens: 0,
|
||||||
|
cache_read_input_tokens: 0,
|
||||||
|
}));
|
||||||
|
}
|
||||||
|
ApiStreamEvent::MessageStop(_) => {
|
||||||
|
saw_stop = true;
|
||||||
|
events.push(AssistantEvent::MessageStop);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
if !saw_stop
|
||||||
|
&& events.iter().any(|event| {
|
||||||
|
matches!(event, AssistantEvent::TextDelta(text) if !text.is_empty())
|
||||||
|
|| matches!(event, AssistantEvent::ToolUse { .. })
|
||||||
|
})
|
||||||
|
{
|
||||||
|
events.push(AssistantEvent::MessageStop);
|
||||||
|
}
|
||||||
|
|
||||||
|
if events
|
||||||
|
.iter()
|
||||||
|
.any(|event| matches!(event, AssistantEvent::MessageStop))
|
||||||
|
{
|
||||||
|
return Ok(events);
|
||||||
|
}
|
||||||
|
|
||||||
|
let response = self
|
||||||
|
.client
|
||||||
|
.send_message(&MessageRequest {
|
||||||
|
stream: false,
|
||||||
|
..message_request.clone()
|
||||||
|
})
|
||||||
|
.await
|
||||||
|
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||||
|
Ok(response_to_events(response))
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
struct SubagentToolExecutor {
|
||||||
|
allowed_tools: BTreeSet<String>,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl SubagentToolExecutor {
|
||||||
|
fn new(allowed_tools: BTreeSet<String>) -> Self {
|
||||||
|
Self { allowed_tools }
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
impl ToolExecutor for SubagentToolExecutor {
|
||||||
|
fn execute(&mut self, tool_name: &str, input: &str) -> Result<String, ToolError> {
|
||||||
|
if !self.allowed_tools.contains(tool_name) {
|
||||||
|
return Err(ToolError::new(format!(
|
||||||
|
"tool `{tool_name}` is not enabled for this sub-agent"
|
||||||
|
)));
|
||||||
|
}
|
||||||
|
let value = serde_json::from_str(input)
|
||||||
|
.map_err(|error| ToolError::new(format!("invalid tool input JSON: {error}")))?;
|
||||||
|
execute_tool(tool_name, &value).map_err(ToolError::new)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn tool_specs_for_allowed_tools(allowed_tools: Option<&BTreeSet<String>>) -> Vec<ToolSpec> {
|
||||||
|
mvp_tool_specs()
|
||||||
|
.into_iter()
|
||||||
|
.filter(|spec| allowed_tools.is_none_or(|allowed| allowed.contains(spec.name)))
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn convert_messages(messages: &[ConversationMessage]) -> Vec<InputMessage> {
|
||||||
|
messages
|
||||||
|
.iter()
|
||||||
|
.filter_map(|message| {
|
||||||
|
let role = match message.role {
|
||||||
|
MessageRole::System | MessageRole::User | MessageRole::Tool => "user",
|
||||||
|
MessageRole::Assistant => "assistant",
|
||||||
|
};
|
||||||
|
let content = message
|
||||||
|
.blocks
|
||||||
|
.iter()
|
||||||
|
.map(|block| match block {
|
||||||
|
ContentBlock::Text { text } => InputContentBlock::Text { text: text.clone() },
|
||||||
|
ContentBlock::ToolUse { id, name, input } => InputContentBlock::ToolUse {
|
||||||
|
id: id.clone(),
|
||||||
|
name: name.clone(),
|
||||||
|
input: serde_json::from_str(input)
|
||||||
|
.unwrap_or_else(|_| serde_json::json!({ "raw": input })),
|
||||||
|
},
|
||||||
|
ContentBlock::ToolResult {
|
||||||
|
tool_use_id,
|
||||||
|
output,
|
||||||
|
is_error,
|
||||||
|
..
|
||||||
|
} => InputContentBlock::ToolResult {
|
||||||
|
tool_use_id: tool_use_id.clone(),
|
||||||
|
content: vec![ToolResultContentBlock::Text {
|
||||||
|
text: output.clone(),
|
||||||
|
}],
|
||||||
|
is_error: *is_error,
|
||||||
|
},
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>();
|
||||||
|
(!content.is_empty()).then(|| InputMessage {
|
||||||
|
role: role.to_string(),
|
||||||
|
content,
|
||||||
|
})
|
||||||
|
})
|
||||||
|
.collect()
|
||||||
|
}
|
||||||
|
|
||||||
|
fn push_output_block(
|
||||||
|
block: OutputContentBlock,
|
||||||
|
events: &mut Vec<AssistantEvent>,
|
||||||
|
pending_tool: &mut Option<(String, String, String)>,
|
||||||
|
streaming_tool_input: bool,
|
||||||
|
) {
|
||||||
|
match block {
|
||||||
|
OutputContentBlock::Text { text } => {
|
||||||
|
if !text.is_empty() {
|
||||||
|
events.push(AssistantEvent::TextDelta(text));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
OutputContentBlock::ToolUse { id, name, input } => {
|
||||||
|
let initial_input = if streaming_tool_input
|
||||||
|
&& input.is_object()
|
||||||
|
&& input.as_object().is_some_and(serde_json::Map::is_empty)
|
||||||
|
{
|
||||||
|
String::new()
|
||||||
|
} else {
|
||||||
|
input.to_string()
|
||||||
|
};
|
||||||
|
*pending_tool = Some((id, name, initial_input));
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
fn response_to_events(response: MessageResponse) -> Vec<AssistantEvent> {
|
||||||
|
let mut events = Vec::new();
|
||||||
|
let mut pending_tool = None;
|
||||||
|
|
||||||
|
for block in response.content {
|
||||||
|
push_output_block(block, &mut events, &mut pending_tool, false);
|
||||||
|
if let Some((id, name, input)) = pending_tool.take() {
|
||||||
|
events.push(AssistantEvent::ToolUse { id, name, input });
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
events.push(AssistantEvent::Usage(TokenUsage {
|
||||||
|
input_tokens: response.usage.input_tokens,
|
||||||
|
output_tokens: response.usage.output_tokens,
|
||||||
|
cache_creation_input_tokens: response.usage.cache_creation_input_tokens,
|
||||||
|
cache_read_input_tokens: response.usage.cache_read_input_tokens,
|
||||||
|
}));
|
||||||
|
events.push(AssistantEvent::MessageStop);
|
||||||
|
events
|
||||||
|
}
|
||||||
|
|
||||||
|
fn final_assistant_text(summary: &runtime::TurnSummary) -> String {
|
||||||
|
summary
|
||||||
|
.assistant_messages
|
||||||
|
.last()
|
||||||
|
.map(|message| {
|
||||||
|
message
|
||||||
|
.blocks
|
||||||
|
.iter()
|
||||||
|
.filter_map(|block| match block {
|
||||||
|
ContentBlock::Text { text } => Some(text.as_str()),
|
||||||
|
_ => None,
|
||||||
|
})
|
||||||
|
.collect::<Vec<_>>()
|
||||||
|
.join("")
|
||||||
|
})
|
||||||
|
.unwrap_or_default()
|
||||||
|
}
|
||||||
|
|
||||||
#[allow(clippy::needless_pass_by_value)]
|
#[allow(clippy::needless_pass_by_value)]
|
||||||
fn execute_tool_search(input: ToolSearchInput) -> ToolSearchOutput {
|
fn execute_tool_search(input: ToolSearchInput) -> ToolSearchOutput {
|
||||||
let deferred = deferred_tool_specs();
|
let deferred = deferred_tool_specs();
|
||||||
@@ -2207,7 +2735,7 @@ fn execute_shell_command(
|
|||||||
persisted_output_path: None,
|
persisted_output_path: None,
|
||||||
persisted_output_size: None,
|
persisted_output_size: None,
|
||||||
sandbox_status: None,
|
sandbox_status: None,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|
||||||
let mut process = std::process::Command::new(shell);
|
let mut process = std::process::Command::new(shell);
|
||||||
@@ -2276,7 +2804,7 @@ Command exceeded timeout of {timeout_ms} ms",
|
|||||||
persisted_output_path: None,
|
persisted_output_path: None,
|
||||||
persisted_output_size: None,
|
persisted_output_size: None,
|
||||||
sandbox_status: None,
|
sandbox_status: None,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
std::thread::sleep(Duration::from_millis(10));
|
std::thread::sleep(Duration::from_millis(10));
|
||||||
}
|
}
|
||||||
@@ -2365,6 +2893,7 @@ fn parse_skill_description(contents: &str) -> Option<String> {
|
|||||||
|
|
||||||
#[cfg(test)]
|
#[cfg(test)]
|
||||||
mod tests {
|
mod tests {
|
||||||
|
use std::collections::BTreeSet;
|
||||||
use std::fs;
|
use std::fs;
|
||||||
use std::io::{Read, Write};
|
use std::io::{Read, Write};
|
||||||
use std::net::{SocketAddr, TcpListener};
|
use std::net::{SocketAddr, TcpListener};
|
||||||
@@ -2373,7 +2902,12 @@ mod tests {
|
|||||||
use std::thread;
|
use std::thread;
|
||||||
use std::time::Duration;
|
use std::time::Duration;
|
||||||
|
|
||||||
use super::{execute_tool, mvp_tool_specs};
|
use super::{
|
||||||
|
agent_permission_policy, allowed_tools_for_subagent, execute_agent_with_spawn,
|
||||||
|
execute_tool, final_assistant_text, mvp_tool_specs, persist_agent_terminal_state,
|
||||||
|
AgentInput, AgentJob, SubagentToolExecutor,
|
||||||
|
};
|
||||||
|
use runtime::{ApiRequest, AssistantEvent, ConversationRuntime, RuntimeError, Session};
|
||||||
use serde_json::json;
|
use serde_json::json;
|
||||||
|
|
||||||
fn env_lock() -> &'static Mutex<()> {
|
fn env_lock() -> &'static Mutex<()> {
|
||||||
@@ -2765,32 +3299,48 @@ mod tests {
|
|||||||
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||||
let dir = temp_path("agent-store");
|
let dir = temp_path("agent-store");
|
||||||
std::env::set_var("CLAWD_AGENT_STORE", &dir);
|
std::env::set_var("CLAWD_AGENT_STORE", &dir);
|
||||||
|
let captured = Arc::new(Mutex::new(None::<AgentJob>));
|
||||||
|
let captured_for_spawn = Arc::clone(&captured);
|
||||||
|
|
||||||
let result = execute_tool(
|
let manifest = execute_agent_with_spawn(
|
||||||
"Agent",
|
AgentInput {
|
||||||
&json!({
|
description: "Audit the branch".to_string(),
|
||||||
"description": "Audit the branch",
|
prompt: "Check tests and outstanding work.".to_string(),
|
||||||
"prompt": "Check tests and outstanding work.",
|
subagent_type: Some("Explore".to_string()),
|
||||||
"subagent_type": "Explore",
|
name: Some("ship-audit".to_string()),
|
||||||
"name": "ship-audit"
|
model: None,
|
||||||
}),
|
},
|
||||||
|
move |job| {
|
||||||
|
*captured_for_spawn
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(std::sync::PoisonError::into_inner) = Some(job);
|
||||||
|
Ok(())
|
||||||
|
},
|
||||||
)
|
)
|
||||||
.expect("Agent should succeed");
|
.expect("Agent should succeed");
|
||||||
std::env::remove_var("CLAWD_AGENT_STORE");
|
std::env::remove_var("CLAWD_AGENT_STORE");
|
||||||
|
|
||||||
let output: serde_json::Value = serde_json::from_str(&result).expect("valid json");
|
assert_eq!(manifest.name, "ship-audit");
|
||||||
assert_eq!(output["name"], "ship-audit");
|
assert_eq!(manifest.subagent_type.as_deref(), Some("Explore"));
|
||||||
assert_eq!(output["subagentType"], "Explore");
|
assert_eq!(manifest.status, "running");
|
||||||
assert_eq!(output["status"], "queued");
|
assert!(!manifest.created_at.is_empty());
|
||||||
assert!(output["createdAt"].as_str().is_some());
|
assert!(manifest.started_at.is_some());
|
||||||
let manifest_file = output["manifestFile"].as_str().expect("manifest file");
|
assert!(manifest.completed_at.is_none());
|
||||||
let output_file = output["outputFile"].as_str().expect("output file");
|
let contents = std::fs::read_to_string(&manifest.output_file).expect("agent file exists");
|
||||||
let contents = std::fs::read_to_string(output_file).expect("agent file exists");
|
|
||||||
let manifest_contents =
|
let manifest_contents =
|
||||||
std::fs::read_to_string(manifest_file).expect("manifest file exists");
|
std::fs::read_to_string(&manifest.manifest_file).expect("manifest file exists");
|
||||||
assert!(contents.contains("Audit the branch"));
|
assert!(contents.contains("Audit the branch"));
|
||||||
assert!(contents.contains("Check tests and outstanding work."));
|
assert!(contents.contains("Check tests and outstanding work."));
|
||||||
assert!(manifest_contents.contains("\"subagentType\": \"Explore\""));
|
assert!(manifest_contents.contains("\"subagentType\": \"Explore\""));
|
||||||
|
assert!(manifest_contents.contains("\"status\": \"running\""));
|
||||||
|
let captured_job = captured
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(std::sync::PoisonError::into_inner)
|
||||||
|
.clone()
|
||||||
|
.expect("spawn job should be captured");
|
||||||
|
assert_eq!(captured_job.prompt, "Check tests and outstanding work.");
|
||||||
|
assert!(captured_job.allowed_tools.contains("read_file"));
|
||||||
|
assert!(!captured_job.allowed_tools.contains("Agent"));
|
||||||
|
|
||||||
let normalized = execute_tool(
|
let normalized = execute_tool(
|
||||||
"Agent",
|
"Agent",
|
||||||
@@ -2819,6 +3369,195 @@ mod tests {
|
|||||||
let _ = std::fs::remove_dir_all(dir);
|
let _ = std::fs::remove_dir_all(dir);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn agent_fake_runner_can_persist_completion_and_failure() {
|
||||||
|
let _guard = env_lock()
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||||
|
let dir = temp_path("agent-runner");
|
||||||
|
std::env::set_var("CLAWD_AGENT_STORE", &dir);
|
||||||
|
|
||||||
|
let completed = execute_agent_with_spawn(
|
||||||
|
AgentInput {
|
||||||
|
description: "Complete the task".to_string(),
|
||||||
|
prompt: "Do the work".to_string(),
|
||||||
|
subagent_type: Some("Explore".to_string()),
|
||||||
|
name: Some("complete-task".to_string()),
|
||||||
|
model: Some("claude-sonnet-4-6".to_string()),
|
||||||
|
},
|
||||||
|
|job| {
|
||||||
|
persist_agent_terminal_state(
|
||||||
|
&job.manifest,
|
||||||
|
"completed",
|
||||||
|
Some("Finished successfully"),
|
||||||
|
None,
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
.expect("completed agent should succeed");
|
||||||
|
|
||||||
|
let completed_manifest = std::fs::read_to_string(&completed.manifest_file)
|
||||||
|
.expect("completed manifest should exist");
|
||||||
|
let completed_output =
|
||||||
|
std::fs::read_to_string(&completed.output_file).expect("completed output should exist");
|
||||||
|
assert!(completed_manifest.contains("\"status\": \"completed\""));
|
||||||
|
assert!(completed_output.contains("Finished successfully"));
|
||||||
|
|
||||||
|
let failed = execute_agent_with_spawn(
|
||||||
|
AgentInput {
|
||||||
|
description: "Fail the task".to_string(),
|
||||||
|
prompt: "Do the failing work".to_string(),
|
||||||
|
subagent_type: Some("Verification".to_string()),
|
||||||
|
name: Some("fail-task".to_string()),
|
||||||
|
model: None,
|
||||||
|
},
|
||||||
|
|job| {
|
||||||
|
persist_agent_terminal_state(
|
||||||
|
&job.manifest,
|
||||||
|
"failed",
|
||||||
|
None,
|
||||||
|
Some(String::from("simulated failure")),
|
||||||
|
)
|
||||||
|
},
|
||||||
|
)
|
||||||
|
.expect("failed agent should still spawn");
|
||||||
|
|
||||||
|
let failed_manifest =
|
||||||
|
std::fs::read_to_string(&failed.manifest_file).expect("failed manifest should exist");
|
||||||
|
let failed_output =
|
||||||
|
std::fs::read_to_string(&failed.output_file).expect("failed output should exist");
|
||||||
|
assert!(failed_manifest.contains("\"status\": \"failed\""));
|
||||||
|
assert!(failed_manifest.contains("simulated failure"));
|
||||||
|
assert!(failed_output.contains("simulated failure"));
|
||||||
|
|
||||||
|
let spawn_error = execute_agent_with_spawn(
|
||||||
|
AgentInput {
|
||||||
|
description: "Spawn error task".to_string(),
|
||||||
|
prompt: "Never starts".to_string(),
|
||||||
|
subagent_type: None,
|
||||||
|
name: Some("spawn-error".to_string()),
|
||||||
|
model: None,
|
||||||
|
},
|
||||||
|
|_| Err(String::from("thread creation failed")),
|
||||||
|
)
|
||||||
|
.expect_err("spawn errors should surface");
|
||||||
|
assert!(spawn_error.contains("failed to spawn sub-agent"));
|
||||||
|
let spawn_error_manifest = std::fs::read_dir(&dir)
|
||||||
|
.expect("agent dir should exist")
|
||||||
|
.filter_map(Result::ok)
|
||||||
|
.map(|entry| entry.path())
|
||||||
|
.filter(|path| path.extension().and_then(|ext| ext.to_str()) == Some("json"))
|
||||||
|
.find_map(|path| {
|
||||||
|
let contents = std::fs::read_to_string(&path).ok()?;
|
||||||
|
contents
|
||||||
|
.contains("\"name\": \"spawn-error\"")
|
||||||
|
.then_some(contents)
|
||||||
|
})
|
||||||
|
.expect("failed manifest should still be written");
|
||||||
|
assert!(spawn_error_manifest.contains("\"status\": \"failed\""));
|
||||||
|
assert!(spawn_error_manifest.contains("thread creation failed"));
|
||||||
|
|
||||||
|
std::env::remove_var("CLAWD_AGENT_STORE");
|
||||||
|
let _ = std::fs::remove_dir_all(dir);
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn agent_tool_subset_mapping_is_expected() {
|
||||||
|
let general = allowed_tools_for_subagent("general-purpose");
|
||||||
|
assert!(general.contains("bash"));
|
||||||
|
assert!(general.contains("write_file"));
|
||||||
|
assert!(!general.contains("Agent"));
|
||||||
|
|
||||||
|
let explore = allowed_tools_for_subagent("Explore");
|
||||||
|
assert!(explore.contains("read_file"));
|
||||||
|
assert!(explore.contains("grep_search"));
|
||||||
|
assert!(!explore.contains("bash"));
|
||||||
|
|
||||||
|
let plan = allowed_tools_for_subagent("Plan");
|
||||||
|
assert!(plan.contains("TodoWrite"));
|
||||||
|
assert!(plan.contains("StructuredOutput"));
|
||||||
|
assert!(!plan.contains("Agent"));
|
||||||
|
|
||||||
|
let verification = allowed_tools_for_subagent("Verification");
|
||||||
|
assert!(verification.contains("bash"));
|
||||||
|
assert!(verification.contains("PowerShell"));
|
||||||
|
assert!(!verification.contains("write_file"));
|
||||||
|
}
|
||||||
|
|
||||||
|
#[derive(Debug)]
|
||||||
|
struct MockSubagentApiClient {
|
||||||
|
calls: usize,
|
||||||
|
input_path: String,
|
||||||
|
}
|
||||||
|
|
||||||
|
impl runtime::ApiClient for MockSubagentApiClient {
|
||||||
|
fn stream(&mut self, request: ApiRequest) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||||
|
self.calls += 1;
|
||||||
|
match self.calls {
|
||||||
|
1 => {
|
||||||
|
assert_eq!(request.messages.len(), 1);
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::ToolUse {
|
||||||
|
id: "tool-1".to_string(),
|
||||||
|
name: "read_file".to_string(),
|
||||||
|
input: json!({ "path": self.input_path }).to_string(),
|
||||||
|
},
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
2 => {
|
||||||
|
assert!(request.messages.len() >= 3);
|
||||||
|
Ok(vec![
|
||||||
|
AssistantEvent::TextDelta("Scope: completed mock review".to_string()),
|
||||||
|
AssistantEvent::MessageStop,
|
||||||
|
])
|
||||||
|
}
|
||||||
|
_ => panic!("unexpected mock stream call"),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
#[test]
|
||||||
|
fn subagent_runtime_executes_tool_loop_with_isolated_session() {
|
||||||
|
let _guard = env_lock()
|
||||||
|
.lock()
|
||||||
|
.unwrap_or_else(std::sync::PoisonError::into_inner);
|
||||||
|
let path = temp_path("subagent-input.txt");
|
||||||
|
std::fs::write(&path, "hello from child").expect("write input file");
|
||||||
|
|
||||||
|
let mut runtime = ConversationRuntime::new(
|
||||||
|
Session::new(),
|
||||||
|
MockSubagentApiClient {
|
||||||
|
calls: 0,
|
||||||
|
input_path: path.display().to_string(),
|
||||||
|
},
|
||||||
|
SubagentToolExecutor::new(BTreeSet::from([String::from("read_file")])),
|
||||||
|
agent_permission_policy(),
|
||||||
|
vec![String::from("system prompt")],
|
||||||
|
);
|
||||||
|
|
||||||
|
let summary = runtime
|
||||||
|
.run_turn("Inspect the delegated file", None)
|
||||||
|
.expect("subagent loop should succeed");
|
||||||
|
|
||||||
|
assert_eq!(
|
||||||
|
final_assistant_text(&summary),
|
||||||
|
"Scope: completed mock review"
|
||||||
|
);
|
||||||
|
assert!(runtime
|
||||||
|
.session()
|
||||||
|
.messages
|
||||||
|
.iter()
|
||||||
|
.flat_map(|message| message.blocks.iter())
|
||||||
|
.any(|block| matches!(
|
||||||
|
block,
|
||||||
|
runtime::ContentBlock::ToolResult { output, .. }
|
||||||
|
if output.contains("hello from child")
|
||||||
|
)));
|
||||||
|
|
||||||
|
let _ = std::fs::remove_file(path);
|
||||||
|
}
|
||||||
|
|
||||||
#[test]
|
#[test]
|
||||||
fn agent_rejects_blank_required_fields() {
|
fn agent_rejects_blank_required_fields() {
|
||||||
let missing_description = execute_tool(
|
let missing_description = execute_tool(
|
||||||
|
|||||||
Reference in New Issue
Block a user